NetBSD Problem Report #1010

From gnats  Mon May  1 14:57:36 1995
Received: from pain.lcs.mit.edu (pain.lcs.mit.edu [128.52.46.239]) by sun-lamp.cs.berkeley.edu (8.6.10/8.6.10) with ESMTP id OAA02105 for <gnats-bugs@sun-lamp.cs.berkeley.edu>; Mon, 1 May 1995 14:57:32 -0700
Message-Id: <199505010542.WAA03079@blurg.ucsb.edu>
Date: Sun, 30 Apr 1995 22:42:34 -0700
From: henric@eci1.ucsb.edu
Reply-To: uhenric@mcl.ucsb.edu
To: gnats-bugs@NetBSD.ORG
Subject: hupcl ignored
X-Send-Pr-Version: 3.2

>Number:         1010
>Category:       port-amiga
>Synopsis:       hupcl ignored
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    gnats-admin
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 01 15:05:07 +0000 1995
>Closed-Date:    Sun Sep 21 17:19:13 +0000 1997
>Last-Modified:  Sun Sep 21 17:25:00 +0000 1997
>Originator:     Henric Jungheim
>Release:        -current from Apr 29th <NetBSD-current source date>
>Organization:
Henric Jungheim  --  uhenric@mcl.ucsb.edu  --  henric@engineering.ucsb.edu
>Environment:

System: NetBSD blurg.ucsb.edu 1.0A NetBSD 1.0A (HENRIC) #22: Sun Apr 30 04:13:54 PDT 1995 henric@blurg.ucsb.edu:/usr/src/sys/arch/amiga/compile/HENRIC amiga


>Description:

Line 356 to 359 of /sys/arch/amiga/dev/ser.c check if "hupcl" is asserted.
If it is not asserted, then the modem lines are _not_ to be changed.
For some reason, these lines are between an #if 0/#endif pair.  I removed
the "#if 0/#endif" and now hupcl works as it should.  Now I'm wondering
why it was disabled in the first place...

>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: is 
State-Changed-When: Sun Sep 21 10:19:13 PDT 1997 
State-Changed-Why:  
The mentioned #if  0 were in our source tree from the beginning; I guess 
because part of the cleanup must be done even if HUPCL is not set. 
We set the other bits to 0, but leave DTR alone if HUPCL is not set.  
Furthermore, we sleep for a small while after resetting bits, so that they will 
be recognized even if we are reopened immediately after returning from close. 
>Unformatted:

Home	PR Database Search