NetBSD Problem Report #1218

From gnats  Wed Jul 12 04:54:29 1995
Received: from orpheus.amdahl.com (orpheus.amdahl.com [129.212.11.6]) by sun-lamp.pc.cs.cmu.edu (8.6.11/8.6.10) with SMTP id EAA00978 for <gnats-bugs@gnats.netbsd.org>; Wed, 12 Jul 1995 04:53:52 -0400
Message-Id: <m0sVxZz-0000AUC@amdahl.uts.amdahl.com>
Date: Wed, 12 Jul 1995 01:55:39 -0700 (PDT)
From: agc@uts.amdahl.com (Alistair G. Crooks)
Reply-To: agc@uts.amdahl.com (Alistair G. Crooks)
To: gnats-bugs@gnats.netbsd.org
Subject: /sys/netiso/tuba_usrreq.c fails to compile

>Number:         1218
>Category:       kern
>Synopsis:       /sys/netiso/tuba_usrreq.c failes to compile after CIRCLEQ chgs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 12 09:05:01 +0000 1995
>Closed-Date:    Wed Jul 12 09:14:47 +0000 1995
>Last-Modified:  Wed Aug 07 21:39:28 +0000 2002
>Originator:     Alistair G. Crooks
>Release:        July 8th sources, but it's been around for longer.
>Organization:
Amdahl Corporation
>Environment:
NetBSD/i386 1.0A, July 8th sources
System: NetBSD rumpy.osg.uk.amdahl.com 1.0A NetBSD 1.0A (RUMPY) #0: Mon Jul 10 11:41:50 BST 1995 root@rumpy.osg.uk.amdahl.com:/usr/src/sys/arch/i386/compile/RUMPY i386


>Description:
	compile a kernel with "options ISO". Compilation will fail
	in /sys/netiso/tuba_usrreq.c. It looks like this file is a
	hangover from the LIST to CIRCLEQ changes, and was missed.
>How-To-Repeat:
	see above
>Fix:
*** /usr/src/sys/netiso/tuba_usrreq.c	1995/07/10 09:46:08	1.1
--- /usr/src/sys/netiso/tuba_usrreq.c	1995/07/10 10:47:41
***************
*** 136,143 ****
  			iso_pcbdetach(isop);
  		} else {
  			inp = sotoinpcb(so);
! 			LIST_REMOVE(inp, inp_list);
! 			LIST_INSERT_HEAD(&tuba_inpcb.inpt_list, inp, inp_list);
  			inp->inp_table = &tuba_inpcb;
  			tp = intotcpcb(inp);
  			if (tp == 0)
--- 136,143 ----
  			iso_pcbdetach(isop);
  		} else {
  			inp = sotoinpcb(so);
! 			CIRCLEQ_REMOVE(&inp->inp_table->inpt_queue, inp, inp_queue);
! 			CIRCLEQ_INSERT_HEAD(&tuba_inpcb.inpt_queue, inp, inp_queue);
  			inp->inp_table = &tuba_inpcb;
  			tp = intotcpcb(inp);
  			if (tp == 0)
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: cgd 
State-Changed-When: Wed Jul 12 05:14:47 EDT 1995 
State-Changed-Why:  
fixed as specified, modulo style. 
>Unformatted:

Home	PR Database Search