NetBSD Problem Report #1553

From gnats  Sat Sep 30 18:00:20 1995
Received: from rupert.oscs.montana.edu (rupert.oscs.montana.edu [153.90.253.65]) by sun-lamp.pc.cs.cmu.edu (8.6.11/8.6.10) with ESMTP id SAA11688 for <gnats-bugs@gnats.netbsd.org>; Sat, 30 Sep 1995 18:00:19 -0400
Message-Id: <199509302159.PAA16700@rupert.oscs.montana.edu>
Date: Sat, 30 Sep 1995 15:59:12 -0600
From: Chris Jones <cjones@rupert.oscs.montana.edu>
Reply-To: cjones@rupert.oscs.montana.edu
To: gnats-bugs@gnats.netbsd.org
Subject: spurious call to Debugger() in macrom.c
X-Send-Pr-Version: 3.2

>Number:         1553
>Category:       port-mac68k
>Synopsis:       spurious call to Debugger() in macrom.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnats-admin
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Sep 30 18:05:01 +0000 1995
>Closed-Date:    Sun Oct 01 02:28:31 +0000 1995
>Last-Modified:  Thu Jul 24 18:27:13 +0000 1997
>Originator:     Chris Jones
>Release:        Today
>Organization:
**********************cjones@rupert.oscs.montana.edu**********************
* Chris  | "Nobody likes brain alteration!"                              *
*  Jones |                           --Peri Brown, _Doctor Who_          *
**************************************************************************
>Environment:

System: NetBSD rupert.oscs.montana.edu 1.0A NetBSD 1.0A (GENERIC) #0: Thu Sep 7 18:51:09 MDT 1995 root@amiga2.oscs.montana.edu:/mnt/src/sys/arch/mac68k/compile/GENERIC mac68k


>Description:
macrom.c calls Debugger() without enclosing the function call in any
kind of an #ifdef KGDB (or whatever is actually appropriate).  This
causes an error to the tune of undefined symbol referenced from text
segment when trying to compile a kernel without GDB or KGDB or
DIAGNOSTIC or whatever else...

>How-To-Repeat:

>Fix:
This seems to work, but don't take my work for it; this is the first
kernel patch I've ever submitted:

*** macrom.c.orig	Sat Sep 30 15:49:08 1995
--- macrom.c.new	Sat Sep 30 15:48:37 1995
***************
*** 94,101 ****
  void
  mrg_lvl1dtpanic()		/* Lvl1DT stopper */
  {
! 	printf("Agh!  I was called from Lvl1DT!!!\n");
! 	Debugger();
  }

  void
--- 94,100 ----
  void
  mrg_lvl1dtpanic()		/* Lvl1DT stopper */
  {
! 	panic("Agh!  I was called from Lvl1DT!!!\n");
  }

  void
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: briggs 
State-Changed-When: Sat Sep 30 22:28:31 EDT 1995 
State-Changed-Why:  
Changed macrom.c to have #ifdef DDB around call to Debugger.  Don't 
want to panic because it is useful to know if this is being called, 
but it's not necessarily a panic condition. 
>Unformatted:

Home	PR Database Search