NetBSD Problem Report #17024

Received: (qmail 22422 invoked from network); 25 May 2002 17:44:13 -0000
Message-Id: <200205251743.g4PHhvX07222@toybox.gendalia.org>
Date: Sat, 25 May 2002 12:43:57 -0500 (CDT)
From: nb-pr@gendalia.org
Reply-To: nb-pr@gendalia.org
To: gnats-bugs@gnats.netbsd.org
Subject: postinstall doesn't list everything wrong at once
X-Send-Pr-Version: 3.95

>Number:         17024
>Category:       install
>Synopsis:       postinstall doesn't list everything wrong when run
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lukem
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 25 17:45:00 +0000 2002
>Closed-Date:    Sat May 09 18:03:22 +0000 2009
>Last-Modified:  Sat May 09 18:03:22 +0000 2009
>Originator:     Tracy Di Marco White
>Release:        NetBSD 1.6_BETA1
>Organization:
>Environment:
System: NetBSD toybox 1.5ZC NetBSD 1.5ZC (TOYBOX) #2: Sun May 5 22:18:57 CDT 2002 gendalia@toybox:/usr/local/build/compile/TOYBOX i386
Architecture: i386
Machine: i386

Building 1.6_BETA1 cvs updated May 24, 2002 for shark using build.sh
into a 1.5.3_RC1 DESTDIR
>Description:
postinstall only lists one thing wrong at a time for at least some of the
checks.  It tells me that I need gid fix ntpd, I fix, I run it again, it tells
me I need gid fix sshd, I fix, I run it again, it tells me I need gid fix
named.  The same thing happens with uid fix.

It also thinks I have:
  Obsolete rc.conf(5) variable '$sshd_conf_dir' found.

when nowhere in the -d specified do I have $sshd_conf_dir in a file.
This is worrisome, as I don't know if this suffers from the same problem
as above, listing one problem at a time, so I don't know if there are
other ssh problems to fix, and it just hasn't told me about them yet.
>How-To-Repeat:
run postinstall against a tree upgraded from shark's 1.5.3_RC1 snapshot to
the 1.6_BETA1 source tree.
>Fix:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: toolchain-manager->lukem 
Responsible-Changed-By: lukem 
Responsible-Changed-When: Sat May 25 20:54:47 PDT 2002 
Responsible-Changed-Why:  
this is mine 
State-Changed-From-To: open->feedback 
State-Changed-By: lukem 
State-Changed-When: Sat May 25 21:47:44 PDT 2002 
State-Changed-Why:  
I've committed a fix (rev 1.17; pullup for 1.6 requested) which resolves 
the "missing users" problem. (They're actually listed, there's just newline 
separators in the version you're using) 

As to the other problem (sshd_conf_dir).  As we've discussed, it's because 
${DESTDIR}/etc/rc.conf contains 
  . /etc/defaults/rc.conf 
so if your /etc/defaults/rc.conf contains the obsolete variable, you're going  
to get warned :(     
The solutions to this each have their own problem: 
a) using chroot(8) prevents postinstall check from being run as non root. 
   currently there's only one failure because of that (/etc/master.passwd 
   uid check), and I'd prefer not to add any more 
b) using grep doesn't work well because there might be shell magick
   in use to set a given variable (or another file might be sourced, or...).

Food for thought...

In any case, should we close this PR now, or suspend it pending
further ideas, or leave it open?


From: nb-pr@gendalia.org
To: gnats-bugs@netbsd.org
Cc:  
Subject: Re: toolchain/17024 
Date: Thu, 06 Jun 2002 22:21:09 -0500

 A partial solution may be to detect if postinstall is running as root, and if
 so, use chroot then.  This doesn't fix DESTDIR installs run unprivileged, but
 it does limit the problem to them.  For them, maybe check the
 $DESTDIR/etc/defaults files separately, and include a warning that if using
 a complete path to source additional files, it will include files from the
 HOST rather than in the DESTDIR.

 Tracy
State-Changed-From-To: feedback->suspended 
State-Changed-By: lukem 
State-Changed-When: Tue Jun 18 07:52:03 PDT 2002 
State-Changed-Why:  
chroot really isn't a solution; it would only work if you had a working 
shell for the current architecture in ${DESTDIR}, and it strikes me 
that we're adding more and more special cases to work around a local 
issue. 
i'll be disabling the default postinstall check for DESTDIR!=/ builds RSN 
anyway. 
State-Changed-From-To: suspended->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 27 Apr 2009 07:22:03 +0000
State-Changed-Why:
Is this still an issue?


From: Luke Mewburn <lukem@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: lukem@NetBSD.org, netbsd-bugs@netbsd.org, gnats-admin@netbsd.org,
	dholland@NetBSD.org, nb-pr@gendalia.org
Subject: Re: install/17024 (postinstall doesn't list everything wrong when
	run)
Date: Fri, 8 May 2009 11:16:35 +1000

 --H25ow1gEc5p8sQPX
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable

 On Mon, Apr 27, 2009 at 07:22:04AM +0000, dholland@NetBSD.org wrote:
   | Synopsis: postinstall doesn't list everything wrong when run
   |=20
   | State-Changed-From-To: suspended->feedback
   | State-Changed-By: dholland@NetBSD.org
   | State-Changed-When: Mon, 27 Apr 2009 07:22:03 +0000
   | State-Changed-Why:
   | Is this still an issue?
   |=20

 I don't consider it to be -- the original problem was solved around
 the time of the PR, and there isn't really an easy way to solve
 the "obsolete warning" getting triggered in a DESTDIR build without
 a lot of complexity.

 --H25ow1gEc5p8sQPX
 Content-Type: application/pgp-signature
 Content-Disposition: inline

 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.9 (NetBSD)

 iEYEARECAAYFAkoDh/MACgkQpBhtmn8zJHLFMgCeKEG7wJehB6Fz6PA3r6Ltle/9
 AXAAoLKtj3CtzY9WCY/PfaLh6SBUiVjp
 =7zdt
 -----END PGP SIGNATURE-----

 --H25ow1gEc5p8sQPX--

State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 09 May 2009 18:03:22 +0000
State-Changed-Why:
ok, let's close it then. thanks :-)


>Unformatted:

Home	PR Database Search