NetBSD Problem Report #2172

From gnats  Mon Mar  4 19:11:59 1996
Received: from Collatz.McRCIM.McGill.EDU by pain.lcs.mit.edu (8.7.4/8.6.12) with SMTP id SAA03546 for <gnats-bugs@gnats.netbsd.org>; Mon, 4 Mar 1996 18:54:20 -0500 (EST)
Message-Id: <199603042353.SAA10040@Collatz.McRCIM.McGill.EDU>
Date: Mon, 4 Mar 1996 18:53:34 -0500
From: der Mouse <mouse@Collatz.McRCIM.McGill.EDU>
Reply-To: mouse@Collatz.McRCIM.McGill.EDU
To: gnats-bugs@gnats.netbsd.org
Subject: [dM] sun3 blinkenlights, take 3
X-Send-Pr-Version: 3.2

>Number:         2172
>Category:       port-sun3
>Synopsis:       [dM] sun3 blinkenlights, take 3
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnats-admin
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 04 19:20:02 +0000 1996
>Closed-Date:    Tue Mar 18 22:31:25 +0000 1997
>Last-Modified:  Tue Mar 18 22:33:49 +0000 1997
>Originator:     der Mouse
>Release:        -current supped Feb 27 AM
>Organization:
	Dis-
>Environment:
	Any sun3 (work done on -3/110)
>Description:
	As in PRs 2144 and 2163, the sun3 back-panel blinkenlights are
	a bit boring.  This patch is like 2163 from user-land's point
	of view; it provides /dev/leds with the same interface as
	before.  But it provides it as major 3 minor 13 instead of a
	new major.  This eliminates the mess in sun3/conf.c and reduces
	device number space bloat.
>How-To-Repeat:
	Look at the moving light, wish it were more interesting.
>Fix:
	Here's the patch kit.  I chose minor 13 rather arbitrarily.  I
	don't know why the big gap between minor 2 and minor 11; if
	minor 13 is inappropriate for whatever reason, the mem.c and
	MAKEDEV patches of course need to be twoken.

	This PR supersedes 2144 and 2163, which may now be closed at
	will.

#! /bin/sh
#
# Shar: Shell Archiver
#
# This archive created Mon Mar  4 13:26:02 1996
# Run this through sh to create:
#	apply-script
#	patch-etc-etc.sun3-MAKEDEV
#	patch-share-man-man4-man4.sun3-Makefile
#	patch-share-man-man4-man4.sun3-leds.4
#	patch-sys-arch-sun3-conf-files.sun3
#	patch-sys-arch-sun3-sun3-clock.c
#	patch-sys-arch-sun3-sun3-leds-extern.h
#	patch-sys-arch-sun3-sun3-leds.c
#	patch-sys-arch-sun3-sun3-mem.c
echo x - apply-script \(738 characters\)
sed 's/^X//' > apply-script << \EOF
X#!/bin/sh
Xcase $# in
X	1)	;;
X	*)	echo "Usage: $0 base-directory-to-patch" 1>&2
X		echo "eg:    $0 /usr/src" 1>&2
X		exit 1
X		;;
Xesac
Xpatch "$1"/etc/etc.sun3/MAKEDEV < patch-etc-etc.sun3-MAKEDEV
Xpatch "$1"/share/man/man4/man4.sun3/Makefile < patch-share-man-man4-man4.sun3-Makefile
Xpatch "$1"/share/man/man4/man4.sun3/leds.4 < patch-share-man-man4-man4.sun3-leds.4
Xpatch "$1"/sys/arch/sun3/conf/files.sun3 < patch-sys-arch-sun3-conf-files.sun3
Xpatch "$1"/sys/arch/sun3/sun3/clock.c < patch-sys-arch-sun3-sun3-clock.c
Xpatch "$1"/sys/arch/sun3/sun3/leds-extern.h < patch-sys-arch-sun3-sun3-leds-extern.h
Xpatch "$1"/sys/arch/sun3/sun3/leds.c < patch-sys-arch-sun3-sun3-leds.c
Xpatch "$1"/sys/arch/sun3/sun3/mem.c < patch-sys-arch-sun3-sun3-mem.c
EOF
if test 738 -ne "`wc -c apply-script`"
then
echo shar: error transmitting apply-script \(should have been 738 characters\)
fi
echo x - patch-etc-etc.sun3-MAKEDEV \(254 characters\)
sed 's/^X//' > patch-etc-etc.sun3-MAKEDEV << \EOF
X--- OLD/etc/etc.sun3/MAKEDEV	Thu Jan  1 00:00:00 1970
X+++ NEW/etc/etc.sun3/MAKEDEV	Thu Jan  1 00:00:00 1970
X@@ -105,6 +105,7 @@
X 	mk stdin	c 23 0
X 	mk stdout	c 23 1
X 	mk stderr	c 23 2
X+	mk leds		c 3 13 644
X 	;;
X 
X fd)
X@@ -210,4 +211,3 @@
X 
X esac
X done
X-
EOF
if test 254 -ne "`wc -c patch-etc-etc.sun3-MAKEDEV`"
then
echo shar: error transmitting patch-etc-etc.sun3-MAKEDEV \(should have been 254 characters\)
fi
echo x - patch-share-man-man4-man4.sun3-Makefile \(401 characters\)
sed 's/^X//' > patch-share-man-man4-man4.sun3-Makefile << \EOF
X--- OLD/share/man/man4/man4.sun3/Makefile	Thu Jan  1 00:00:00 1970
X+++ NEW/share/man/man4/man4.sun3/Makefile	Thu Jan  1 00:00:00 1970
X@@ -1,7 +1,7 @@
X # 	from: @(#)Makefile	8.2 (Berkeley) 2/16/94
X #	$NetBSD: Makefile,v 1.1.1.1 1995/08/08 20:18:53 gwr Exp $
X 
X-MAN=	bwtwo.4 cgtwo.4 cgfour.4 ie.4 le.4 mem.4
X+MAN=	bwtwo.4 cgtwo.4 cgfour.4 ie.4 le.4 leds.4 mem.4
X MLINKS=	mem.4 kmem.4
X MANSUBDIR=/sun3
X 
EOF
if test 401 -ne "`wc -c patch-share-man-man4-man4.sun3-Makefile`"
then
echo shar: error transmitting patch-share-man-man4-man4.sun3-Makefile \(should have been 401 characters\)
fi
echo x - patch-share-man-man4-man4.sun3-leds.4 \(2217 characters\)
sed 's/^X//' > patch-share-man-man4-man4.sun3-leds.4 << \EOF
X--- .empty	Thu Jan  1 00:00:00 1970
X+++ NEW/share/man/man4/man4.sun3/leds.4	Thu Jan  1 00:00:00 1970
X@@ -0,0 +1,57 @@
X+.Dd March 2, 1996
X+.Dt LEDS 4 sun3
X+.Os NetBSD 1.1a
X+.Sh NAME
X+.Nm leds
X+.Nd back-panel LEDs
X+.Sh DESCRIPTION
X+The file
X+.Nm /dev/leds
X+is an interface to the diagnostic array of 8 light-emitting diodes on
X+the back of the computer.
X+.Pp
X+This file contains two
X+.Sy unsigned int Ns s
X+(in native byte order, as would be written by passing the address of an
X+.Sy unsigned int
X+to
X+.Xr write 2 ,
X+which on a Sun-3 means big-endian), followed by a string of bytes.  The
X+string of bytes gives the successive patterns to be displayed on the
X+LEDs; each byte's bits are taken and used to drive the LEDs.  A 0 bit
X+illuminates the corresponding LED; a 1 bit leaves the corresponding LED
X+dark.  The first
X+.Sy unsigned int
X+gives the number of clock ticks that are skipped after each pattern is
X+loaded before the next is loaded.  For example, if this value is 0, a
X+new pattern is loaded each clock tick; if it is 3, a new pattern will
X+be loaded every fourth clock tick (ie, three ticks will be skipped
X+between loads).  The second
X+.Sy unsigned int
X+gives the number of patterns in the list, that is, the number of bytes
X+following the two
X+.Sy unsigned int Ns s.
X+.Pp
X+There are limits on the two integer values; attempting a write that
X+would cause either of them to take on too large a value causes the
X+write to return EIO without affecting anything.  The limits are
X+compiled into the kernel; as of this writing, the first one can be at
X+most 128, the second at most 10240.
X+.Sh EXAMPLES
X+This example displays a single lit LED scrolling from one end of the
X+display to the other, over and over, moving every six clock ticks.  The
X+first eight bytes supply the two
X+.Sy unsigned int Ns s
X+mentioned above; the other eight specify the patterns.  (Convert them
X+to binary, and remember that 0 bits mean lit LEDs.)
X+.Bd -ragged -offset -ident
X+# echo 0 0 0 5 0 0 0 8 254 253 250 247 239 223 175 127 |
X+  awk '{ for (i=1;i<=NF;i++) printf("%c",$i+0); }' > /dev/leds
X+.Ed
X+.Sh FILES
X+.Bl -tag -width /dev/leds -compact
X+.It Pa /dev/leds
X+.El
X+.Sh HISTORY
X+.Nm /dev/leds
X+appeared in post-1.1 NetBSD.
EOF
if test 2217 -ne "`wc -c patch-share-man-man4-man4.sun3-leds.4`"
then
echo shar: error transmitting patch-share-man-man4-man4.sun3-leds.4 \(should have been 2217 characters\)
fi
echo x - patch-sys-arch-sun3-conf-files.sun3 \(309 characters\)
sed 's/^X//' > patch-sys-arch-sun3-conf-files.sun3 << \EOF
X--- OLD/sys/arch/sun3/conf/files.sun3	Thu Jan  1 00:00:00 1970
X+++ NEW/sys/arch/sun3/conf/files.sun3	Thu Jan  1 00:00:00 1970
X@@ -30,6 +30,7 @@
X file arch/sun3/sun3/trap.c		
X file arch/sun3/sun3/vector.c		
X file arch/sun3/sun3/vm_machdep.c	
X+file arch/sun3/sun3/leds.c
X 
X include "../../m68k/fpe/files.fpe"
X 
EOF
if test 309 -ne "`wc -c patch-sys-arch-sun3-conf-files.sun3`"
then
echo shar: error transmitting patch-sys-arch-sun3-conf-files.sun3 \(should have been 309 characters\)
fi
echo x - patch-sys-arch-sun3-sun3-clock.c \(1069 characters\)
sed 's/^X//' > patch-sys-arch-sun3-sun3-clock.c << \EOF
X--- OLD/sys/arch/sun3/sun3/clock.c	Thu Jan  1 00:00:00 1970
X+++ NEW/sys/arch/sun3/sun3/clock.c	Thu Jan  1 00:00:00 1970
X@@ -241,11 +241,12 @@
X  * This is is called by the "custom" interrupt handler
X  * after it has reset the pending bit in the clock.
X  */
X-int clock_count = 0;
X+/* Communication with the /dev/leds driver (leds.c)... */
X+#include "leds-extern.h"
X void clock_intr(frame)
X 	struct clockframe *frame;
X {
X-	static unsigned char led_pattern = 0xFE;
X+	unsigned int i;
X 
X #ifdef	DIAGNOSTIC
X 	if (!clk_intr_ready)
X@@ -253,13 +254,16 @@
X #endif
X 
X 	/* XXX - Move this LED frobbing to the idle loop? */
X-	clock_count++;
X-	if ((clock_count & 7) == 0) {
X-		led_pattern = (led_pattern << 1) | 1;
X-		if (led_pattern == 0xFF)
X-			led_pattern = 0xFE;
X-		set_control_byte((char *) DIAG_REG, led_pattern);
X-	}
X+	i = led_countdown;
X+	if (i == 0) {
X+		led_countdown = led_countmax;
X+		i = led_px;
X+		set_control_byte((char *) DIAG_REG, led_patterns[i]);
X+		if (i == 0)
X+			i = led_n_patterns;
X+		led_px = i - 1;
X+	} else
X+		led_countdown = i - 1;
X 	hardclock(frame);
X }
X 
EOF
if test 1069 -ne "`wc -c patch-sys-arch-sun3-sun3-clock.c`"
then
echo shar: error transmitting patch-sys-arch-sun3-sun3-clock.c \(should have been 1069 characters\)
fi
echo x - patch-sys-arch-sun3-sun3-leds-extern.h \(353 characters\)
sed 's/^X//' > patch-sys-arch-sun3-sun3-leds-extern.h << \EOF
X--- .empty	Thu Jan  1 00:00:00 1970
X+++ NEW/sys/arch/sun3/sun3/leds-extern.h	Thu Jan  1 00:00:00 1970
X@@ -0,0 +1,5 @@
X+extern volatile unsigned int led_n_patterns;
X+extern volatile unsigned int led_countmax;
X+extern volatile const unsigned char * volatile led_patterns;
X+extern volatile unsigned int led_countdown;
X+extern volatile unsigned int led_px;
EOF
if test 353 -ne "`wc -c patch-sys-arch-sun3-sun3-leds-extern.h`"
then
echo shar: error transmitting patch-sys-arch-sun3-sun3-leds-extern.h \(should have been 353 characters\)
fi
echo x - patch-sys-arch-sun3-sun3-leds.c \(1511 characters\)
sed 's/^X//' > patch-sys-arch-sun3-sun3-leds.c << \EOF
X--- .empty	Thu Jan  1 00:00:00 1970
X+++ NEW/sys/arch/sun3/sun3/leds.c	Thu Jan  1 00:00:00 1970
X@@ -0,0 +1,57 @@
X+#include <sys/types.h>
X+#include <sys/uio.h>
X+#include <sys/systm.h>
X+#include <sys/errno.h>
X+#include <machine/psl.h>
X+
X+#include "leds-extern.h"
X+
X+#define MAXPVLEN 10240
X+#define MAXCDOWN 128
X+
X+static volatile unsigned char pattern[MAXPVLEN] =
X+	{ 0xff, 0xfe, 0xfc, 0xf8, 0xf0, 0xe0, 0xc0, 0x80,
X+	  0x00, 0x01, 0x03, 0x07, 0x0f, 0x1f, 0x3f, 0x7f
X+	};
X+
X+volatile unsigned int led_n_patterns = 16;
X+volatile const unsigned char * volatile led_patterns = &pattern[0];
X+volatile unsigned int led_countmax = 5;
X+volatile unsigned int led_countdown = 0;
X+volatile unsigned int led_px = 0;
X+
X+int ledrw(struct uio *uio)
X+{
X+ unsigned int v[2];
X+ int s;
X+ unsigned int o;
X+ int err;
X+
X+ if (uio->uio_offset > MAXPVLEN+sizeof(v)) return(0);
X+ s = splhigh();
X+ v[0] = led_countmax;
X+ v[1] = led_n_patterns;
X+ splx(s);
X+ o = uio->uio_offset;
X+ if (o < sizeof(v))
X+  { err = uiomove(((char *)&v[0])+o,sizeof(v)-o,uio);
X+    if (err) return(err);
X+    o = sizeof(v);
X+    if (uio->uio_rw == UIO_WRITE)
X+     { if ((v[0] > MAXCDOWN) || (v[1] < 1) || (v[1] > MAXPVLEN)) return(EIO);
X+       s = splhigh();
X+       led_countmax = v[0];
X+       led_n_patterns = v[1];
X+       led_countdown = 0;
X+       led_px = 0;
X+       splx(s);
X+     }
X+  }
X+ o -= sizeof(v);
X+ if (o >= v[1]) return(0);
X+ if (uio->uio_resid > 0)
X+  { err = uiomove(&pattern[o],v[1]-o,uio);
X+    if (err) return(err);
X+  }
X+ return(0);
X+}
EOF
if test 1511 -ne "`wc -c patch-sys-arch-sun3-sun3-leds.c`"
then
echo shar: error transmitting patch-sys-arch-sun3-sun3-leds.c \(should have been 1511 characters\)
fi
echo x - patch-sys-arch-sun3-sun3-mem.c \(348 characters\)
sed 's/^X//' > patch-sys-arch-sun3-sun3-mem.c << \EOF
X--- OLD/sys/arch/sun3/sun3/mem.c	Thu Jan  1 00:00:00 1970
X+++ NEW/sys/arch/sun3/sun3/mem.c	Thu Jan  1 00:00:00 1970
X@@ -217,6 +217,11 @@
X 			error = uiomove(zeropage, c, uio);
X 			continue;
X 
X+/* minor device 13 (/dev/leds) accesses the blinkenlights */
X+		case 13:
X+			error = ledrw(uio);
X+			return(error);
X+
X 		default:
X 			return (ENXIO);
X 		}
EOF
if test 348 -ne "`wc -c patch-sys-arch-sun3-sun3-mem.c`"
then
echo shar: error transmitting patch-sys-arch-sun3-sun3-mem.c \(should have been 348 characters\)
fi
exit 0
# end of shell archive

					der Mouse

			    mouse@collatz.mcrcim.mcgill.edu
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: gwr 
State-Changed-When: Tue Mar 18 14:31:25 PST 1997 
State-Changed-Why:  
Added the suggested functionality. 
>Unformatted:

Home	PR Database Search