NetBSD Problem Report #23985

Received: (qmail 27909 invoked by uid 605); 5 Jan 2004 03:09:52 -0000
Message-Id: <20040105030946.BF6695DB3@tombstone.localnet.gomerbud.com>
Date: Sun,  4 Jan 2004 19:09:46 -0800 (PST)
From: daver@tombstone.localnet.gomerbud.com
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: daver@gomerbud.com
To: gnats-bugs@gnats.netbsd.org
Subject: implement fb_mmap() on explora451
X-Send-Pr-Version: 3.95

>Number:         23985
>Category:       port-evbppc
>Synopsis:       implement fb_mmap() on explora451
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    hannken
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 05 03:10:00 +0000 2004
>Closed-Date:    Mon Jan 05 16:09:00 +0000 2004
>Last-Modified:  Mon Jan 05 16:09:00 +0000 2004
>Originator:     David P. Reese Jr.
>Release:        NetBSD 1.6ZF
>Organization:
   David P. Reese, Jr.                                  daver at gomerbud.com
                                               http://www.gomerbud.com/daver/
>Environment:


System: NetBSD tombstone.localnet.gomerbud.com 1.6ZF NetBSD 1.6ZF (TOMBSTONE) #2: Sun Dec 14 21:29:33 PST 2003 daver@tombstone.localnet.gomerbud.com:/usr/src/sys/arch/i386/compile/TOMBSTONE i386
Architecture: i386
Machine: i386
>Description:
	On the explora451, you cannot mmap() /dev/ttyE0 because fb_mmap()
	is not implemented.
>How-To-Repeat:

>Fix:
Index: evbppc/explora/dev/fb_elb.c
===================================================================
RCS file: /cvsroot/src/sys/arch/evbppc/explora/dev/fb_elb.c,v
retrieving revision 1.3
diff -u -u -r1.3 fb_elb.c
--- evbppc/explora/dev/fb_elb.c	2003/07/15 01:37:37	1.3
+++ evbppc/explora/dev/fb_elb.c	2004/01/05 03:03:50
@@ -235,7 +235,13 @@
 static paddr_t
 fb_mmap(void *v, off_t offset, int prot)
 {
-	return -1;
+	struct fb_elb_softc *sc = v;
+
+	if (offset < 0 || offset >= SIZE_FB)
+		return -1;
+
+	return bus_space_mmap(sc->sc_fb->fb_iot, BASE_FB, offset, prot,
+	    BUS_SPACE_MAP_LINEAR);
 }

 static int
>Release-Note:
>Audit-Trail:

From: Juergen Hannken-Illjes <hannken@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/23985 CVS commit: src/sys/arch/evbppc/explora/dev
Date: Mon,  5 Jan 2004 16:05:14 +0000 (UTC)

 Module Name:	src
 Committed By:	hannken
 Date:		Mon Jan  5 16:05:14 UTC 2004

 Modified Files:
 	src/sys/arch/evbppc/explora/dev: fb_elb.c

 Log Message:
 Implement fb_mmap(). From David P. Reese Jr. with PR #23985.


 To generate a diff of this commit:
 cvs rdiff -r1.3 -r1.4 src/sys/arch/evbppc/explora/dev/fb_elb.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed 
State-Changed-By: hannken 
State-Changed-When: Mon Jan 5 16:07:15 UTC 2004 
State-Changed-Why:  
Fixed with rev. 1.4 of src/sys/arch/evbppc/explora/dev/fb_elb.c 


Responsible-Changed-From-To: port-evbppc-maintainer->hannken 
Responsible-Changed-By: hannken 
Responsible-Changed-When: Mon Jan 5 16:07:15 UTC 2004 
Responsible-Changed-Why:  
Fixed with rev. 1.4 of src/sys/arch/evbppc/explora/dev/fb_elb.c 
>Unformatted:

Home	PR Database Search