NetBSD Problem Report #24350

Received: (qmail 29361 invoked by uid 605); 7 Feb 2004 23:00:58 -0000
Message-Id: <200402072300.i17N0piQ029838@mogli.lke.rad.klinikum.rwth-aachen.de>
Date: Sun, 8 Feb 2004 00:00:51 +0100 (MET)
From: Markus W Kilbinger <kilbi@rad.rwth-aachen.de>
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: kilbi@rad.rwth-aachen.de
To: gnats-bugs@gnats.NetBSD.org
Subject: security/amavis-perl bug (using clamd) and postfix support
X-Send-Pr-Version: 3.95

>Number:         24350
>Category:       pkg
>Synopsis:       amavis-perl needs some mods to work with clamd and postfix
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Feb 07 23:01:00 +0000 2004
>Closed-Date:    Tue May 28 07:28:05 +0000 2019
>Last-Modified:  Tue May 28 07:28:05 +0000 2019
>Originator:     
>Release:        NetBSD 1.6ZI
>Organization:
>Environment:
System: NetBSD mogli 1.6ZI NetBSD 1.6ZI (MOGLI) #19: Fri Feb 6 18:22:28 MET 2004 root@lwle5:/usr/src/sys/arch/i386/compile/MOGLI i386
Architecture: i386
Machine: i386
>Description:
To get amavis-perl work with clamd and post fix I needed the following
mods/pathes (see 'Fix'). One seems to be a bug in amavis-perl. The
others seem to be mods required for NetBSD ond postfix.
>How-To-Repeat:
Try to install/use amavis-perl package iwth postfix and clamd
>Fix:
(Sorry for the strange diffs; only had my patched installed pkg as reference...)

work.../amavisd-0.1/amavis/av/clamavd:

  	  if ($output =~ /FOUND$/) {      # no errors, a virus was found
  	      $scanner_errors = 0;
  	      @virusname = ($output =~ /: (.+) FOUND/g);
  -           return 1;  # 'true' indicates virus found and stops further checking
  +           do_virus($output);
  	  } elsif ($output =~ /OK$/) {            # no errors, no viruses
  	      $scanner_errors = 0;
  	  } elsif ($output =~ /ERROR$/) {

Otherwise no virus is found at all... ;-)

work.../amavisd-0.1/amavis/amavisd.in:

   # If IGNORE leaves zombies behind on your system,
   # switch the comments between the two lines below
  -# $SIG{CHLD} = \&deadbabe;
  -$SIG{CHLD} = 'IGNORE';
  +$SIG{CHLD} = \&deadbabe;
  +# $SIG{CHLD} = 'IGNORE';

   # may need to do more - eg. if logging changes, close/reopen syslog/log file
   # rethink - handler should be simple

Otherwise tons of proc zobies accumulate...

Makefile:

  Index: Makefile
  ===================================================================
  RCS file: /cvsroot/pkgsrc/security/amavis-perl/Makefile,v
  retrieving revision 1.12
  diff -u -r1.12 Makefile
  --- Makefile    2003/07/17 22:52:50     1.12
  +++ Makefile    2004/02/07 22:55:58
  @@ -64,6 +64,8 @@
   CONFIGURE_ARGS+=--enable-milter
   CONFIGURE_ARGS+=--with-milter-libs=${PREFIX}/lib
   CONFIGURE_ARGS+=--with-milter-includes=${PREFIX}/include
  +.elseif defined(USE_POSTFIX) && ${USE_POSTFIX} == "YES"
  +CONFIGURE_ARGS+=--enable-postfix
   .else
   CONFIGURE_ARGS+=--enable-smtp --with-smtp-port=${SMTPPORT}
   .endif

To get postfix specific code into generated amavisd (on demand)...
>Release-Note:
>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/24350 CVS commit: pkgsrc/mail/amavis-perl
Date: Mon, 10 Aug 2015 06:54:16 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Mon Aug 10 06:54:16 UTC 2015

 Modified Files:
 	pkgsrc/mail/amavis-perl: Makefile distinfo
 Added Files:
 	pkgsrc/mail/amavis-perl/patches: patch-amavis_amavisd.in
 	    patch-amavis_av_clamavd

 Log Message:
 Apply two bug fixes from Markus W Kilbinger in PR 24350:
   - handle SIGCHLD properly
   - make the code for contacting clamavd work properly


 To generate a diff of this commit:
 cvs rdiff -u -r1.9 -r1.10 pkgsrc/mail/amavis-perl/Makefile
 cvs rdiff -u -r1.1.1.1 -r1.2 pkgsrc/mail/amavis-perl/distinfo
 cvs rdiff -u -r0 -r1.1 \
     pkgsrc/mail/amavis-perl/patches/patch-amavis_amavisd.in \
     pkgsrc/mail/amavis-perl/patches/patch-amavis_av_clamavd

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/24350: amavis-perl needs some mods to work with clamd and
 postfix
Date: Mon, 10 Aug 2015 06:58:13 +0000

 On Mon, Aug 10, 2015 at 06:55:00AM +0000, David A. Holland wrote:
  >  Log Message:
  >  Apply two bug fixes from Markus W Kilbinger in PR 24350:
  >    - handle SIGCHLD properly
  >    - make the code for contacting clamavd work properly

 This deals with the first two parts of the PR; as for the third
 (building with postfix support), could you (or someone) provide a
 patch that updates options.mk? I'm not sure how it should be made to
 interact with the sendmail milter support.

 -- 
 David A. Holland
 dholland@netbsd.org

State-Changed-From-To: open->closed
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Tue, 28 May 2019 07:28:05 +0000
State-Changed-Why:
amavis-perl has been removed from pkgsrc.
Guess it's too late for that patch now.


>Unformatted:

Home	PR Database Search