NetBSD Problem Report #24363

Received: (qmail 29701 invoked by uid 605); 8 Feb 2004 18:30:42 -0000
Message-Id: <200402081830.i18IUcVQ001771@vash.cel.plethora.net>
Date: Sun, 8 Feb 2004 12:30:38 -0600 (CST)
From: seebs <seebs@vash.cel.plethora.net>
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: seebs@vash.cel.plethora.net
To: gnats-bugs@gnats.NetBSD.org
Subject: Slight tweak for pms code
X-Send-Pr-Version: 3.95

>Number:         24363
>Category:       kern
>Synopsis:       PS/2 mouse code could be a bit smarter
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    martin
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 08 18:31:00 +0000 2004
>Closed-Date:    
>Last-Modified:  Fri Feb 27 17:32:00 +0000 2004
>Originator:     seebs
>Release:        NetBSD 1.6ZI
>Organization:

>Environment:
System: NetBSD vash.cel.plethora.net 1.6ZI NetBSD 1.6ZI (VASH) #3: Tue Feb 3 01:31:41 CST 2004 root@vash.cel.plethora.net:/usr/src/sys/arch/i386/compile/VASH i386
Architecture: i386
Machine: i386
>Description:
	The pms code tries to remember its state, so it can reset again if
	there was a problem.  It sometimes resets when it shouldn't.
>How-To-Repeat:
	Mess around with cheap console switches.
>Fix:
	Change != to <.  :)

Index: pms.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pckbc/pms.c,v
retrieving revision 1.12
diff -c -r1.12 pms.c
*** pms.c	2002/10/02 16:52:04	1.12
--- pms.c	2004/02/08 18:30:24
***************
*** 455,461 ****
  			    res));
  		sc->protocol = PMS_UNKNOWN;
  		pms_enable(sc);
! 		if (sc->protocol != save_protocol) {
  #if defined(PMSDEBUG) || defined(DIAGNOSTIC)
  			printf("%s: protocol change, sleeping and retrying\n",
  			    sc->sc_dev.dv_xname);
--- 455,461 ----
  			    res));
  		sc->protocol = PMS_UNKNOWN;
  		pms_enable(sc);
! 		if (sc->protocol < save_protocol) {
  #if defined(PMSDEBUG) || defined(DIAGNOSTIC)
  			printf("%s: protocol change, sleeping and retrying\n",
  			    sc->sc_dev.dv_xname);
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: kern-bug-people->martin 
Responsible-Changed-By: martin 
Responsible-Changed-When: Fri Feb 27 14:15:01 UTC 2004 
Responsible-Changed-Why:  
I'll handle this. 

From: Martin Husemann <martin@duskware.de>
To: seebs <seebs@vash.cel.plethora.net>
Cc: gnats-bugs@gnats.NetBSD.org
Subject: Re: kern/24363: Slight tweak for pms code
Date: Fri, 27 Feb 2004 15:18:54 +0100

 On Sun, Feb 08, 2004 at 12:30:38PM -0600, seebs wrote:
 > >Fix:
 > 	Change != to <.  :)

 I would like to know the protocol (and saved_protocol) values in cases
 where this makes a difference. Could you add some printfs and report
 back?

 Thanks,

 Martin

From: seebs@plethora.net (Peter Seebach)
To: Martin Husemann <martin@duskware.de>
Cc: gnats-bugs@gnats.NetBSD.org
Subject: Re: kern/24363: Slight tweak for pms code 
Date: Fri, 27 Feb 2004 11:31:34 -0600

 In message <20040227141854.GA1757@drowsy.duskware.de>, Martin Husemann writes:
 >On Sun, Feb 08, 2004 at 12:30:38PM -0600, seebs wrote:
 >> >Fix:
 >> 	Change != to <.  :)
 >
 >I would like to know the protocol (and saved_protocol) values in cases
 >where this makes a difference. Could you add some printfs and report
 >back?

 The case that affected me (and doesn't now, but I still remember) was where
 the mouse mistakenly probed as a plain-old-mouse, when it actually had a
 scroll wheel.

 My theory is that if a scroll wheel mouse suddenly probes as a plain mouse,
 it's worth resetting it and trying again in case a stupid console switch
 just gave us bogus data.  On the other hand, if a plain mouse suddenly probes
 as a scroll wheel mouse, that's probably a successful probe following a failed
 one.

 -s
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.