NetBSD Problem Report #25110

Received: (qmail 5493 invoked by uid 605); 9 Apr 2004 07:18:42 -0000
Message-Id: <20040409071839.4A84B11164@narn.netbsd.org>
Date: Fri,  9 Apr 2004 07:18:39 +0000 (UTC)
From: anthony_wyatt@hotmail.com
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: anthony_wyatt@hotmail.com
To: gnats-bugs@gnats.NetBSD.org
Subject: i386 kernel dev/pci/if_sip update request
X-Send-Pr-Version: www-1.0

>Number:         25110
>Category:       kern
>Synopsis:       i386 kernel dev/pci/if_sip update request
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 09 07:19:00 +0000 2004
>Closed-Date:    
>Last-Modified:  Mon Nov 01 00:01:12 +0000 2010
>Originator:     Anthony Wyatt
>Release:        2.0 Beta
>Organization:
Ouroboros Pty Ltd
>Environment:
NetBSD name.here 2.0_BETA NetBSD 2.0_BETA (GENERIC) #0: Thu Apr  8 14:54:02 EST 2004  root@netdev:/usr/obj/sys/arch/i386/compile/G
ENERIC i386
>Description:
This is a follow up to report #13770 which details a user with the same problem as I have, and his solution.

In summary:

sending a large email with several attachments causes:
/netbsd sip0: transmit FIFO underrun.

I modified my dev/pci/if_sip.c as recommended by PR#13770 to:
sc->sc_tx_fill_thresh = 256/32; /* was 32/32 !!! this is the source of the problem */

And the problem was rectified.

Can this fix to commited to the 2.0 release kernel?

Thanks.
>How-To-Repeat:
I have the email in my inbox, all I have to do is send it and I get the sip0: transmit FIFO underruns.
>Fix:
Patch if_sip.c:

sc->sc_tx_fill_thresh = 256/32; /* was 32/32 !!! this is the source of the problem */

>Release-Note:
>Audit-Trail:

From: Quentin Garnier <cube@NetBSD.org>
To: anthony_wyatt@hotmail.com
Cc: gnats-bugs@gnats.NetBSD.org
Subject: Re: kern/25110
Date: Fri, 9 Apr 2004 10:32:42 +0200

 This is a multi-part message in MIME format.

 --Multipart=_Fri__9_Apr_2004_10_32_42_+0200_qq3k2cOD3INJOtc_
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit

 Hi,

 On Fri,  9 Apr 2004 07:18:39 +0000 (UTC)
 anthony_wyatt@hotmail.com wrote:

 [...]
 > >Description:
 > This is a follow up to report #13770 which details a user with the
 > same problem as I have, and his solution.
 > 
 > In summary:
 > 
 > sending a large email with several attachments causes:
 > /netbsd sip0: transmit FIFO underrun.
 > 
 > I modified my dev/pci/if_sip.c as recommended by PR#13770 to:
 > sc->sc_tx_fill_thresh = 256/32; /* was 32/32 !!! this is the source of
 > the problem */
 > 
 > And the problem was rectified.
 > 
 > Can this fix to commited to the 2.0 release kernel?
 > 
 > Thanks.
 > >How-To-Repeat:
 > I have the email in my inbox, all I have to do is send it and I get
 > the sip0: transmit FIFO underruns.
 > >Fix:
 > Patch if_sip.c:
 > 
 > sc->sc_tx_fill_thresh = 256/32; /* was 32/32 !!! this is the source of
 > the problem */

 Could you try the attached patch?

 Quentin Garnier.

 --Multipart=_Fri__9_Apr_2004_10_32_42_+0200_qq3k2cOD3INJOtc_
 Content-Type: text/plain;
  name="sip.diff"
 Content-Disposition: attachment;
  filename="sip.diff"
 Content-Transfer-Encoding: 7bit

 Index: if_sip.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/pci/if_sip.c,v
 retrieving revision 1.87
 diff -u -r1.87 if_sip.c
 --- if_sip.c	11 Jan 2004 09:07:56 -0000	1.87
 +++ if_sip.c	9 Apr 2004 08:31:23 -0000
 @@ -997,7 +997,10 @@
  	 * the Tx FIFO before the bus master can DMA more
  	 * data into the FIFO.
  	 */
 -	sc->sc_tx_fill_thresh = 64 / 32;
 +	if ((sc->sc_txcfg & TXCFG_MXDMA) == TXCFG_MXDMA_512)
 +		sc->sc_tx_fill_thresh = 512 / 32;
 +	else
 +		sc->sc_tx_fill_thresh = 64 / 32;

  	/*
  	 * Start at a drain threshold of 512 bytes.  We will

 --Multipart=_Fri__9_Apr_2004_10_32_42_+0200_qq3k2cOD3INJOtc_--
Responsible-Changed-From-To: kern-bug-people->cube 
Responsible-Changed-By: cube 
Responsible-Changed-When: Fri Apr 9 08:33:33 UTC 2004 
Responsible-Changed-Why:  
I handle it. 

From: Christian Biere <christianbiere@gmx.de>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: Re: kern/25110
Date: Wed, 28 Apr 2004 17:13:04 +0200

 FYI, I've tried the patch and haven't seen a single warning regarding sip0
 again yet for the last ~2 weeks. Before I had used a MTU of 1024 which
 "solved" the issue for me as well. With the patch applied it seems to work
 just fine with the normal MTU of 1500.

 --=20
 Christian

From: Christian Biere <christianbiere@gmx.de>
To: cube@cubidou.net
Cc: gnats-bugs@netbsd.org
Subject: Re: kern/25110
Date: Wed, 28 Apr 2004 17:51:11 +0200

 cube@cubidou.net wrote:
 > BTW, is it a DP831[56] you tried it upon, or a SiS900?

 The latter (on NetBSD 2.0E with your patch applied):
 sip0 at pci0 dev 3 function 0: SiS 900 10/100 Ethernet, rev 0x90
 sip0: interrupting at ioapic0 pin 22 (irq 10)
 sip0: Ethernet address 00:07:95:a9:a5:7f
 ukphy0 at sip0 phy 1: Generic IEEE 802.3u media interface
 ukphy0: OUI 0x000004, model 0x0020, rev. 1
 ukphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto

 --=20
 Christian
Responsible-Changed-From-To: cube->kern-bug-people
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Mon, 01 Nov 2010 00:01:12 +0000
Responsible-Changed-Why:
back to role account.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.