NetBSD Problem Report #25216

Received: (qmail 21023 invoked by uid 605); 18 Apr 2004 02:45:56 -0000
Message-Id: <20040418024555.45EFE11167@narn.netbsd.org>
Date: Sun, 18 Apr 2004 02:45:55 +0000 (UTC)
From: murray@river-styx.org
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: murray@river-styx.org
To: gnats-bugs@gnats.NetBSD.org
Subject: sys/resource.h posix compliance on getpriority/setpriority
X-Send-Pr-Version: www-1.0

>Number:         25216
>Category:       standards
>Synopsis:       sys/resource.h posix compliance on getpriority/setpriority
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    standards-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 18 02:46:00 +0000 2004
>Closed-Date:    Sun Apr 10 08:41:25 +0000 2011
>Last-Modified:  Sun Apr 10 08:41:25 +0000 2011
>Originator:     Murray Armfield
>Release:        NetBSD-current
>Organization:
>Environment:
NetBSD ra 2.0C NetBSD 2.0C (RA.MP) #0: Mon Apr 12 23:28:47 EST 2004  admin@ra:/usr/obj/sys/arch/i386/compile/RA.MP i386
>Description:
posix headers for resource.h use the type id_t, not int for one of the parameters to getpriority and setpriority.

Oh and while I'm here, NetBSD seems to be missing the resource limit
define RLIMIT_AS which is the address space size, also part of posix
standard in resource.h
>How-To-Repeat:
Inspect sys/resource.h and posix standard
>Fix:
 __BEGIN_DECLS
-int    getpriority __P((int, int));
+int    getpriority __P((int, id_t));
 int    getrlimit __P((int, struct rlimit *));
 int    getrusage __P((int, struct rusage *));
-int    setpriority __P((int, int, int));
+int    setpriority __P((int, id_t, int));
 int    setrlimit __P((int, const struct rlimit *));
 __END_DECLS

Additional patching required for source tree. This is just the resource.h bit of it
>Release-Note:
>Audit-Trail:


From: Klaus Klein <kleink@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/25216 CVS commit: src
Date: Sun, 25 Apr 2004 22:18:08 +0000 (UTC)

 Module Name:	src
 Committed By:	kleink
 Date:		Sun Apr 25 22:18:08 UTC 2004

 Modified Files:
 	src/lib/libc/sys: getpriority.2
 	src/sys/kern: kern_resource.c syscalls.master
 	src/sys/sys: resource.h

 Log Message:
 POSIX-2001: Change the `who' argument to [gs]etpriority(2) from int
 to id_t.  Partially addressing PR standards/25216 from Murray Armfield.


 To generate a diff of this commit:
 cvs rdiff -r1.15 -r1.16 src/lib/libc/sys/getpriority.2
 cvs rdiff -r1.80 -r1.81 src/sys/kern/kern_resource.c
 cvs rdiff -r1.139 -r1.140 src/sys/kern/syscalls.master
 cvs rdiff -r1.23 -r1.24 src/sys/sys/resource.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


From: Klaus Klein <kleink@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/25216 CVS commit: src/sys
Date: Sun, 25 Apr 2004 22:21:17 +0000 (UTC)

 Module Name:	src
 Committed By:	kleink
 Date:		Sun Apr 25 22:21:17 UTC 2004

 Modified Files:
 	src/sys/kern: init_sysent.c syscalls.c
 	src/sys/sys: syscall.h syscallargs.h

 Log Message:
 Regen from rev. 1.140:
 POSIX-2001: Change the `who' argument to [gs]etpriority(2) from int
 to id_t.  Partially addressing PR standards/25216 from Murray Armfield.


 To generate a diff of this commit:
 cvs rdiff -r1.156 -r1.157 src/sys/kern/init_sysent.c
 cvs rdiff -r1.151 -r1.152 src/sys/kern/syscalls.c
 cvs rdiff -r1.149 -r1.150 src/sys/sys/syscall.h
 cvs rdiff -r1.131 -r1.132 src/sys/sys/syscallargs.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->suspended 
State-Changed-By: kleink 
State-Changed-When: Thu May 20 18:58:12 UTC 2004 
State-Changed-Why:  
I'm suspending this for now; Matt Thomas is apparently working on this. 
State-Changed-From-To: suspended->closed
State-Changed-By: jruoho@NetBSD.org
State-Changed-When: Sun, 10 Apr 2011 08:41:25 +0000
State-Changed-Why:

Should be fixed.



>Unformatted:

Home	PR Database Search