NetBSD Problem Report #25641

Received: (qmail 19151 invoked by uid 605); 19 May 2004 13:53:36 -0000
Message-Id: <1084974812.877879.553.nullmailer@yamt.dyndns.org>
Date: Wed, 19 May 2004 22:53:32 +0900
From: yamt@mwd.biglobe.ne.jp
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: yamt@mwd.biglobe.ne.jp
To: gnats-bugs@gnats.netbsd.org
Subject: nfs uses time(9) where it should use mono_time(9)
X-Send-Pr-Version: 3.95

>Number:         25641
>Category:       kern
>Synopsis:       nfs uses time(9) where it should use mono_time(9)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed May 19 13:54:00 +0000 2004
>Closed-Date:    
>Last-Modified:  Tue Aug 06 20:15:01 +0000 2019
>Originator:     YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
>Release:        NetBSD 2.0E
>Organization:

>Environment:


System: NetBSD kaeru 2.0E NetBSD 2.0E (build.kaeru) #1310: Wed May 19 21:29:48 JST 2004 takashi@kaeru:/usr/home/takashi/work/kernel/build.kaeru i386
Architecture: i386
Machine: i386
>Description:
	nfs uses time(9) where it should use mono_time(9).
	eg. n_attrstamp, nu_timestamp.
>How-To-Repeat:

>Fix:
	use mono_time(9).

>Release-Note:
>Audit-Trail:
From: YAMAMOTO Takashi <yamt@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/25641 CVS commit: src/sys/nfs
Date: Fri, 21 Jan 2005 14:31:29 +0000 (UTC)

 Module Name:	src
 Committed By:	yamt
 Date:		Fri Jan 21 14:31:29 UTC 2005

 Modified Files:
 	src/sys/nfs: nfs_subs.c nfs_vnops.c

 Log Message:
 s/time/mono_time/ for n_attrstamp and n_accstamp.  (parts of) PR/25641.


 To generate a diff of this commit:
 cvs rdiff -r1.141 -r1.142 src/sys/nfs/nfs_subs.c
 cvs rdiff -r1.216 -r1.217 src/sys/nfs/nfs_vnops.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Mon, 05 Aug 2019 22:30:41 +0000
State-Changed-Why:
A cursory code inspection shows that it uses microtime(9) now, which is stated to be monotonic.
(So, fixed by you, and possibly other people who handled the missing cases)


State-Changed-From-To: closed->open
State-Changed-By: maya@NetBSD.org
State-Changed-When: Mon, 05 Aug 2019 22:36:26 +0000
State-Changed-Why:
I might be confused, do you want the time since boot or a more monotonic time?


From: Jason Thorpe <thorpej@me.com>
To: gnats-bugs@netbsd.org
Cc: kern-bug-people@netbsd.org,
 netbsd-bugs@netbsd.org,
 gnats-admin@netbsd.org,
 "maya@netbsd.org" <maya@NetBSD.org>,
 yamt@mwd.biglobe.ne.jp
Subject: Re: kern/25641 (nfs uses time(9) where it should use mono_time(9))
Date: Mon, 5 Aug 2019 15:57:57 -0700

 > On Aug 5, 2019, at 3:36 PM, maya@netbsd.org <maya@NetBSD.org> wrote:
 >=20
 > Synopsis: nfs uses time(9) where it should use mono_time(9)
 >=20
 > State-Changed-From-To: closed->open
 > State-Changed-By: maya@NetBSD.org
 > State-Changed-When: Mon, 05 Aug 2019 22:36:26 +0000
 > State-Changed-Why:
 > I might be confused, do you want the time since boot or a more =
 monotonic time?

 These are time stamps needed to deal with attribute cache timeouts and =
 other things that need to be measured in time-actually-passed, not time =
 relative to what the time-of-day is set to.

 -- thorpej

From: Frank Kardel <kardel@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/25641 (nfs uses time(9) where it should use mono_time(9))
Date: Tue, 6 Aug 2019 22:13:37 +0200

 Consider to use microuptime() or getmicrouptime() for determining 
 elapsed time spans in the kernel.
 getmicropuptime() is updated once per clock tick and is faster than 
 microuptime() which queries the time counter.
 The Xuptime() functions return the elapsed time since boot and are thus 
 monotonic.

>Unformatted:

Home	PR Database Search