NetBSD Problem Report #26214

Received: (qmail 29035 invoked by uid 605); 9 Jul 2004 09:42:19 -0000
Message-Id: <200407090942.i699g8N2008158@frohike.nvie.com>
Date: Fri, 09 Jul 2004 11:42:08 +0200 (CEST)
From: Peter.Bex@student.kun.nl
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: Peter.Bex@student.kun.nl
To: gnats-bugs@gnats.NetBSD.org
Subject: mount(8) does not mention NFS options
X-Send-Pr-Version: 3.95

>Number:         26214
>Category:       bin
>Synopsis:       mount(8) does not mention NFS options
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          analyzed
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jul 09 09:43:01 +0000 2004
>Closed-Date:    
>Last-Modified:  Sat Jun 16 15:35:01 +0000 2012
>Originator:     
>Release:        NetBSD 2.0_BETA
>Organization:

>Environment:


System: NetBSD frohike.nvie.com 2.0_BETA NetBSD 2.0_BETA (FROHIKE) #1: Tue Jul 6 14:42:10 CEST 2004 sjamaan@frohike.nvie.com:/usr/src/sys/arch/i386/compile/FROHIKE i386
Architecture: i386
Machine: i386
>Description:
The mount_nfs(8) manpage refers to mount(8) for possible options which can
follow -o.  These are the same which can be put in fstab.
mount(8) fails to mention "tcp" and a host of other options which can be
found in src/sbin/mount_nfs/mount_nfs.c
>How-To-Repeat:
N/A
>Fix:
Document what these options do:
bg
conn
dumbtimer
intr
kerb
nfsv3
rdirplus
mntudp
noresport
seqpacket
nqnfs
soft
tcp
nfsv2
port
rsize
wsize
rdirsize
maxgrps
leaseterm
readahead
deadthresh
timeo
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->analyzed
State-Changed-By: hubertf@netbsd.org
State-Changed-When: Mon, 27 Nov 2006 00:49:17 +0000
State-Changed-Why:
A patch was proposed during the 20061126/27 hackathon,
see http://rafb.net/paste/results/Ge0Mzr38.html:

Index: mount.8
===================================================================
RCS file: /cvsroot/src/sbin/mount/mount.8,v
retrieving revision 1.56
diff -u -r1.56 mount.8
--- mount.8     31 Oct 2006 08:12:46 -0000      1.56
+++ mount.8     26 Nov 2006 19:39:35 -0000
@@ -202,8 +202,6 @@
 binaries for architectures other than its own.
 .It Cm nosuid
 Do not allow set-user-identifier or set-group-identifier bits to take effect.
-.It Cm port
-(NFS only) Use the specified NFS port.
 .It Cm rdonly
 The same as
 .Fl r ;
Index: mount_nfs.8
===================================================================
RCS file: /cvsroot/src/sbin/mount_nfs/mount_nfs.8,v
retrieving revision 1.31
diff -u -r1.31 mount_nfs.8
--- mount_nfs.8 9 Nov 2006 10:07:00 -0000       1.31
+++ mount_nfs.8 26 Nov 2006 19:39:39 -0000
@@ -55,9 +55,9 @@
 .Bk -words
 .Op Fl a Ar maxreadahead
 .Ek
-.Bk -words
-.Op Fl g Ar maxgroups
-.Ek
+.\".Bk -words
+.\".Op Fl g Ar maxgroups
+.\".Ek
 .Bk -words
 .Op Fl o Ar options
 .Ek
@@ -198,13 +198,13 @@
 mounts that exhibit high retry rates,
 since it is possible that the dynamically estimated timeout interval is too
 short.
-.It Fl g
-Set the maximum size of the group list for the credentials to the
-specified value.
-This should be used for mounts on old servers that cannot handle a
-group list size of 16, as specified in RFC 1057.
-Try 8, if users in a lot of groups cannot get response from the mount
-point.
+.\".It Fl g
+.\"Set the maximum size of the group list for the credentials to the
+.\"specified value.
+.\"This should be used for mounts on old servers that cannot handle a
+.\"group list size of 16, as specified in RFC 1057.
+.\"Try 8, if users in a lot of groups cannot get response from the mount
+.\"point.
 .It Fl i
 Make the mount interruptible, which implies that file system calls that
 are delayed due to an unresponsive server will fail with
@@ -232,7 +232,90 @@
 flag followed by a comma separated string of options.
 See the
 .Xr mount 8
-man page for possible options and their meanings.
+man page for general mount options.
+Options specific to NFS are:
+.Bl -tag -width deadthresh
+.It Cm bg
+See
+.Fl b
+option.
+.It Cm conn
+See
+.Fl C
+option.
+.It Cm dumbtimer
+See
+.Fl d
+option.
+.It Cm intr
+See
+.Fl i
+option.
+.\".It Cm maxgrps
+.\"See
+.\".Fl g
+.\"option.
+.It Cm mntudp
+See
+.Fl U
+option.
+.It Cm nfsv2
+See
+.Fl 2
+option.
+.It Cm nfsv3
+See
+.Fl 3
+option.
+.It Cm noresport
+See
+.Fl p
+option.
+.It Cm nqnfs
+See
+.Fl q
+option.
+.It Cm port
+Use the specified NFS port.
+.It Cm readahead
+See
+.Fl a
+option.
+.It Cm rdirplus
+See
+.Fl l
+option.
+.It Cm rdirsize
+See
+.Fl I
+option.
+.It Cm retrans
+See
+.Fl x
+option.
+.It Cm rsize
+See
+.Fl r
+option.
+.It Cm seqpacket
+Use SOCK_SEQPACKET type sockets. (Only supported for the ISO protocol.)
+.It Cm soft
+See
+.Fl s
+option.
+.It Cm timeo
+See
+.Fl t
+option.
+.It Cm tcp
+See
+.Fl T
+option.
+.It Cm wsize
+See
+.Fl w
+option.
+.El
 .It Fl p
 Do not use a reserved port number for RPCs.
 This option is provided only to be able to mimic the old
Index: mount_nfs.c
===================================================================
RCS file: /cvsroot/src/sbin/mount_nfs/mount_nfs.c,v
retrieving revision 1.53
diff -u -r1.53 mount_nfs.c
--- mount_nfs.c 9 Nov 2006 10:07:00 -0000       1.53
+++ mount_nfs.c 26 Nov 2006 19:39:43 -0000
@@ -329,9 +329,7 @@
                        }
 #endif
                        if (altflags & ALTF_LEASETERM) {
-                               nfsargsp->leaseterm =
-                               (int)getmntoptnum(mp, "leaseterm");
-                               nfsargsp->flags |= NFSMNT_LEASETERM;
+                               /* ignored */
                        }
                        if (altflags & ALTF_READAHEAD) {
                                nfsargsp->readahead =
@@ -339,9 +337,7 @@
                                nfsargsp->flags |= NFSMNT_READAHEAD;
                        }
                        if (altflags & ALTF_DEADTHRESH) {
-                               nfsargsp->deadthresh = 
-                                   (int)getmntoptnum(mp, "deadthresh");
-                               nfsargsp->flags |= NFSMNT_DEADTHRESH;
+                               /* ignored */
                        }
                        if (altflags & ALTF_TIMEO) {
                                nfsargsp->timeo = 
@@ -537,9 +533,8 @@
 static void
 usage(void)
 {
-       (void)fprintf(stderr, "usage: mount_nfs %s\n%s\n%s\n%s\n%s\n",
-"[-23bcCdilpPqsTUX] [-a maxreadahead] [-D deadthresh]",
-"\t[-g maxgroups] [-I readdirsize] [-L leaseterm]",
+       (void)fprintf(stderr, "usage: mount_nfs %s\n%s\n%s\n%s\n",
+"[-23bcCdilpPqsTUX] [-a maxreadahead] [-I readdirsize]",
 "\t[-o options] [-R retrycnt] [-r readsize] [-t timeout]",
 "\t[-w writesize] [-x retrans]",
 "\trhost:path node");







From: Bernd Ernesti <veego@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: hubertf@NetBSD.org, Peter.Bex@student.kun.nl
Subject: Re: bin/26214 (mount(8) does not mention NFS options)
Date: Tue, 28 Nov 2006 20:24:34 +0100

 On Mon, Nov 27, 2006 at 12:49:18AM +0000, hubertf@NetBSD.org wrote:
 [..]
 > A patch was proposed during the 20061126/27 hackathon,
 > see http://rafb.net/paste/results/Ge0Mzr38.html:

 The url doesn't work.

 [..]
 > Index: mount_nfs.c
 > ===================================================================
 > RCS file: /cvsroot/src/sbin/mount_nfs/mount_nfs.c,v
 > retrieving revision 1.53
 > diff -u -r1.53 mount_nfs.c
 > --- mount_nfs.c 9 Nov 2006 10:07:00 -0000       1.53
 > +++ mount_nfs.c 26 Nov 2006 19:39:43 -0000
 [..]

 Is that a reversed diff or why are these options removed?

 Wasn't the pr about missing documentation and not about removing
 something?

 Bernd

From: dieter roelants <dieter.r@pandora.be>
To: gnats-bugs@NetBSD.org
Cc: Bernd Ernesti <veego@NetBSD.org>
Subject: Re: bin/26214 (mount(8) does not mention NFS options)
Date: Tue, 28 Nov 2006 23:00:37 +0100

 On Tue, 28 Nov 2006 19:25:03 +0000 (UTC)
 Bernd Ernesti <veego@NetBSD.org> wrote:

 >  > see http://rafb.net/paste/results/Ge0Mzr38.html:
 >  
 >  The url doesn't work.

 It expired (after 24h I think).

 >  > diff -u -r1.53 mount_nfs.c
 >  > --- mount_nfs.c 9 Nov 2006 10:07:00 -0000       1.53
 >  > +++ mount_nfs.c 26 Nov 2006 19:39:43 -0000
 >  [..]
 >  
 >  Is that a reversed diff or why are these options removed?
 >  
 >  Wasn't the pr about missing documentation and not about removing
 >  something?

 I thought it was better to document all nfs-related options in the
 mount_nfs man page instead of in the mount man page, so I moved the one
 option that was explained in mount.8 to mount_nfs.8. I should probably
 have replied to gnats to make that clear. In case you or anybody else
 wonders about other changes in the patch; it
 - explains all other -o options for mount_nfs, mostly by referring to
   single-letter options (maybe the wording could be better)
 - comments out the maxgroups option from the man page because it's #if
   0'd in the code
 - adapts the usage and -o options to a recent change yamt@ made
   (removal of -D and -L)

 Kind regards
 dieter

 >  
 >  Bernd
 >  
 > 

From: David Holland <dholland@eecs.harvard.edu>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: bin/26214: mount(8) does not mention NFS options
Date: Tue, 22 Jan 2008 17:02:39 -0500

 Most of the options are now documented, but the following points
 remain to be addressed:

 1. The mount option retrans=foo (same as -x foo) is not documented;
 2. The -g command-line option is #if 0'd in the source and should be
 either removed from the docs or (perhaps better) documented as not
 working;
 3. The nfs-specific mount option port should in fact be removed from
 mount.8; the latter should also explicitly crossreference the
 existence of many nfs-specific mount options.

 I will probably attend to these eventually but it may take a while.

 -- 
    - David A. Holland / dholland@eecs.harvard.edu

From: Sachidananda Urs <sac.urs@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/26214 (mount(8) does not mention NFS options)
Date: Sat, 16 Jun 2012 21:00:07 +0530

 --Apple-Mail=_0A3FE020-E77B-4C85-96C6-443C7FE9FADD
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=us-ascii

 Added fix suggested by dholland@

 * documented retrans=3Dfoo
 * documented -g does not work (-g is #if 0'd decades ago between 1.1.1.1 =
 and 1.2 version of mount_nfs)
 * nfs-specific mount option `port' removed from mount.8 it is documented =
 in mount_nfs.8

 -sac


 --Apple-Mail=_0A3FE020-E77B-4C85-96C6-443C7FE9FADD
 Content-Disposition: attachment;
 	filename=mount_nfs.8.patch
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="mount_nfs.8.patch"
 Content-Transfer-Encoding: 7bit

 Index: mount_nfs.8
 ===================================================================
 RCS file: /cvsroot/src/sbin/mount_nfs/mount_nfs.8,v
 retrieving revision 1.42
 diff -u -u -r1.42 mount_nfs.8
 --- mount_nfs.8	8 Apr 2012 22:00:37 -0000	1.42
 +++ mount_nfs.8	16 Jun 2012 15:27:02 -0000
 @@ -139,6 +139,8 @@
  group list size of 16, as specified in RFC 1057.
  Try 8, if users in a lot of groups cannot get response from the mount
  point.
 +
 +Currently this option is disabled.
  .It Fl I Ar readdirsize
  Set the readdir read size to the specified value.
  The value should normally
 @@ -247,6 +249,9 @@
  .It Cm wsize Ns = Ns Aq Ar writesize
  Same as
  .Fl w Ar writesize .
 +.It Cm retrans Ns = Ns Aq Ar retrans
 +Same as
 +.Fl x Ar retrans .
  .El
  .It Fl P
  Use a reserved socket port number.

 --Apple-Mail=_0A3FE020-E77B-4C85-96C6-443C7FE9FADD
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii




 --Apple-Mail=_0A3FE020-E77B-4C85-96C6-443C7FE9FADD
 Content-Disposition: attachment;
 	filename=mount.8.patch
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="mount.8.patch"
 Content-Transfer-Encoding: 7bit

 Index: mount.8
 ===================================================================
 RCS file: /cvsroot/src/sbin/mount/mount.8,v
 retrieving revision 1.74
 diff -u -u -r1.74 mount.8
 --- mount.8	22 Jul 2011 15:53:21 -0000	1.74
 +++ mount.8	16 Jun 2012 15:25:44 -0000
 @@ -240,8 +240,6 @@
  binaries for architectures other than its own.
  .It Cm nosuid
  Do not allow set-user-identifier or set-group-identifier bits to take effect.
 -.It Cm port
 -(NFS only) Use the specified NFS port.
  .It Cm rdonly
  The same as
  .Fl r ;

 --Apple-Mail=_0A3FE020-E77B-4C85-96C6-443C7FE9FADD--

>Unformatted:

Home	PR Database Search