NetBSD Problem Report #28609

From www@netbsd.org  Sat Dec 11 18:03:05 2004
Return-Path: <www@netbsd.org>
Received: by narn.netbsd.org (Postfix, from userid 31301)
	id 48409251F87; Sat, 11 Dec 2004 18:03:05 +0000 (UTC)
Message-Id: <20041211180305.48409251F87@narn.netbsd.org>
Date: Sat, 11 Dec 2004 18:03:05 +0000 (UTC)
From: georg.schwarz@freenet.de
Reply-To: georg.schwarz@freenet.de
To: gnats-bugs@netbsd.org
Subject: mail/distribute assumes existence of _PATH_SENDMAIL, strsep(), install
X-Send-Pr-Version: www-1.0

>Number:         28609
>Category:       pkg
>Synopsis:       mail/distribute assumes existence of _PATH_SENDMAIL, strsep(), install
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Dec 11 18:06:00 +0000 2004
>Closed-Date:    Mon May 23 03:55:42 +0000 2022
>Last-Modified:  Mon May 23 03:55:42 +0000 2022
>Originator:     Georg Schwarz
>Release:        current pkgsrc
>Organization:
>Environment:
IRIX lorenz 5.3 08031225 IP20 mips
>Description:
- mail/distribute's setup assumes strsep() exists on the respective system.
- patch-ab assumes _PATH_SENDMAIL is defined.
- Makefile assumes that install is BSD-compatible.
>How-To-Repeat:

>Fix:
- the following patch to Makefile works for IRIX 5 (maybe other OSes also need it), but admittingly the use of DEFAULTCONFIG here is somewhat a hack; maybe passing CFLAGS would be nicer.

--- Makefile.orig       2004-12-11 18:06:37.000000000 +0100
+++ Makefile    2004-12-11 18:18:18.000000000 +0100
@@ -40,6 +40,11 @@
                INSTALL="${INSTALL}" \
                INSTALL_MAN="${INSTALL_MAN}"

+.include "../../mk/bsd.prefs.mk"
+.if !empty(LOWER_OPSYS:Mirix5*)
+MAKE_FLAGS+=   "DEFAULTCONFIG=-DSTRSEP_MISSING"
+.endif
+
 pre-build:
        ${TOUCH} ${WRKSRC}/logging.h ${WRKSRC}/strsep.c

moreover, it is necessary to patch strutil.c to add #include <string.h> in order for strlen() to be known.

- remove patch-ab (why is it there?)
- comment out the INSTALL= line in Makefile.
Maybe in addition it is necessary to change INSTALL="${INSTALL}" into INSTALL="${INSTALL} -c" in the toplevel Makefile.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->itojun
Responsible-Changed-By: recht@netbsd.org
Responsible-Changed-When: Sun, 12 Dec 2004 17:51:52 +0000
Responsible-Changed-Why:
over to maintainer


Responsible-Changed-From-To: itojun->pkg-manager
Responsible-Changed-By: wiz@netbsd.org
Responsible-Changed-When: Sat, 17 Nov 2007 13:36:05 +0000
Responsible-Changed-Why:
Back to role account.


From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/28609 mail/distribute assumes existence of _PATH_SENDMAIL,
 strsep(),
Date: Mon, 23 May 2022 03:41:28 +0000

 On Sat Dec 11 18:06:00 +0000 2004 Georg Schwarz wrote:
  > >Description:
  > - mail/distribute's setup assumes strsep() exists on the respective system.
  > - patch-ab assumes _PATH_SENDMAIL is defined.
  > - Makefile assumes that install is BSD-compatible.

 The install part was fixed in 2010. I'm removing patch-ab (no idea why
 it's there either) and adding a (somewhat different) hook for strsep.

 -- 
 David A. Holland
 dholland@netbsd.org

From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/28609 CVS commit: pkgsrc/mail/distribute
Date: Mon, 23 May 2022 03:45:35 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Mon May 23 03:45:35 UTC 2022

 Modified Files:
 	pkgsrc/mail/distribute: Makefile distinfo
 	pkgsrc/mail/distribute/patches: patch-aa
 Removed Files:
 	pkgsrc/mail/distribute/patches: patch-ab

 Log Message:
 PR 28609 Georg Schwarz mail/distribute doesn't build on Irix

  - Set STRSEP_MISSING on Irix.
  - Remove patch-ab, which #if'd out a fallback definition for
    _PATH_SENDMAIL; that's completely pointless.


 To generate a diff of this commit:
 cvs rdiff -u -r1.38 -r1.39 pkgsrc/mail/distribute/Makefile
 cvs rdiff -u -r1.13 -r1.14 pkgsrc/mail/distribute/distinfo
 cvs rdiff -u -r1.4 -r1.5 pkgsrc/mail/distribute/patches/patch-aa
 cvs rdiff -u -r1.3 -r0 pkgsrc/mail/distribute/patches/patch-ab

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 23 May 2022 03:55:42 +0000
State-Changed-Why:
Should be fixed. If you're there and it doesn't actually work, let me know.


>Unformatted:

Home	PR Database Search