NetBSD Problem Report #30747

From www@netbsd.org  Thu Jul 14 14:06:41 2005
Return-Path: <www@netbsd.org>
Received: by narn.netbsd.org (Postfix, from userid 31301)
	id 0B46463B11A; Thu, 14 Jul 2005 14:06:41 +0000 (UTC)
Message-Id: <20050714140641.0B46463B11A@narn.netbsd.org>
Date: Thu, 14 Jul 2005 14:06:41 +0000 (UTC)
From: williams@umich.edu
Reply-To: williams@umich.edu
To: gnats-bugs@netbsd.org
Subject: libedit is missing remove_history()
X-Send-Pr-Version: www-1.0

>Number:         30747
>Category:       lib
>Synopsis:       libedit is missing remove_history()
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 14 14:07:00 +0000 2005
>Closed-Date:    Wed Jun 20 01:10:37 +0000 2018
>Last-Modified:  Wed Jun 20 01:10:37 +0000 2018
>Originator:     David N. Williams
>Release:        Darwin 8.2
>Organization:
University of Michigan
>Environment:
Darwin pm476-24.dialip.mich.net 8.1.0 Darwin Kernel Version 8.1.0: Tue May 10 18:16:08 PDT 2005; root:xnu-792.1.5.obj~4/RELEASE_PPC Power Macintosh powerpc

>Description:
I have made the equivalent of this request to Apple, but
apparently the NetBSD libedit library is the primary source.

Could you please add the equivalent of the function
remove_history() to libedit, with a prototype in readline.h or
history.h as appropriate?  The function add_history() is already
present, so it seems logical to implement remove_history() as
well.  Both are present in recent versions of GNU readline.

Inspection of the GNU source for the readline library shows
remove_history() to be pretty simple, maybe simple enough that
its expression is inevitable, so maybe nothing special has to be
done to avoid contamination by the GPL.  But I am not a lawyer.

The immediate occasion for this request is an attempt to build
the very nice open source plotting package asymptote-0.82 in Mac
OS X (Tiger).  It uses remove_history(), and builds fine when
the reference to it is removed, at the expense of a little
crippling of functionality.

Thanks,
David N. Williams

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: Christos Zoulas <christos@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/30747 CVS commit: src/lib/libedit
Date: Thu, 14 Jul 2005 15:00:58 +0000 (UTC)

 Module Name:	src
 Committed By:	christos
 Date:		Thu Jul 14 15:00:58 UTC 2005

 Modified Files:
 	src/lib/libedit: editline.3 histedit.h history.c readline.c
 	src/lib/libedit/readline: readline.h

 Log Message:
 PR/30747: David N. Williams: libedit is missing remove_history()
 Added, please test.


 To generate a diff of this commit:
 cvs rdiff -r1.46 -r1.47 src/lib/libedit/editline.3
 cvs rdiff -r1.27 -r1.28 src/lib/libedit/histedit.h
 cvs rdiff -r1.29 -r1.30 src/lib/libedit/history.c
 cvs rdiff -r1.57 -r1.58 src/lib/libedit/readline.c
 cvs rdiff -r1.16 -r1.17 src/lib/libedit/readline/readline.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: maya@NetBSD.org
State-Changed-When: Sun, 03 Jun 2018 21:47:09 +0000
State-Changed-Why:
Does the new function added 13 years ago work well now? :-)


State-Changed-From-To: feedback->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Wed, 20 Jun 2018 01:10:37 +0000
State-Changed-Why:
It's funny to put something in feedback after 13 years, but it's probably fine. Thanks for the bug report!


>Unformatted:

Home	PR Database Search