NetBSD Problem Report #31996

From damon@brodiefamily.org  Thu Nov  3 23:04:42 2005
Return-Path: <damon@brodiefamily.org>
Received: from nomad.brodiefamily.org (nomad.brodiefamily.org [66.11.174.209])
	by narn.netbsd.org (Postfix) with ESMTP id EAFB363B99E
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  3 Nov 2005 23:04:41 +0000 (UTC)
Message-Id: <20051103230506.C175E5DCE@nomad.brodiefamily.org>
Date: Thu,  3 Nov 2005 18:05:06 -0500 (EST)
From: damon@brodiefamily.org
Reply-To: damon@brodiefamily.org
To: gnats-bugs@netbsd.org
Subject: fix the comments for MPBIOS and MPACPI
X-Send-Pr-Version: 3.95

>Number:         31996
>Category:       port-amd64
>Synopsis:       fix the comments for MPBIOS and MPACPI
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-amd64-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 03 23:05:02 +0000 2005
>Closed-Date:    Thu Nov 03 23:27:37 +0000 2005
>Last-Modified:  Sat Dec 03 17:13:44 +0000 2005
>Originator:     Damon Brodie
>Release:        NetBSD 3.99.11
>Organization:

>Environment:


System: NetBSD nomad.brodiefamily.org 3.99.11 NetBSD 3.99.11 (NOMAD) #31: Thu Nov 3 17:37:48 EST 2005 damon@nomad.brodiefamily.org:/usr/src-current/sys/arch/amd64/compile/obj/NOMAD amd64
Architecture: x86_64
Machine: amd64
>Description:
	The GENERIC kernel for amd64 has a wrong comment for MPACPI_SCANPCI
>How-To-Repeat:
	grep MPACPI_SCANPCI GENERIC
	and look at the comment
>Fix:
	This diff brings MPBIOS* up beside MPACPI* (based on how GENERIC is in i386) and fixes the incorrect comment for MPACPI_SCANPCI.

--- GENERIC     2005-11-03 17:55:11.000000000 -0500
+++ GENERIC.new 2005-11-03 17:58:19.000000000 -0500
@@ -229,8 +229,11 @@
 mainbus0 at root

 #acpi0                 at mainbus0
-#options       MPACPI
-#options       MPACPI_SCANPCI          # MPBIOS configures PCI roots
+#options       MPACPI                  # configure CPUs and APICs using ACPI
+                                       # (acpi at mainbus must also be enabled)
+#options       MPACPI_SCANPCI          # find PCI roots using MPACPI
+options        MPBIOS                  # configure CPUs and APICs using MPBIOS
+options        MPBIOS_SCANPCI          # MPBIOS configures PCI roots
 #options       PCI_INTR_FIXUP          # PCI interrupt routing via ACPI
 #options       ACPI_ACTIVATE_DEV       # If set, activate inactive devices
 #options       ACPICA_PEDANTIC         # force strict conformance to the Spec.
@@ -255,8 +258,6 @@
 #pcppi*         at acpi?                # AT-style speaker sound
 #wss*          at acpi?                # NeoMagic 256AV in wss mode

-options        MPBIOS
-options        MPBIOS_SCANPCI          # MPBIOS configures PCI roots
 cpu*           at mainbus?
 ioapic*        at mainbus? apid ?


>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: rpaulo@netbsd.org
State-Changed-When: Thu, 03 Nov 2005 23:27:37 +0000
State-Changed-Why:
fixed, thanks


From: Rui Paulo <rpaulo@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/31996 CVS commit: src/sys/arch/amd64/conf
Date: Thu,  3 Nov 2005 23:12:16 +0000 (UTC)

 Module Name:	src
 Committed By:	rpaulo
 Date:		Thu Nov  3 23:12:16 UTC 2005

 Modified Files:
 	src/sys/arch/amd64/conf: GENERIC

 Log Message:
 PR 31996: fix the comments for MPBIOS and MPACPI. By Damon Brodie.


 To generate a diff of this commit:
 cvs rdiff -r1.71 -r1.72 src/sys/arch/amd64/conf/GENERIC

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search