NetBSD Problem Report #32295

From www@netbsd.org  Tue Dec 13 15:17:13 2005
Return-Path: <www@netbsd.org>
Received: by narn.netbsd.org (Postfix, from userid 31301)
	id 904F363B88D; Tue, 13 Dec 2005 15:17:13 +0000 (UTC)
Message-Id: <20051213151713.904F363B88D@narn.netbsd.org>
Date: Tue, 13 Dec 2005 15:17:13 +0000 (UTC)
From: jakerosoft@gmail.com
Reply-To: jakerosoft@gmail.com
To: gnats-bugs@netbsd.org
Subject: net/wmnet Solaris 10 / Sun Studio 11
X-Send-Pr-Version: www-1.0

>Number:         32295
>Category:       pkg
>Synopsis:       net/wmnet Solaris 10 / Sun Studio 11
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    solaris-pkg-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 13 15:20:01 +0000 2005
>Closed-Date:    Thu Jun 23 19:05:20 +0000 2016
>Last-Modified:  Thu Jun 23 19:05:20 +0000 2016
>Originator:     Jake Kupersmith
>Release:        pkgsrc
>Organization:
>Environment:
SunOS 5.10 Generic sun4u sparc SUNW,Sun-Blade-100
>Description:
alloca is defined in alloca.h on Solaris.  wmnet.c does not include this file and is causing a link error with Sun Studio 11.
>How-To-Repeat:
# bmake
...
LD_RUN_PATH=/usr/pkg/lib cc -o wmnet -O      -L/usr/pkg/lib wmnet.o drivers.o getopt.o getopt1.o -lXext -lX11 -lm -lkstat    -lsocket -lnsl  
Undefined                       first referenced
 symbol                             in file
alloca                              wmnet.o
ld: fatal: Symbol referencing errors. No output written to wmnet

>Fix:
wmnet.c gets patched in patch-ad.. I added the include to wmnet.c and created a new patch.  Here is a diff of my changes to wmnet.c after it gets patched by the original patch-ad.

# diff -u wmnet.c.orig.2 wmnet.c
--- wmnet.c.orig.2      Tue Dec 13 00:14:12 2005
+++ wmnet.c     Tue Dec 13 00:14:28 2005
@@ -59,6 +59,7 @@
 # include<sys/socket.h>
 # include"getopt.h"
 #elif defined (sun)
+# include<alloca.h>
 # include<sys/socket.h>
 # include<sys/sockio.h>
 # include "getopt.h"

>Release-Note:

>Audit-Trail:
From: "Jeremy C. Reed" <reed@reedmedia.net>
To: gnats-bugs@netbsd.org
Cc: jakerosoft@gmail.com
Subject: Re: pkg/32295: net/wmnet Solaris 10 / Sun Studio 11
Date: Tue, 13 Dec 2005 08:59:19 -0800 (PST)

 On Tue, 13 Dec 2005 jakerosoft@gmail.com wrote:

 > #elif defined (sun)
 > +# include<alloca.h>

 Jake,

 Thanks for these fixes.

 Please remember to submit (the non-pkgsrc-specific) fixes upstream to 
 official developers too.

 Thanks!

   Jeremy C. Reed

   	  	 	 technical support & remote administration
  	  	 	 http://www.pugetsoundtechnology.com/

Responsible-Changed-From-To: pkg-manager->solaris-pkg-people
Responsible-Changed-By: cube@netbsd.org
Responsible-Changed-When: Mon, 19 Dec 2005 11:29:54 +0000
Responsible-Changed-Why:
Solaris-specific issue.


From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/32295 CVS commit: pkgsrc/net/wmnet
Date: Thu, 23 Jun 2016 19:04:54 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Thu Jun 23 19:04:54 UTC 2016

 Modified Files:
 	pkgsrc/net/wmnet: distinfo
 	pkgsrc/net/wmnet/patches: patch-ad

 Log Message:
 PR 32295 Jake Kupersmith: missing alloca.h on Solaris.


 To generate a diff of this commit:
 cvs rdiff -u -r1.9 -r1.10 pkgsrc/net/wmnet/distinfo
 cvs rdiff -u -r1.5 -r1.6 pkgsrc/net/wmnet/patches/patch-ad

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Thu, 23 Jun 2016 19:05:20 +0000
State-Changed-Why:
committed, thanks


>Unformatted:

Home	PR Database Search