NetBSD Problem Report #32312

From www@netbsd.org  Fri Dec 16 00:12:35 2005
Return-Path: <www@netbsd.org>
Received: by narn.netbsd.org (Postfix, from userid 31301)
	id A1EE463B88D; Fri, 16 Dec 2005 00:12:35 +0000 (UTC)
Message-Id: <20051216001235.A1EE463B88D@narn.netbsd.org>
Date: Fri, 16 Dec 2005 00:12:35 +0000 (UTC)
From: zul@netbsd-fr.org
Reply-To: zul@netbsd-fr.org
To: gnats-bugs@netbsd.org
Subject: apm on hpcarm ( NetBSD-current ) doesn"t compile
X-Send-Pr-Version: www-1.0

>Number:         32312
>Category:       port-hpcarm
>Synopsis:       apm on hpcarm ( NetBSD-current ) doesn"t compile
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    port-hpcarm-maintainer
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Dec 16 00:15:00 +0000 2005
>Closed-Date:    Sat Jan 07 13:46:40 +0000 2006
>Last-Modified:  Sat Jan 07 13:46:40 +0000 2006
>Originator:     Arnaud Degroote
>Release:        Current
>Organization:
none
>Environment:
building machine
NetBSD Hermes.at.home 3.99.14 NetBSD 3.99.14 (HERMES) #0: Thu Dec 15 11:41:00 CET 2005  zul@Hermes.at.home:/usr/build_tmp/objdir/sys/arch/i386/compile/HERMES i386


hpcarm machine
NetBSD jornada.at.home 3.99.6 NetBSD 3.99.6 (MY_JORNADA720) #0: Wed Jun 22 23:08:15 CEST 2005  zul@Hermes.at.home:/usr/build_tmp/objdir/sys/arch/hpcarm/compile/MY_JORNADA720 hpcarm

>Description:
When I try to build a kernel current with apm enable for hpcarm, the compilation failed with the following error 
:/usr/src/sys/arch/hpcarm/dev/apm.c:100: error: conflicting types for `apmopen'
/usr/src/sys/arch/hpcarm/dev/apm.c:63: error: previous declaration of `apmopen'
/usr/src/sys/arch/hpcarm/dev/apm.c:107: error: conflicting types for `apmclose'
/usr/src/sys/arch/hpcarm/dev/apm.c:64: error: previous declaration of `apmclose'
/usr/src/sys/arch/hpcarm/dev/apm.c:114: error: conflicting types for `apmioctl'
/usr/src/sys/arch/hpcarm/dev/apm.c:65: error: previous declaration of `apmioctl'


I think it is due to the merge of ktrace-lwp but I don"t check the cvs log.
>How-To-Repeat:
cd /usr/src/sys/arch/hpcarm/conf
cp GENERIC GENERIC_APM
echo "apm0 at j720ssp?" >> GENERIC_APM
/usr/src/build.sh -m hpcarm kernel=GENERIC_APM
>Fix:
This little patch solve the issue 

--- /usr/src/sys/arch/hpcarm/dev/apm.c.orig     2005-12-16 00:54:51.000000000 +0                                                                                      
100
+++ /usr/src/sys/arch/hpcarm/dev/apm.c  2005-12-16 00:55:45.000000000 +0100
@@ -96,21 +96,21 @@
 }

 static int
-apmopen(dev_t dev, int flag, int mode, struct proc *p)
+apmopen(dev_t dev, int flag, int mode, struct lwp *p)
 {

        return 0;
 }

 static int
-apmclose(dev_t dev, int flag, int mode, struct proc *p)
+apmclose(dev_t dev, int flag, int mode, struct lwp *p)
 {

        return 0;
 }

 static int
-apmioctl(dev_t dev, u_long cmd, caddr_t data, int flag, struct proc *p)
+apmioctl(dev_t dev, u_long cmd, caddr_t data, int flag, struct lwp *p)
 {
        struct apm_softc *sc;


>Release-Note:

>Audit-Trail:
From: Christos Zoulas <christos@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/32312 CVS commit: src/sys/arch/hpcarm/dev
Date: Fri, 16 Dec 2005 04:02:14 +0000 (UTC)

 Module Name:	src
 Committed By:	christos
 Date:		Fri Dec 16 04:02:14 UTC 2005

 Modified Files:
 	src/sys/arch/hpcarm/dev: apm.c

 Log Message:
 PR/32312: Arnaud Degroote: apm on hpcarm ( NetBSD-current ) doesn"t compile


 To generate a diff of this commit:
 cvs rdiff -r1.8 -r1.9 src/sys/arch/hpcarm/dev/apm.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: peter@netbsd.org
State-Changed-When: Sat, 07 Jan 2006 13:46:40 +0000
State-Changed-Why:
fixed, thanks


>Unformatted:

Home	PR Database Search