NetBSD Problem Report #32850
From ggm@apnic.net Thu Feb 16 03:30:11 2006
Return-Path: <ggm@apnic.net>
Received: from apnic.net (cumin.apnic.net [202.12.29.59])
by narn.netbsd.org (Postfix) with ESMTP id 704B763B873
for <gnats-bugs@gnats.NetBSD.org>; Thu, 16 Feb 2006 03:30:06 +0000 (UTC)
Message-Id: <200602160327.k1G3Rgcn024935@garlic.apnic.net>
Date: Thu, 16 Feb 2006 13:27:42 +1000 (EST)
From: ggm@pobox.com
Reply-To: ggm@pobox.com
To: gnats-bugs@netbsd.org
Subject: xlockmore/Makefile.common needs option to disable vroot (tvtwm)
X-Send-Pr-Version: 3.95
>Number: 32850
>Category: pkg
>Synopsis: xlockmore needs option to disable vroot mode.
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: pkg-manager
>State: open
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Thu Feb 16 03:35:00 +0000 2006
>Last-Modified: Thu Feb 16 04:00:02 +0000 2006
>Originator: George Michaelson
>Release: NetBSD 3.99.15
>Organization:
George Michaelson | APNIC
Email: ggm@apnic.net | PO Box 2131 Milton
Phone: +61 7 3858 3150 | QLD 4064 Australia
Fax: +61 7 3858 3199 | http://www.apnic.net
>Environment:
System: NetBSD garlic.apnic.net 3.99.15 NetBSD 3.99.15 (GGMSMALL) #0: Thu Feb 9 14:35:52 EST 2006 ggm@garlic.apnic.net:/data/Build/obj/usr/src/sys/arch/i386/compile/GGMSMALL i386
Architecture: i386
Machine: i386
>Description:
tvtwm has a really broken vroot model. Although coders historically
have used a vroot.h to get around it, some applications (xv, and
xlockmore notably) just can't do it right.
xlockmore provides a configure option --disable-vroot which
'dtrt' when you use tvtwm.
>How-To-Repeat:
run tvtwm.
compile/install xlockmore
run with two heads. xlock doesn't blank screen, mouse
still moves, but until p/w is typed, kb is locked. no
prompt screen, no message. its a real denyal-of-service
threat!
>Fix:
This patch to Makefile.common should do it, at the cost
of a new option in mk.conf.
$ cvs diff Makefile.common
Index: Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/x11/xlockmore/Makefile.common,v
retrieving revision 1.41
diff -u -p -r1.41 Makefile.common
--- Makefile.common 12 Jan 2006 19:37:44 -0000 1.41
+++ Makefile.common 16 Feb 2006 03:24:14 -0000
@@ -76,6 +76,10 @@ CONFIGURE_ARGS+= --without-dpms
CONFIGURE_ARGS+= --disable-allow-root
.endif
+.if !empty(PKG_OPTIONS:Mxlockmore-disable-vroot)
+CONFIGURE_ARGS+= --disable-vroot
+.endif
+
.include "../../mk/x11.buildlink3.mk"
# Set the complete paths to the sound files and set the default xlock
$
>Audit-Trail:
From: George Michaelson <ggm@pobox.com>
To: gnats-bugs@netbsd.org
Cc: gnats-admin@netbsd.org
Subject: Re: pkg/32850: xlockmore/Makefile.common needs option to disable
vroot (tvtwm)
Date: Thu, 16 Feb 2006 13:58:15 +1000
better patch with the option added to the PKG_SUPPORTED_OPTIONS LIST
-George
Index: Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/x11/xlockmore/Makefile.common,v
retrieving revision 1.41
diff -u -p -r1.41 Makefile.common
--- Makefile.common 12 Jan 2006 19:37:44 -0000 1.41
+++ Makefile.common 16 Feb 2006 03:57:47 -0000
@@ -29,7 +29,7 @@ PKG_INSTALLATION_TYPES= overwrite pkgvie
.include "../../mk/bsd.prefs.mk"
PKG_OPTIONS_VAR= PKG_OPTIONS.xlockmore
-PKG_SUPPORTED_OPTIONS= xlockmore-allow-root xlockmore-dpms
+PKG_SUPPORTED_OPTIONS= xlockmore-allow-root xlockmore-dpms xlockmore-disable-vroot
.if ${OPSYS} == "NetBSD"
PKG_SUPPORTED_OPTIONS+= oss
.endif
@@ -76,6 +76,10 @@ CONFIGURE_ARGS+= --without-dpms
CONFIGURE_ARGS+= --disable-allow-root
.endif
+.if !empty(PKG_OPTIONS:Mxlockmore-disable-vroot)
+CONFIGURE_ARGS+= --disable-vroot
+.endif
+
.include "../../mk/x11.buildlink3.mk"
# Set the complete paths to the sound files and set the default xlock
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.