NetBSD Problem Report #33037

From www@netbsd.org  Thu Mar  9 11:05:43 2006
Return-Path: <www@netbsd.org>
Received: by narn.netbsd.org (Postfix, from userid 31301)
	id 29FEB63B89A; Thu,  9 Mar 2006 11:05:43 +0000 (UTC)
Message-Id: <20060309110543.29FEB63B89A@narn.netbsd.org>
Date: Thu,  9 Mar 2006 11:05:43 +0000 (UTC)
From: stuart@zeus.com
Reply-To: stuart@zeus.com
To: gnats-bugs@netbsd.org
Subject: nbcompat/err.h header file incomplete?
X-Send-Pr-Version: www-1.0

>Number:         33037
>Category:       pkg
>Synopsis:       nbcompat/err.h header file incomplete?
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Mar 09 11:10:00 +0000 2006
>Closed-Date:    Mon Dec 31 11:27:37 +0000 2018
>Last-Modified:  Sat Jan 12 08:00:00 +0000 2019
>Originator:     Stuart Shelton
>Release:        
>Organization:
>Environment:
>Description:

libnbcompat-20041024's err.h library seems, so far as I can tell, to be incomplete: It uses the __P macro and va_list without including the relevent headers.

I'm not a C expert, so I might have misunderstood how this header is supposed to be used ... but shouldn't the following change be applied:

 #if HAVE_ERR_H
 # include <err.h>
 #endif

+#ifndef _NBCOMPAT_SYS_CDEFS_H_
+# include <nbcompat/cdefs.h>
+#endif
+
+#ifndef __STDARG_H__
+# include <stdarg.h>
+#endif
+
 #if !HAVE_ERR
 void    err __P((int, const char *, ...));
 void    errx __P((int, const char *, ...));
 void    verr __P((int, const char *, va_list));

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->feedback
State-Changed-By: asau@NetBSD.org
State-Changed-When: Fri, 19 Feb 2010 10:56:23 +0000
State-Changed-Why:
The library was updated many times, does the problem persist?


State-Changed-From-To: feedback->open
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 01 Mar 2010 02:52:43 +0000
State-Changed-Why:
feedback mail bounceth; however, the problem does still remain.


State-Changed-From-To: open->feedback
State-Changed-By: triaxx@NetBSD.org
State-Changed-When: Fri, 28 Dec 2018 14:11:23 +0000
State-Changed-Why:
The suggested patch makes sense. Successful bootstrap on NetBSD and FreeBSD after applying. Close and commit after freeze if no objection.


State-Changed-From-To: feedback->closed
State-Changed-By: triaxx@NetBSD.org
State-Changed-When: Mon, 31 Dec 2018 11:27:37 +0000
State-Changed-Why:
Incorporated patch, thanks Stuart and sorry for the long time


From: =?UTF-8?B?RnLDqWTDqXJpYyBGYXViZXJ0ZWF1?= <triaxx@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/33037 CVS commit: pkgsrc/pkgtools/libnbcompat/files/nbcompat
Date: Mon, 31 Dec 2018 11:25:08 +0000

 Module Name:	pkgsrc
 Committed By:	triaxx
 Date:		Mon Dec 31 11:25:08 UTC 2018

 Modified Files:
 	pkgsrc/pkgtools/libnbcompat/files/nbcompat: err.h

 Log Message:
 libnbcompat: fix PR pkg/33037

 Thanks Stuart and sorry for the long time.


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 pkgsrc/pkgtools/libnbcompat/files/nbcompat/err.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/33037 CVS commit: pkgsrc/pkgtools/libnbcompat/files/nbcompat
Date: Sat, 12 Jan 2019 07:55:28 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Sat Jan 12 07:55:28 UTC 2019

 Modified Files:
 	pkgsrc/pkgtools/libnbcompat/files/nbcompat: termcap.h

 Log Message:
 termcap.h also requires the change from PR 33037.


 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r1.3 pkgsrc/pkgtools/libnbcompat/files/nbcompat/termcap.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search