NetBSD Problem Report #34591

From www@NetBSD.org  Sat Sep 23 04:33:27 2006
Return-Path: <www@NetBSD.org>
Received: by narn.NetBSD.org (Postfix, from userid 31301)
	id 380FF63B9FB; Sat, 23 Sep 2006 04:33:27 +0000 (UTC)
Message-Id: <20060923043327.380FF63B9FB@narn.NetBSD.org>
Date: Sat, 23 Sep 2006 04:33:27 +0000 (UTC)
From: dhgutteridge@sympatico.ca
Reply-To: dhgutteridge@sympatico.ca
To: gnats-bugs@NetBSD.org
Subject: Patch file that fixed DNS lookup problems in www/dillo was mistakenly removed in CVS
X-Send-Pr-Version: www-1.0

>Number:         34591
>Category:       pkg
>Synopsis:       Patch file that fixed DNS lookup problems in www/dillo was mistakenly removed in CVS
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    adam
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Sep 23 04:35:00 +0000 2006
>Closed-Date:    Thu Jun 18 06:55:25 +0000 2015
>Last-Modified:  Thu Jun 18 06:55:25 +0000 2015
>Originator:     David H. Gutteridge
>Release:        
>Organization:
>Environment:
>Description:
The patch file I submitted in PR31205 and committed by Tim Rightnour (garbled@) was removed in more recent changes to www/dillo.  I'm not sure why, presumably by accident.  It was needed to fix DNS query lockups in older versions of NetBSD that didn't have reentrant resolver functions.

In any case, dillo now provides an option in its configure script that allows the threaded DNS feature to be disabled, so here's my attempt at a new patch that takes advantage of this.  (I'm not able to test it, unfortunately, as everything I have is running > 3.0.  I did have a 1.6.2 box, but it had a hardware failure.)

(This isn't quite as precise with the NetBSD version as my old patch, but I would assume impacts to users running 2.99.x would be minimal.)


>How-To-Repeat:

>Fix:
--- Makefile~	2006-09-22 22:43:11.000000000 -0400
+++ Makefile	2006-09-23 00:17:02.000000000 -0400
@@ -21,6 +21,11 @@

 .include "options.mk"

+# NetBSD < 3.0 does not have reentrant resolver functions
+.if ${OPSYS} == "NetBSD" && !empty(OS_VERSION:M[1-2].*)
+CONFIGURE_ARGS+=	--disable-threaded-dns
+.endif
+
 post-install:
 	${INSTALL_DATA_DIR} ${PREFIX}/share/doc/dillo
 	${INSTALL_DATA} ${WRKSRC}/doc/*.txt ${PREFIX}/share/doc/dillo

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->adam
Responsible-Changed-By: snj@netbsd.org
Responsible-Changed-When: Sat, 23 Sep 2006 07:43:27 +0000
Responsible-Changed-Why:
Adam removed it.


From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/34591: Patch file that fixed DNS lookup problems in www/dillo
    was mistakenly removed in CVS
Date: Sat, 23 Sep 2006 14:23:48 +0200

 On Sat, Sep 23, 2006 at 04:35:00AM +0000, dhgutteridge@sympatico.ca wrote:
 > --- Makefile~	2006-09-22 22:43:11.000000000 -0400
 > +++ Makefile	2006-09-23 00:17:02.000000000 -0400
 > @@ -21,6 +21,11 @@
 >  
 >  .include "options.mk"
 >  
 > +# NetBSD < 3.0 does not have reentrant resolver functions
 > +.if ${OPSYS} == "NetBSD" && !empty(OS_VERSION:M[1-2].*)
 > +CONFIGURE_ARGS+=	--disable-threaded-dns
 > +.endif

 This would also apply to DragonFly, FreeBSD 4 and most likely OpenBSD.
 Not sure about the later though.

 Joerg

From: "David H. GUTTERIDGE" <dhgutteridge@sympatico.ca>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/34591: Patch file that fixed DNS lookup problems in www/dillo was mistak
Date: Sat, 23 Sep 2006 17:21:30 +0000

 >  This would also apply to DragonFly, FreeBSD 4 and most likely OpenBSD.
 >  Not sure about the later though.
 >
 >  Joerg

 When I created the original patch I submitted, I emailed the DragonFly users 
 list
 to see if it would be relevant for that OS too, but didn't get any response, 
 I
 guess I should have just asked you, Joerg.

 FreeBSD changed this particular family of functions over to be reentrant in 
 their
 5.5 release.  From looking at OpenBSD's ports CVS I can see they've simply
 changed the dns.c file to prevent the threaded code from being compiled in, 
 so
 that suggests we can safely follow their method for now for their OS.

 I've attached a more comprehensive patch below that handles all four major 
 BSDs
 for this package, I hope it's to everyone's liking.  Tim (garbled@) was 
 hesitant about
 the idea of bluntly disabling something for a given OS, but I don't see any 
 other way
 to do it, if DragonFly BSD and OpenBSD don't have the functionality yet.

 Dave

 --- Makefile~	2006-09-22 22:43:11.000000000 -0400
 +++ Makefile	2006-09-23 13:12:01.000000000 -0400
 @@ -21,6 +21,20 @@

 .include "options.mk"

 +# NetBSD < 3.0 does not have reentrant resolver functions
 +.if ${OPSYS} == "NetBSD" && !empty(OS_VERSION:M[1-2].*)
 +CONFIGURE_ARGS+=	--disable-threaded-dns
 +# DragonFly BSD as of 1.6 does not have reentrant resolver functions
 +.elif ${OPSYS} == "DragonFly"
 +CONFIGURE_ARGS+=	--disable-threaded-dns
 +# OpenBSD as of 3.9 does not have reentrant resolver functions
 +.elif ${OPSYS} == "OpenBSD"
 +CONFIGURE_ARGS+=	--disable-threaded-dns
 +# FreeBSD < 5.5 does not have (applicable) reentrant resolver functions
 +.elif ${OPSYS} == "FreeBSD" && (!empty(OS_VERSION:M[1-4].*) || 
 !empty(OS_VERSION:M5.[0-4]*))
 +CONFIGURE_ARGS+=	--disable-threaded-dns
 +.endif
 +
 post-install:
 	${INSTALL_DATA_DIR} ${PREFIX}/share/doc/dillo
 	${INSTALL_DATA} ${WRKSRC}/doc/*.txt ${PREFIX}/share/doc/dillo


From: "David H. Gutteridge" <dhgutteridge@sympatico.ca>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/34591: Patch file that fixed DNS lookup problems in www/dillo was mistakenly removed
Date: Tue, 19 May 2009 20:34:10 -0400

 This was for the older version of dillo, and as far as NetBSD goes, it
 was only relevant for releases that are now EOLed.  I believe there are
 supposed to be configure arguments that can be set now to effect the
 same, should someone care.  In other words, I'm fine to close this.

 Dave

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/34591: Patch file that fixed DNS lookup problems in
	www/dillo was mistakenly removed
Date: Mon, 25 May 2009 03:48:33 +0000

 On Wed, May 20, 2009 at 12:35:02AM +0000, David H. Gutteridge wrote:
  >  This was for the older version of dillo, and as far as NetBSD goes, it
  >  was only relevant for releases that are now EOLed.  I believe there are
  >  supposed to be configure arguments that can be set now to effect the
  >  same, should someone care.  In other words, I'm fine to close this.

 There are configure arguments, but no autodetection, so we ought to
 keep something in place until all of the OS releases involved are
 officially dead.

 Does anyone know the current state of the non-NetBSD versions cited
 earlier in the PR?

 -- 
 David A. Holland
 dholland@netbsd.org

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Thu, 18 Jun 2015 06:55:25 +0000
State-Changed-Why:
I think nowadays we can assume/pretend that everyone has a threaded resolver.
If anyone discovers that this is not the case, write in with details and I'll
take care of it.


>Unformatted:

Home	PR Database Search