NetBSD Problem Report #35474

From root@test-xen0.girsa.ro  Wed Jan 24 09:19:36 2007
Return-Path: <root@test-xen0.girsa.ro>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id A1A8363B8AD
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 24 Jan 2007 09:19:36 +0000 (UTC)
Message-Id: <20070124105829.50FA143B42@test-xen0.girsa.ro>
Date: Wed, 24 Jan 2007 12:58:29 +0200 (EET)
From: kefren@netbsd.ro
Reply-To: kefren@netbsd.ro
To: gnats-bugs@NetBSD.org
Subject: fsck_lfs problems
X-Send-Pr-Version: 3.95

>Number:         35474
>Category:       bin
>Synopsis:       fsck_lfs problems
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    dholland
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 24 09:20:00 +0000 2007
>Last-Modified:  Mon Aug 29 05:11:00 +0000 2016
>Originator:     Mihai Chelaru
>Release:        NetBSD 4.0_BETA2
>Organization:

>Environment:


System: NetBSD test-xen0.girsa.ro 4.0_BETA2 NetBSD 4.0_BETA2 (Kefren.DOM0) #0: Mon Jan 22 14:51:44 EET 2007 root@test-xen0.girsa.ro:/usr/src/sys/arch/i386/compile/Kefren.DOM0 i386
Architecture: i386
Machine: i386
>Description:

	sbin/fsck_lfs/inode.c line 153:

	ndb = howmany(dino.di_size, fs->lfs_bsize);

	line 162:

	if (--ndb == 0 && (offset = blkoff(fs, dino.di_size)) != 0) {

	don't know if the above check is correct in case dino.di_size == 0

second one:

	same sbin/fsck_lfs/inode.c lines 365-369:

	blks = howmany(dp->di_size, fs->lfs_bsize); 
	if (blks > NDADDR)
		blks = NDADDR + NIADDR;
	inp = emalloc(sizeof(*inp) + (blks - 1) * sizeof(ufs_daddr_t));

	same problem. If dp->di_size == 0 => blks = 0 and we will end up
	trying to alloc a huge area of memory and crash.


>How-To-Repeat:

	code inspect
>Fix:

	don't know

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: bin-bug-people->dholland
Responsible-Changed-By: dholland@NetBSD.org
Responsible-Changed-When: Mon, 29 Aug 2016 05:11:00 +0000
Responsible-Changed-Why:
lfs


>Unformatted:

Home	PR Database Search