NetBSD Problem Report #35955

From fuyuki@hadaly.org  Fri Mar  9 05:51:01 2007
Return-Path: <fuyuki@hadaly.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 28C3B63BA19
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  9 Mar 2007 05:51:01 +0000 (UTC)
Message-Id: <20070309055046.7BF56DCC06@lapis.hadaly.org>
Date: Fri,  9 Mar 2007 14:50:46 +0900 (JST)
From: fuyuki@hadaly.org
Reply-To: fuyuki@hadaly.org
To: gnats-bugs@NetBSD.org
Subject: sysutils/extipl doesn't work on amd64
X-Send-Pr-Version: 3.95

>Number:         35955
>Category:       pkg
>Synopsis:       sysutils/extipl doesn't work on amd64
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 09 05:55:00 +0000 2007
>Closed-Date:    Sat Jul 21 21:08:58 +0000 2018
>Last-Modified:  Sat Jul 21 21:10:01 +0000 2018
>Originator:     Kimura Fuyuki
>Release:        NetBSD 4.99.13
>Organization:

>Environment:


System: NetBSD lapis.hadaly.org 4.99.13 NetBSD 4.99.13 (LAPIS) #: Fri Mar 9 08:32:40 JST 2007 fuyuki@lapis.hadaly.org:/usr/obj/sys/arch/amd64/compile/LAPIS amd64
Architecture: x86_64
Machine: amd64
>Description:
sysutils/extipl doesn't work on amd64 since it assumes 32bit arch.

>How-To-Repeat:

>Fix:

http://www.hadaly.org/fuyuki/extipl.patch

>Release-Note:

>Audit-Trail:
From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/35955: sysutils/extipl doesn't work on amd64
Date: Fri, 9 Mar 2007 18:29:42 +0100

 On Fri, Mar 09, 2007 at 05:55:00AM +0000, fuyuki@hadaly.org wrote:
 > >Description:
 > sysutils/extipl doesn't work on amd64 since it assumes 32bit arch.

 I'd avoid the char -> int8, short ->int16 to keep the local changes
 smaller. They are fixed on any sane architecture. Can I ask to reduce
 the patch by that? The rest looks good, but I can't test it on 64bit
 right now.

 Joerg

From: Kimura Fuyuki <fuyuki@hadaly.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/35955: sysutils/extipl doesn't work on amd64
Date: Sat, 10 Mar 2007 07:11:21 +0900

 On Saturday 10 March 2007, Joerg Sonnenberger wrote:
 >
 >  I'd avoid the char -> int8, short ->int16 to keep the local changes
 >  smaller. They are fixed on any sane architecture. Can I ask to reduce
 >  the patch by that? The rest looks good, but I can't test it on 64bit
 >  right now.

 Yes, I did too much. The following should be enough.

 diff -ruN --exclude=CVS extipl.orig/distinfo extipl/distinfo
 --- extipl.orig/distinfo	2005-02-24 22:40:52.000000000 +0900
 +++ extipl/distinfo	2007-03-10 07:04:37.000000000 +0900
 @@ -4,3 +4,4 @@
  RMD160 (extipl-5.04.tar.gz) = a7c037f92609463d61b3c7d52276e3849aa44055
  Size (extipl-5.04.tar.gz) = 85382 bytes
  SHA1 (patch-aa) = 12240b347d1d5d6d363a070376b1c115a004f454
 +SHA1 (patch-ab) = ee21cea6db73a4b835609febd476c7f38d979e7d
 diff -ruN --exclude=CVS extipl.orig/patches/patch-ab extipl/patches/patch-ab
 --- extipl.orig/patches/patch-ab	1970-01-01 09:00:00.000000000 +0900
 +++ extipl/patches/patch-ab	2007-03-10 07:04:26.000000000 +0900
 @@ -0,0 +1,27 @@
 +$NetBSD$
 +
 +--- extipl.h.orig	2002-03-25 22:48:52.000000000 +0900
 ++++ extipl.h
 +@@ -5,4 +5,6 @@
 +  */
 + 
 ++#include <stdint.h>
 ++
 + #define VERSION			"5.04"
 + #define DATE			"2002/03/26"
 +@@ -40,5 +42,5 @@
 + 
 + typedef unsigned char byte;
 +-typedef unsigned long long ul_long;
 ++typedef uint64_t ul_long;
 + 
 + typedef struct hdadr_s {
 +@@ -53,6 +55,6 @@ typedef struct partition_s {
 + 	byte	       sysind;
 + 	hdadr_s        end_chs;
 +-	unsigned long  sector_offset;
 +-	unsigned long  nr_sector;
 ++	uint32_t       sector_offset;
 ++	uint32_t       nr_sector;
 +     } partition_s;
 + 

Responsible-Changed-From-To: pkg-manager->hiramatsu
Responsible-Changed-By: obache@NetBSD.org
Responsible-Changed-When: Mon, 30 Apr 2012 12:06:51 +0000
Responsible-Changed-Why:
Over to maintainer.


Responsible-Changed-From-To: hiramatsu->pkg-manager
Responsible-Changed-By: dholland@NetBSD.org
Responsible-Changed-When: Wed, 06 Dec 2017 00:46:00 +0000
Responsible-Changed-Why:
reset Responsible: for retired developer

(and, sigh: 10-year-old PR with a committable patch)


State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Sat, 21 Jul 2018 21:08:58 +0000
State-Changed-Why:
Applied, thanks for the patch! Sorry for the very delayed application. It got lost.


From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/35955 CVS commit: pkgsrc/sysutils/extipl
Date: Sat, 21 Jul 2018 21:08:03 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Sat Jul 21 21:08:03 UTC 2018

 Modified Files:
 	pkgsrc/sysutils/extipl: Makefile distinfo
 Added Files:
 	pkgsrc/sysutils/extipl/patches: patch-extipl.h

 Log Message:
 extipl: 64bit support, from Kimura Fuyuki in PR pkg/35955.


 To generate a diff of this commit:
 cvs rdiff -u -r1.13 -r1.14 pkgsrc/sysutils/extipl/Makefile
 cvs rdiff -u -r1.5 -r1.6 pkgsrc/sysutils/extipl/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/sysutils/extipl/patches/patch-extipl.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search