NetBSD Problem Report #36343

From yhardy@uj.ac.za  Tue May 15 08:16:40 2007
Return-Path: <yhardy@uj.ac.za>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 9F4A263B970
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 15 May 2007 08:16:40 +0000 (UTC)
Message-Id: <46496EC1.4070801@uj.ac.za>
Date: Tue, 15 May 2007 10:26:41 +0200
From: Yorick Hardy <yhardy@uj.ac.za>
To: gnats-bugs@NetBSD.org
Subject: make cddb optional for libcdio

>Number:         36343
>Category:       pkg
>Synopsis:       make cddb optional for libcdio
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue May 15 08:20:00 +0000 2007
>Last-Modified:  Sun Apr 29 08:16:06 +0000 2018
>Originator:     Yorick Hardy
>Release:        NetBSD 4.99.16
>Organization:
>Environment:
System: NetBSD yorick 4.99.16 NetBSD 4.99.16 (HPNX6310DRMcurrent) #0: Sun Apr 8 20:20:02 SAST 2007 root@yorick:/var/tmp/build/objcur/sys/arch/i386/compile/HPNX6310DRMcurrent i386
Architecture: i386
Machine: i386
>Description:
Please make cddb optional for libcdio
>How-To-Repeat:
>Fix:
--- misc/libcdio/Makefile.orig	2007-04-27 09:28:59.000000000 +0200
+++ misc/libcdio/Makefile	2007-04-27 09:31:45.000000000 +0200
@@ -31,7 +31,15 @@
 	${CP} ${FILESDIR}/_cdio_netbsd.c ${WRKSRC}/lib/driver/FreeBSD/freebsd.c
 .endif

+PKG_OPTIONS_VAR=	PKG_OPTIONS.libcdio
+PKG_SUPPORTED_OPTIONS=	cddb
+PKG_SUGGESTED_OPTIONS=	cddb
+
+.include "../../mk/bsd.options.mk"
+
 .include "../../devel/ncurses/buildlink3.mk"
 .include "../../devel/popt/buildlink3.mk"
-.include "../../audio/libcddb/buildlink3.mk"
+.if !empty(PKG_OPTIONS:Mcddb)
+.  include "../../audio/libcddb/buildlink3.mk"
+.endif
 .include "../../mk/bsd.pkg.mk"

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->drochner
Responsible-Changed-By: reed@netbsd.org
Responsible-Changed-When: Tue, 22 May 2007 13:57:10 +0000
Responsible-Changed-Why:
Assign to maintainer.


From: Matthias Scheler <tron@zhadum.org.uk>
To: NetBSD GNATS <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/36343
Date: Tue, 26 Jun 2007 13:03:18 +0100

 	Hello,

 the last part of the patch should probably look like this:

 .if empty(PKG_OPTIONS:Mcddb)
 CONFIGURE_ARGS+=	--disable-cddb
 .else
 .include "../../audio/libcddb/buildlink3.mk"
 .endif

 The build might otherwise fail if "libcddb" is installed.

 	Kind regards

 -- 
 Matthias Scheler                                  http://zhadum.org.uk/

From: Yorick Hardy <yhardy@uj.ac.za>
To: gnats-bugs@NetBSD.org
Cc: tron@zhadum.org.uk
Subject: Re: pkg/36343
Date: Tue, 26 Jun 2007 18:17:03 +0200

 Yes, thanks for catching that.

 Matthias Scheler wrote:
 > The following reply was made to PR pkg/36343; it has been noted by GNATS.
 > 
 > From: Matthias Scheler <tron@zhadum.org.uk>
 > To: NetBSD GNATS <gnats-bugs@NetBSD.org>
 > Cc: 
 > Subject: Re: pkg/36343
 > Date: Tue, 26 Jun 2007 13:03:18 +0100
 > 
 >  	Hello,
 >  
 >  the last part of the patch should probably look like this:
 >  
 >  .if empty(PKG_OPTIONS:Mcddb)
 >  CONFIGURE_ARGS+=	--disable-cddb
 >  .else
 >  .include "../../audio/libcddb/buildlink3.mk"
 >  .endif
 >  
 >  The build might otherwise fail if "libcddb" is installed.
 >  
 >  	Kind regards
 >  
 >  -- 
 >  Matthias Scheler                                  http://zhadum.org.uk/
 >  
 > 


 -- 
 Kind regards,

 Yorick Hardy

Responsible-Changed-From-To: drochner->packages
Responsible-Changed-By: spz@NetBSD.org
Responsible-Changed-When: Sun, 29 Apr 2018 07:58:25 +0000
Responsible-Changed-Why:
drochner is inactive


Responsible-Changed-From-To: packages->pkg-manager
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Sun, 29 Apr 2018 08:16:06 +0000
Responsible-Changed-Why:
Proper role account


>Unformatted:

Home	PR Database Search