NetBSD Problem Report #37057

From khorben@defora.org  Wed Oct  3 20:56:30 2007
Return-Path: <khorben@defora.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id B37A563B8C2
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  3 Oct 2007 20:56:30 +0000 (UTC)
Message-Id: <20071003205618.160FD29C1@exxh.defora.lan>
Date: Wed,  3 Oct 2007 22:56:17 +0200 (CEST)
From: Pierre Pronchery <khorben@defora.org>
Reply-To: khorben@defora.org
To: gnats-bugs@NetBSD.org
Subject: MPlayer crashes on sparc64 within the x11 video driver
X-Send-Pr-Version: 3.95

>Number:         37057
>Category:       pkg
>Synopsis:       MPlayer crashes on sparc64 within the x11 video driver
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Oct 03 21:00:00 +0000 2007
>Closed-Date:    Tue Sep 27 00:24:41 +0000 2016
>Last-Modified:  Tue Sep 27 00:24:41 +0000 2016
>Originator:     khorben@defora.org
>Release:        NetBSD 4.99.31
>Organization:

>Environment:
System: NetBSD exxh.defora.lan 4.99.31 NetBSD 4.99.31 (GENERIC) #0: Sun Sep 30 18:22:11 CEST 2007 khorben@exxh.defora.lan:/usr/obj/sys/arch/sparc64/compile/GENERIC sparc64
Architecture: sparc64
Machine: sparc64
>Description:
Just like as reported in pkg/37054, MPlayer crashes due to incorrect usage of
XChangeProperty() with a bus error. In libvo/x11_common.c:

 935 void vo_x11_classhint(Display * display, Window window, char *name)
 936 {
 937     XClassHint wmClass;
 938     pid_t pid = getpid();
 939 
 940     wmClass.res_name = name;
 941     wmClass.res_class = "MPlayer";
 942     XSetClassHint(display, window, &wmClass);
 943     XChangeProperty(display, window, XA_NET_WM_PID, XA_CARDINAL, 32,
 944                     PropModeReplace, (unsigned char *) &pid, 1);
 945 }

The pid variable at line 938 is not aligned on the size of a long.

>How-To-Repeat:
Use MPlayer mplayer-1.0rc9nb9 from pkgsrc on sparc64 with the x11 video output
plug-in.
>Fix:
The following patch fixes the problem:

$NetBSD$

--- libvo/x11_common.c.orig	2006-10-23 00:32:26.000000000 +0200
+++ libvo/x11_common.c
@@ -935,7 +935,7 @@ void vo_x11_decoration(Display * vo_Disp
 void vo_x11_classhint(Display * display, Window window, char *name)
 {
     XClassHint wmClass;
-    pid_t pid = getpid();
+    long pid = getpid();

     wmClass.res_name = name;
     wmClass.res_class = "MPlayer";

>Release-Note:

>Audit-Trail:
From: Sergey Svishchev <svs@ropnet.ru>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/37057
Date: Sat, 24 Jan 2009 13:23:24 +0300

 There's a MPlayer bugzilla on this issue:

 http://bugzilla.mplayerhq.hu/show_bug.cgi?id=1051

 I've appended your patch to it.

 -- 
 Sergey Svishchev

State-Changed-From-To: open->analyzed
State-Changed-By: shattered@NetBSD.org
State-Changed-When: Fri, 07 Oct 2011 21:16:30 +0000
State-Changed-Why:


State-Changed-From-To: analyzed->closed
State-Changed-By: mrg@NetBSD.org
State-Changed-When: Tue, 27 Sep 2016 00:24:41 +0000
State-Changed-Why:
a similar patch has been in mplayer for a while.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.