NetBSD Problem Report #37578

From martin@duskware.de  Fri Dec 21 07:54:41 2007
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 82B0F63B8A2
	for <gnats-bugs@gnats.netbsd.org>; Fri, 21 Dec 2007 07:54:41 +0000 (UTC)
Message-Id: <20071221012935.0983F63B8A2@narn.NetBSD.org>
Date: Fri, 21 Dec 2007 01:29:35 +0000 (UTC)
From: cliff@snipe444.org
Reply-To: cliff@snipe444.org
To: netbsd-bugs-owner@NetBSD.org
Subject: bce(4) man page change
X-Send-Pr-Version: www-1.0

>Number:         37578
>Category:       misc
>Synopsis:       bce(4) man page change
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people
>State:          open
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Dec 21 07:55:00 +0000 2007
>Last-Modified:  Sun Jan 01 01:45:01 +0000 2012
>Originator:     Cliff Wright
>Release:        all with bce(4)
>Organization:
>Environment:
>Description:
The man page for bce(4) lists under bugs that there is no vlan
support. This is actually not true. I just never tracked down in the
spec if all special cases that use extra bytes are covered. But
since I don't think we use these special cases, it would probably
be fine to remove this statement, as the bce driver has always
had support for the increased mtu.
>How-To-Repeat:

>Fix:

>Audit-Trail:
From: Manuel Bouyer <bouyer@antioche.eu.org>
To: gnats-bugs@gnats.netbsd.org
Cc: 
Subject: Re: misc/37578 bce(4) man page change
Date: Sat, 15 Nov 2008 22:41:32 +0100

 > The man page for bce(4) lists under bugs that there is no vlan
 > support. This is actually not true. I just never tracked down in the
 > spec if all special cases that use extra bytes are covered. But
 > since I don't think we use these special cases, it would probably
 > be fine to remove this statement, as the bce driver has always
 > had support for the increased mtu.

 should the man page be changed to "There is no hardware VLAN support"
 then ?

 -- 
 Manuel Bouyer <bouyer@antioche.eu.org>
      NetBSD: 26 ans d'experience feront toujours la difference
 --

From: "Jonathan A. Kollasch" <jakllsch@kollasch.net>
To: gnats-bugs@NetBSD.org
Cc: misc-bug-people@netbsd.org, gnats-admin@netbsd.org,
	netbsd-bugs@netbsd.org, cliff@snipe444.org
Subject: Re: misc/37578 bce(4) man page change
Date: Sun, 16 Nov 2008 00:00:02 +0000

 >  > The man page for bce(4) lists under bugs that there is no vlan
 >  > support. This is actually not true. I just never tracked down in the
 >  > spec if all special cases that use extra bytes are covered. But
 >  > since I don't think we use these special cases, it would probably
 >  > be fine to remove this statement, as the bce driver has always
 >  > had support for the increased mtu.
 >  
 >  should the man page be changed to "There is no hardware VLAN support"
 >  then ?

 I think the hardware does support it.  However bce(4) doesn't
 have ETHERCAP_VLAN_MTU enabled.  Testing I've done (with the
 BCM4400 core in the BCM5365) shows ETHERCAP_VLAN_MTU to work
 fine, but the real BCM4401 might be slightly different.

From: "Jonathan A. Kollasch" <jakllsch@kollasch.net>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: misc/37578: bce(4) man page change
Date: Sat, 31 Dec 2011 20:33:51 +0000

 Pending testing on a typical PCI-attached BCM440x core, I propose adding
 ETHERCAP_VLAN_MTU in the driver, and removing the note in the man page.

From: Cliff Wright <cliff@snipe444.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: misc/37578: bce(4) man page change
Date: Sat, 31 Dec 2011 17:42:24 -0800

 On Sat, 31 Dec 2011 20:35:03 +0000 (UTC)
 "Jonathan A. Kollasch" <jakllsch@kollasch.net> wrote:

 >  Pending testing on a typical PCI-attached BCM440x core, I propose adding
 >  ETHERCAP_VLAN_MTU in the driver, and removing the note in the man page.

 I think this should work. BCE_RX_MAX/BCE_TX_MAX is the max
 packet length registers, which are set to 32 bytes over 1518
 which accounts for a broadcom 28 byte header(rx_pph), leaving 4 bytes for vlan tag. 


 -- 
 Cliff Wright <cliff@snipe444.org>

Home	PR Database Search