NetBSD Problem Report #37610

From martin@duskware.de  Tue Dec 25 12:02:28 2007
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 0B9E163B852
	for <gnats-bugs@gnats.netbsd.org>; Tue, 25 Dec 2007 12:02:28 +0000 (UTC)
Message-Id: <20071225112911.8DB1663B852@narn.NetBSD.org>
Date: Tue, 25 Dec 2007 11:29:11 +0000 (UTC)
From: cesium2@gmail.com
Reply-To: cesium2@gmail.com
To: netbsd-bugs-owner@NetBSD.org
Subject: Xaw3d segfaults when changing the text of a backed internationaled text widget
X-Send-Pr-Version: www-1.0

>Number:         37610
>Category:       pkg
>Synopsis:       Xaw3d segfaults when changing the text of a backed internationaled text widget
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 25 12:05:01 +0000 2007
>Last-Modified:  Sat Jan 19 09:19:59 +0000 2008
>Originator:     Yair K.
>Release:        N/A
>Organization:
>Environment:
Linux 2.6.23.9 x86_64
>Description:
Xaw3d may crash an application if an internationalized text  
widget's value is updated by the program, and useStringinPlace is False  
(default value) - xaw3d tries to free the incorrect address. I suspect Xaw-Xpm has this issue as well (the patch applies as well), though I haven't tested it.
>How-To-Repeat:
1) Compile timidity using XAW_TYPE=3d. Try to use tab-completion in the "Load file" window. timidity will segfault at once.
2) Compile gv using XAW_TYPE=3d. Crashes when selecting file names in the file->open dialog.

(This issue probably is OS independent, and should affect NetBSD systems as well).
>Fix:
1) Fix: the following patch is copied from Fedora[1], and will apply to version 1.5E as well:

--- Xaw3d-1.5/xc/lib/Xaw3d/MultiSrc.c.orig	Tue Aug  6 22:51:08 2002
+++ Xaw3d-1.5/xc/lib/Xaw3d/MultiSrc.c	Tue Aug  6 22:51:16 2002
@@ -735,6 +735,7 @@

   if ( string_set || (old_src->multi_src.type != src->multi_src.type) ) {
     RemoveOldStringOrFile(old_src, string_set);
+    src->multi_src.allocated_string = old_src->multi_src.allocated_string;
     file = InitStringOrFile(src, string_set);

     /* Load pieces does this logic for us, but it shouldn't.  Its messy.*/

2) Workaround: in the affected applications, XawAsciiSourceFreeString in the right places should prevent crashes (string_set becomes False).

[1] http://rpmfind.net//linux/RPM/fedora/7/x86_64/Xaw3d-1.5E-10.1.i386.html - see Aug 09 2002 entry.

>Release-Note:

>Audit-Trail:

From: "Jeremy C. Reed" <reed@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/37609 CVS commit: pkgsrc
Date: Thu, 27 Dec 2007 14:14:25 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	reed
 Date:		Thu Dec 27 14:14:25 UTC 2007

 Modified Files:
 	pkgsrc/doc: CHANGES-2007
 	pkgsrc/x11/Xaw3d: Makefile distinfo
 Added Files:
 	pkgsrc/x11/Xaw3d/patches: patch-ae

 Log Message:
 Add patch and bump revision.

 This is for PR 37610 to fix internationalized text bug.

 This fix was already in XFree86 and Xorg libXaw versions since at
 least Nov. 2004 and in Fedora for Xaw3d since 2002.


 To generate a diff of this commit:
 cvs rdiff -r1.2707 -r1.2708 pkgsrc/doc/CHANGES-2007
 cvs rdiff -r1.53 -r1.54 pkgsrc/x11/Xaw3d/Makefile
 cvs rdiff -r1.11 -r1.12 pkgsrc/x11/Xaw3d/distinfo
 cvs rdiff -r0 -r1.1 pkgsrc/x11/Xaw3d/patches/patch-ae

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


Responsible-Changed-From-To: pkg-manager->garbled
Responsible-Changed-By: reed@netbsd.org
Responsible-Changed-When: Thu, 27 Dec 2007 14:16:25 +0000
Responsible-Changed-Why:
Assign to maintainer for Xaw-Xpm. Can you check that?
I already fixed Xaw3d and I see that libXaw already has the fix.


Responsible-Changed-From-To: garbled->pkg-manager
Responsible-Changed-By: wiz@narn.netbsd.org
Responsible-Changed-When: Sat, 19 Jan 2008 09:19:59 +0000
Responsible-Changed-Why:
Maintainer reset, back to role account.


>Unformatted:

Home	PR Database Search