NetBSD Problem Report #37756

From fukumoto@imasy.or.jp  Mon Jan 14 20:22:25 2008
Return-Path: <fukumoto@imasy.or.jp>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 2305963BD77
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 14 Jan 2008 20:22:25 +0000 (UTC)
Message-Id: <20080114202211.9D82E4F38A@kestrel.imasy.or.jp>
Date: Tue, 15 Jan 2008 05:22:11 +0900 (JST)
From: fukumoto@imasy.or.jp
Reply-To: fukumoto@imasy.or.jp
To: gnats-bugs@NetBSD.org
Subject: nfsmb(4) fails to attach nForce430 SMBus
X-Send-Pr-Version: 3.95

>Number:         37756
>Category:       kern
>Synopsis:       nfsmb(4) fails to attach nForce430 SMBus
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 14 20:25:00 +0000 2008
>Closed-Date:    Mon Jan 14 20:30:53 +0000 2008
>Last-Modified:  Mon Jan 14 20:35:01 +0000 2008
>Originator:     atsushi fukumoto
>Release:        NetBSD 4.99.49
>Organization:
>Environment:


System: NetBSD kestrel 4.99.49 NetBSD 4.99.49 (GENERIC) #14: Tue Jan 15 05:02:27 JST 2008 fukumoto@kestrel:/usr/src.current/sys/arch/i386/compile/obj/GENERIC i386
Architecture: i386
Machine: i386
>Description:
nfsmb(4) fails to attach nForce430 SMBus.

Jan 15 11:58:09 kestrel /netbsd: nfsmbc0 at pci0 dev 10 function 1: NVIDIA nForce430 SMBus Controller (rev. 0xa3)
Jan 15 11:58:09 kestrel /netbsd: nfsmb0 at nfsmbc0 SMBus 1
Jan 15 11:58:09 kestrel /netbsd: nfsmb0: failed to map SMBus space
Jan 15 11:58:09 kestrel /netbsd: nfsmb1 at nfsmbc0 SMBus 2
Jan 15 11:58:09 kestrel /netbsd: nfsmb1: failed to map SMBus space

sys/dev/pci/nfsmb.c:nfsmb_attach() switch statement chooses
nForce430 to use NFORCE_OLD_SMB*, which appears to be wrong.
After commenting out the case line, it looks like working correctly:

nfsmbc0 at pci0 dev 10 function 1: NVIDIA nForce430 SMBus Controller (rev. 0xa3)
nfsmb0 at nfsmbc0 SMBus 1
iic0 at nfsmb0: I2C bus
spdmem0 at iic0 addr 0x51
spdmem0: DDR2 SDRAM memory, no parity or ECC, 1024MB, 667MHz, PC2-5300
spdmem0: 14 rows, 10 cols, 2 ranks, 4 banks/chip, 3.00ns cycle time
spdmem0: voltage SSTL 1.8V, refresh time 7.8us (self-refreshing)
nfsmb1 at nfsmbc0 SMBus 2
iic1 at nfsmb1: I2C bus

>How-To-Repeat:

>Fix:

Index: nfsmb.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/nfsmb.c,v
retrieving revision 1.10
diff -u -u -r1.10 nfsmb.c
--- nfsmb.c	4 Dec 2007 15:58:11 -0000	1.10
+++ nfsmb.c	14 Jan 2008 20:16:00 -0000
@@ -158,7 +158,6 @@
 	case PCI_PRODUCT_NVIDIA_NFORCE3_SMBUS:
 	case PCI_PRODUCT_NVIDIA_NFORCE3_250_SMBUS:
 	case PCI_PRODUCT_NVIDIA_NFORCE4_SMBUS:
-	case PCI_PRODUCT_NVIDIA_NFORCE430_SMBUS:
 		baseregs[0] = NFORCE_OLD_SMB1;
 		baseregs[1] = NFORCE_OLD_SMB2;
 		break;

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: xtraeme@netbsd.org
State-Changed-When: Mon, 14 Jan 2008 20:30:53 +0000
State-Changed-Why:
Patch applied, thanks for your tests.


From: Juan Romero Pardines <xtraeme@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/37756 CVS commit: src/sys/dev/pci
Date: Mon, 14 Jan 2008 20:30:11 +0000 (UTC)

 Module Name:	src
 Committed By:	xtraeme
 Date:		Mon Jan 14 20:30:11 UTC 2008

 Modified Files:
 	src/sys/dev/pci: nfsmb.c

 Log Message:
 Fix the BARs on nForce 430, which failed to attach. Reported by
 atsushi fukumoto in PR kern/37756.


 To generate a diff of this commit:
 cvs rdiff -r1.10 -r1.11 src/sys/dev/pci/nfsmb.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.