NetBSD Problem Report #37855

From martin@duskware.de  Wed Jan 23 20:15:18 2008
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 37F5463B938
	for <gnats-bugs@gnats.netbsd.org>; Wed, 23 Jan 2008 20:15:18 +0000 (UTC)
Message-Id: <20080123200357.E61BB63B938@narn.NetBSD.org>
Date: Wed, 23 Jan 2008 20:03:57 +0000 (UTC)
From: bsd@cs.ubc.ca
Reply-To: bsd@cs.ubc.ca
To: netbsd-bugs-owner@NetBSD.org
Subject: comms/jpilot does not compile on Darwin
X-Send-Pr-Version: www-1.0

>Number:         37855
>Category:       pkg
>Synopsis:       comms/jpilot does not compile on Darwin
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    bsiegert
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 23 20:20:00 +0000 2008
>Closed-Date:    Sat Nov 22 20:51:53 +0000 2014
>Last-Modified:  Sat Nov 22 20:55:01 +0000 2014
>Originator:     Brian de Alwis
>Release:        n/a
>Organization:
>Environment:
Darwin 9.1.0 (Mac OS X 10.5.1)
>Description:
The attached patch fixes two problems with the build, and also includes a header files required to build jpilot plugins.

Fix 1. comms/jpilot requires gmake to build.

Fix 2. The Makefile explicitly sets LDFLAGS=-export-dynamic which is not supported on Darwin/Mac OS X.

The attached patch also causes config.h to be installed as it is required by libplugin.h.  It has some useful defines for plugins such as PACKAGE, PACKAGE_BUGREPORT, PACKAGE_NAME, PACKAGE_STRING, PACKAGE_VERSION, and PROGNAME.
>How-To-Repeat:

>Fix:
=== modified file 'comms/jpilot/Makefile'
--- comms/jpilot/Makefile	2008-01-09 15:38:08 +0000
+++ comms/jpilot/Makefile	2008-01-20 19:37:16 +0000
@@ -16,13 +16,18 @@
 USE_PKGLOCALEDIR=	YES
 USE_OLD_DES_API=	YES
 USE_DIRS+=		xdg-1.4
-USE_TOOLS+=		intltool msgfmt pkg-config
+USE_TOOLS+=		intltool msgfmt pkg-config gmake
 USE_LANGUAGES+=		c

 GNU_CONFIGURE=		YES
 CONFIGURE_ARGS+=	--with-gtk-prefix="${BUILDLINK_PREFIX.gtk2}"
 CONFIGURE_ARGS+=	--with-pilot-prefix="${BUILDLINK_PREFIX.pilot-link-libs}"
+
+.include "../../mk/bsd.prefs.mk"
+
+.if ${OPSYS} != "Darwin"
 LDFLAGS+=		-export-dynamic
+.endif

 DOCDIR=			${PREFIX}/share/doc/jpilot
 INCDIR=			${PREFIX}/include/jpilot
@@ -48,7 +53,7 @@
 	${INSTALL_DATA_DIR} ${DOCDIR}
 	${INSTALL_DATA_DIR} ${INCDIR}
 	${INSTALL_DATA_DIR} ${PLUGINSDIR}
-	cd ${WRKSRC}; ${INSTALL_DATA} libplugin.h prefs.h ${INCDIR}
+	cd ${WRKSRC}; ${INSTALL_DATA} config.h libplugin.h prefs.h ${INCDIR}
 	${INSTALL_DATA} ${WRKSRC}/BUGS ${DOCDIR}
 	cd ${WRKSRC}/docs; ${INSTALL_MAN} *.1 ${MAN1DIR}
 	${TOUCH} ${PLUGINSDIR}/.directory

=== modified file 'comms/jpilot/PLIST'
--- comms/jpilot/PLIST	2008-01-09 15:38:08 +0000
+++ comms/jpilot/PLIST	2008-01-23 19:59:16 +0000
@@ -2,6 +2,7 @@
 bin/jpilot
 bin/jpilot-dump
 bin/jpilot-sync
+include/jpilot/config.h
 include/jpilot/libplugin.h
 include/jpilot/prefs.h
 lib/jpilot/plugins/.directory


>Release-Note:

>Audit-Trail:
From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/37855: comms/jpilot does not compile on Darwin
Date: Wed, 23 Jan 2008 21:25:37 +0100

 On Wed, Jan 23, 2008 at 08:20:00PM +0000, bsd@cs.ubc.ca wrote:
 > Fix 2. The Makefile explicitly sets LDFLAGS=-export-dynamic which is
 > not supported on Darwin/Mac OS X.

 Package should use EXPORT_SYMBOLS_LDFLAGS here.

 Joerg

From: Brian de Alwis <bsd@cs.ubc.ca>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@NetBSD.org, gnats-admin@NetBSD.org, pkgsrc-bugs@NetBSD.org
Subject: Re: pkg/37855: comms/jpilot does not compile on Darwin
Date: Wed, 23 Jan 2008 15:49:04 -0600

 On 23-Jan-2008, at 2:30 PM, Joerg Sonnenberger wrote:
 > On Wed, Jan 23, 2008 at 08:20:00PM +0000, bsd@cs.ubc.ca wrote:
 >> Fix 2. The Makefile explicitly sets LDFLAGS=-export-dynamic which is
 >> not supported on Darwin/Mac OS X.
 >
 > Package should use EXPORT_SYMBOLS_LDFLAGS here.


 Ah, thanks for that.  I've respun the patch; not sure if the  
 <bsd.prefs.mk> is still necessary?

 === modified file 'comms/jpilot/Makefile'
 --- comms/jpilot/Makefile	2008-01-09 15:38:08 +0000
 +++ comms/jpilot/Makefile	2008-01-23 21:41:54 +0000
 @@ -16,13 +16,17 @@
   USE_PKGLOCALEDIR=	YES
   USE_OLD_DES_API=	YES
   USE_DIRS+=		xdg-1.4
 -USE_TOOLS+=		intltool msgfmt pkg-config
 +USE_TOOLS+=		intltool msgfmt pkg-config gmake
   USE_LANGUAGES+=		c

   GNU_CONFIGURE=		YES
   CONFIGURE_ARGS+=	--with-gtk-prefix="${BUILDLINK_PREFIX.gtk2}"
   CONFIGURE_ARGS+=	--with-pilot-prefix="${BUILDLINK_PREFIX.pilot-link- 
 libs}"
 -LDFLAGS+=		-export-dynamic
 +
 +.include "../../mk/bsd.prefs.mk"
 +
 +# Ensure we export symbols in the linked shared object.
 +LDFLAGS+=       	${EXPORT_SYMBOLS_LDFLAGS}

   DOCDIR=			${PREFIX}/share/doc/jpilot
   INCDIR=			${PREFIX}/include/jpilot
 @@ -48,7 +52,7 @@
   	${INSTALL_DATA_DIR} ${DOCDIR}
   	${INSTALL_DATA_DIR} ${INCDIR}
   	${INSTALL_DATA_DIR} ${PLUGINSDIR}
 -	cd ${WRKSRC}; ${INSTALL_DATA} libplugin.h prefs.h ${INCDIR}
 +	cd ${WRKSRC}; ${INSTALL_DATA} config.h libplugin.h prefs.h ${INCDIR}
   	${INSTALL_DATA} ${WRKSRC}/BUGS ${DOCDIR}
   	cd ${WRKSRC}/docs; ${INSTALL_MAN} *.1 ${MAN1DIR}
   	${TOUCH} ${PLUGINSDIR}/.directory

 === modified file 'comms/jpilot/PLIST'
 --- comms/jpilot/PLIST	2008-01-09 15:38:08 +0000
 +++ comms/jpilot/PLIST	2008-01-23 19:59:16 +0000
 @@ -2,6 +2,7 @@
   bin/jpilot
   bin/jpilot-dump
   bin/jpilot-sync
 +include/jpilot/config.h
   include/jpilot/libplugin.h
   include/jpilot/prefs.h
   lib/jpilot/plugins/.directory


 -- 
   Brian de Alwis | Software Practices Lab | UBC | http://www.cs.ubc.ca/~bsd/
        "Amusement to an observing mind is study." - Benjamin Disraeli

From: Brian de Alwis <bsd@cs.ubc.ca>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@NetBSD.org, gnats-admin@NetBSD.org, pkgsrc-bugs@NetBSD.org
Subject: Re: pkg/37855: comms/jpilot does not compile on Darwin
Date: Wed, 23 Jan 2008 16:18:46 -0600

 On 23-Jan-2008, at 3:50 PM, Brian de Alwis wrote:
 > Ah, thanks for that.  I've respun the patch; not sure if the
 > <bsd.prefs.mk> is still necessary?


 As I'm the one that introduced the <bsd.prefs.mk> I've removed it and  
 respun the patch again.

 === modified file 'comms/jpilot/Makefile'
 --- comms/jpilot/Makefile	2008-01-09 15:38:08 +0000
 +++ comms/jpilot/Makefile	2008-01-23 22:14:26 +0000
 @@ -16,13 +16,15 @@
   USE_PKGLOCALEDIR=	YES
   USE_OLD_DES_API=	YES
   USE_DIRS+=		xdg-1.4
 -USE_TOOLS+=		intltool msgfmt pkg-config
 +USE_TOOLS+=		intltool msgfmt pkg-config gmake
   USE_LANGUAGES+=		c

   GNU_CONFIGURE=		YES
   CONFIGURE_ARGS+=	--with-gtk-prefix="${BUILDLINK_PREFIX.gtk2}"
   CONFIGURE_ARGS+=	--with-pilot-prefix="${BUILDLINK_PREFIX.pilot-link- 
 libs}"
 -LDFLAGS+=		-export-dynamic
 +
 +# Ensure we export symbols in the linked shared object.
 +LDFLAGS+=       	${EXPORT_SYMBOLS_LDFLAGS}

   DOCDIR=			${PREFIX}/share/doc/jpilot
   INCDIR=			${PREFIX}/include/jpilot
 @@ -48,7 +50,7 @@
   	${INSTALL_DATA_DIR} ${DOCDIR}
   	${INSTALL_DATA_DIR} ${INCDIR}
   	${INSTALL_DATA_DIR} ${PLUGINSDIR}
 -	cd ${WRKSRC}; ${INSTALL_DATA} libplugin.h prefs.h ${INCDIR}
 +	cd ${WRKSRC}; ${INSTALL_DATA} config.h libplugin.h prefs.h ${INCDIR}
   	${INSTALL_DATA} ${WRKSRC}/BUGS ${DOCDIR}
   	cd ${WRKSRC}/docs; ${INSTALL_MAN} *.1 ${MAN1DIR}
   	${TOUCH} ${PLUGINSDIR}/.directory

 === modified file 'comms/jpilot/PLIST'
 --- comms/jpilot/PLIST	2008-01-09 15:38:08 +0000
 +++ comms/jpilot/PLIST	2008-01-23 19:59:16 +0000
 @@ -2,6 +2,7 @@
   bin/jpilot
   bin/jpilot-dump
   bin/jpilot-sync
 +include/jpilot/config.h
   include/jpilot/libplugin.h
   include/jpilot/prefs.h
   lib/jpilot/plugins/.directory

 -- 
   Brian de Alwis | Software Practices Lab | UBC | http://www.cs.ubc.ca/~bsd/
        "Amusement to an observing mind is study." - Benjamin Disraeli

Responsible-Changed-From-To: pkg-manager->darwin-pkg-people
Responsible-Changed-By: obache@narn.netbsd.org
Responsible-Changed-When: Thu, 24 Jan 2008 10:33:41 +0000
Responsible-Changed-Why:
Problem on Darwin.


Responsible-Changed-From-To: darwin-pkg-people->macos-pkg-people
Responsible-Changed-By: dholland@NetBSD.org
Responsible-Changed-When: Wed, 07 Mar 2012 07:07:51 +0000
Responsible-Changed-Why:
darwin-pkg-people has been changed to macos-pkg-people


Responsible-Changed-From-To: macos-pkg-people->bsiegert
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Sat, 22 Nov 2014 20:51:53 +0000
Responsible-Changed-Why:
Man, this role account is a graveyard for bugs


State-Changed-From-To: open->closed
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Sat, 22 Nov 2014 20:51:53 +0000
State-Changed-Why:
Fix applied, thanks.


From: "Benny Siegert" <bsiegert@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/37855 CVS commit: pkgsrc/comms/jpilot
Date: Sat, 22 Nov 2014 20:49:59 +0000

 Module Name:	pkgsrc
 Committed By:	bsiegert
 Date:		Sat Nov 22 20:49:59 UTC 2014

 Modified Files:
 	pkgsrc/comms/jpilot: Makefile

 Log Message:
 Use EXPORT_SYMBOLS_LDFLAGS as suggested by joerg in PR pkg/37855.


 To generate a diff of this commit:
 cvs rdiff -u -r1.98 -r1.99 pkgsrc/comms/jpilot/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search