NetBSD Problem Report #37874

From martin@duskware.de  Fri Jan 25 21:49:45 2008
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (unknown [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 21F2A63BA67
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 25 Jan 2008 21:49:45 +0000 (UTC)
Message-Id: <20080125214927.4035633AC9@mail.duskware.de>
Date: Fri, 25 Jan 2008 22:49:27 +0100 (CET)
From: martin@duskware.de
Reply-To: martin@duskware.de
To: gnats-bugs@gnats.NetBSD.org
Subject: layout bug in sysinst menu
X-Send-Pr-Version: 3.95

>Number:         37874
>Category:       port-mac68k
>Synopsis:       layout bug in sysinst menu
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    hauke
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 25 21:50:00 +0000 2008
>Closed-Date:    Tue Aug 05 09:33:04 +0000 2008
>Last-Modified:  Tue Aug 05 09:33:04 +0000 2008
>Originator:     Martin Husemann
>Release:        NetBSD 4.0
>Organization:
>Environment:
System: not this
Architecture: mac68k
Machine: m68k
>Description:

When partitioning the disk during installation, the partioning menu does
not display the "x: Exit" option untill you go down with the cursor there,
since there is no space on the screen:

------------------------------------------------------------------------------

 Edit Disk Partition Map: The Map on the disk has been scanned for all
 user-level partitions, but only those usable by NetBSD are displayed.  The  
 partition table currently looks like:

 Part      start       size fstype use       mount point (name)
 ---- ---------- ---------- ------ --------- ------------------
 sd0d        192        512        unknown
 sd0e        704    2097152    HFS MacOS      (MacHDTitel)
 sd0a    2097856   15582584 4.2BSD Root      /
 sd0b   17680440     262144   swap




                      +----------------------------------+
                      | Choose your partition            |
                      |                                  |
                      | a: Select next partition         |
                      | b: Change selected partition     |
                      | c: Set mount point for partition |
                      | d: Split selected partition      |
                      | e: Fix selected partition        |
                      +>x: Exit--------------------------+
------------------------------------------------------------------------------


>How-To-Repeat:
s.a.
>Fix:
move the menu one line up?

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: port-mac68k-maintainer->hauke
Responsible-Changed-By: hauke@NetBSD.org
Responsible-Changed-When: Sat, 24 May 2008 20:10:17 +0000
Responsible-Changed-Why:
I'll take this one.


State-Changed-From-To: open->feedback
State-Changed-By: hauke@NetBSD.org
State-Changed-When: Sat, 24 May 2008 21:45:30 +0000
State-Changed-Why:
Does the layout change just committed fix your problem? Patch should apply easily to netbsd-4 sources.


From: Hauke Fath <hauke@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/37874 CVS commit: src/distrib/utils/sysinst/arch/mac68k
Date: Sat, 24 May 2008 21:42:52 +0000 (UTC)

 Module Name:	src
 Committed By:	hauke
 Date:		Sat May 24 21:42:52 UTC 2008

 Modified Files:
 	src/distrib/utils/sysinst/arch/mac68k: md.c menus.md.de menus.md.en
 	    menus.md.es menus.md.pl

 Log Message:
 Attempting to fix display problems of PR mac68k/37874

 (1) By moving the "Choose your partition" menu up one line, we gain two
 lines, since the scroll... message is gone.
 (2) With the mac68k MAXPARTITIONS == 8, we only need 7 lines for the
 partition table, which does not display the 'c' partition.

 After both changes, the display fits nicely on an 80x24 screen even
 for a full partition table. Should mac68k want to bump MAXPARTITIONS,
 though, the partition table needs to be scrollable.


 To generate a diff of this commit:
 cvs rdiff -r1.51 -r1.52 src/distrib/utils/sysinst/arch/mac68k/md.c
 cvs rdiff -r1.2 -r1.3 src/distrib/utils/sysinst/arch/mac68k/menus.md.de
 cvs rdiff -r1.20 -r1.21 src/distrib/utils/sysinst/arch/mac68k/menus.md.en
 cvs rdiff -r1.1 -r1.2 src/distrib/utils/sysinst/arch/mac68k/menus.md.es
 cvs rdiff -r1.7 -r1.8 src/distrib/utils/sysinst/arch/mac68k/menus.md.pl

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Martin Husemann <martin@duskware.de>
To: Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
Cc: gnats-bugs@NetBSD.org
Subject: Re: port-mac68k/37874: layout bug in sysinst menu
Date: Sun, 15 Jun 2008 13:33:34 +0200

 On Sat, May 24, 2008 at 11:36:30PM +0200, Hauke Fath wrote:
 > I have tried to reproduce the problem with -current as well as netbsd-4
 > sources, and couldn't. Can you give details about Macintosh model, screen
 > resolution, graphical console vs. serial console? And is what you sent in
 > the exact representation of what you saw on the screen? If yes, that would
 > hint at a general menuc quirk rather than a mac68k MD problem.

 I use a 660AV, and serial console to a 24x80 xterm. The display in the PR
 is the exact output in this xterm. The general quirk probably is menuc not
 coping with fixed menus overflowing the number of available rows - but
 that is just something that should not happen (tm).

 Your change fixed it properly (just tested again with a blank disk).

 Martin

State-Changed-From-To: feedback->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Tue, 05 Aug 2008 09:33:04 +0000
State-Changed-Why:
Fixed, thanks!


>Unformatted:

Home	PR Database Search