NetBSD Problem Report #39761

From www@NetBSD.org  Sat Oct 18 12:27:19 2008
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 5A35663BC49
	for <gnats-bugs@gnats.netbsd.org>; Sat, 18 Oct 2008 12:27:19 +0000 (UTC)
Message-Id: <20081018122719.18BDA63B93C@narn.NetBSD.org>
Date: Sat, 18 Oct 2008 12:27:19 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Header saframe.h is missing in /usr/include/m68k
X-Send-Pr-Version: www-1.0

>Number:         39761
>Category:       port-m68k
>Synopsis:       Header saframe.h is missing in /usr/include/m68k
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    port-m68k-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Oct 18 12:30:01 +0000 2008
>Closed-Date:    Sun Nov 15 00:24:59 +0000 2009
>Last-Modified:  Sun Nov 15 00:24:59 +0000 2009
>Originator:     Henning Petersen
>Release:        Netbsd-current
>Organization:
>Environment:
>Description:
Building Atari release with error,

#   compile  BOOT/sig_machdep.o
/usr/netbsd/tools.atari/bin/m68k--netbsdelf-gcc -m68020 -msoft-float -ffreestanding -fno-zero-initialized-in-bss -O2 -std=gnu99 -fno-strict-aliasing -Werror -Wall -Wno-main -Wno-format-zero-length -Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wno-unreachable-code -Wno-sign-compare -Wno-pointer-sign -Wno-attributes -Werror -Datari -I. -I/usr/test/src/sys/../common/include -I/usr/test/src/sys/arch -I/usr/test/src/sys -nostdinc -DM68030 -DPANICWAIT -DST_POOL_SIZE=22 -DTT_VIDEO -DFALCON_VIDEO -DDISKLABEL_NBDA -DDISKLABEL_AHDI -DMAXUSERS=16 -D_KERNEL -D_KERNEL_OPT -I/usr/test/src/sys/lib/libkern/../../../common/lib/libc/quad -I/usr/test/src/sys/lib/libkern/../../../common/lib/libc/string -I/usr/test/src/sys/lib/libkern/../../../common/lib/libc/arch/m68k/string -c /usr/test/src/sys/arch/m68k/m68k/sig_machdep.c
/usr/test/src/sys/arch/m68k/m68k/sig_machdep.c: In function 'cpu_upcall':
/usr/test/src/sys/arch/m68k/m68k/sig_machdep.c:247: error: storage size of 'sf' isn't known
/usr/test/src/sys/arch/m68k/m68k/sig_machdep.c:260: error: invalid use of undefined type 'struct saframe'
cc1: warnings being treated as errors
/usr/test/src/sys/arch/m68k/m68k/sig_machdep.c:247: warning: unused variable 'sf'

*** Failed target:  sig_machdep.o

Stop.

>How-To-Repeat:

>Fix:
diff -u -r1.38 sig_machdep.c
--- sys/arch/m68k/m68k/sig_machdep.c	15 Oct 2008 06:51:18 -0000	1.38
+++ sys/arch/m68k/m68k/sig_machdep.c	18 Oct 2008 09:02:28 -0000
@@ -102,6 +102,7 @@
 #include <machine/frame.h>

 #include <m68k/m68k.h>
+#include <m68k/saframe.h>

 extern short exframesize[];
 struct fpframe m68k_cached_fpu_idle_frame;


diff -u -r1.26 Makefile
--- sys/arch/m68k/include/Makefile	9 Feb 2007 21:55:05 -0000	1.26
+++ sys/arch/m68k/include/Makefile	18 Oct 2008 09:02:28 -0000
@@ -15,7 +15,7 @@
 	m68k.h math.h mcontext.h mutex.h \
 	param.h pmap_motorola.h pmc.h pcb.h proc.h profile.h \
 	psl.h pte_motorola.h ptrace.h \
-	reg.h rwlock.h setjmp.h signal.h stdarg.h sync_icache.h \
+	reg.h rwlock.h saframe.h setjmp.h signal.h stdarg.h sync_icache.h \
 	sysctl.h \
 	trap.h types.h \
 	varargs.h \


diff -u -r1.40 ad.m68k
--- distrib/sets/lists/comp/ad.m68k	22 Aug 2008 13:42:19 -0000	1.40
+++ distrib/sets/lists/comp/ad.m68k	18 Oct 2008 09:04:09 -0000
@@ -47,6 +47,7 @@
 ./usr/include/m68k/ptrace.h			comp-c-include
 ./usr/include/m68k/reg.h			comp-c-include
 ./usr/include/m68k/rwlock.h			comp-c-include
+./usr/include/m68k/saframe.h			comp-c-include
 ./usr/include/m68k/setjmp.h			comp-c-include
 ./usr/include/m68k/signal.h			comp-c-include
 ./usr/include/m68k/stdarg.h			comp-c-include

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->feedback
State-Changed-By: martin@NetBSD.org
State-Changed-When: Sat, 18 Oct 2008 13:41:51 +0000
State-Changed-Why:
Kernel compiles again, why do you think the header should be installed for
userland?


From: Martin Husemann <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/39761 CVS commit: src/sys/arch/m68k/m68k
Date: Sat, 18 Oct 2008 13:38:42 +0000 (UTC)

 Module Name:	src
 Committed By:	martin
 Date:		Sat Oct 18 13:38:42 UTC 2008

 Modified Files:
 	src/sys/arch/m68k/m68k: sig_machdep.c

 Log Message:
 Include saframe.h, fixes PR port-m68k/39761


 To generate a diff of this commit:
 cvs rdiff -r1.38 -r1.39 src/sys/arch/m68k/m68k/sig_machdep.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 15 Nov 2009 00:24:59 +0000
State-Changed-Why:
1-year feedback timeout


>Unformatted:

Home	PR Database Search