NetBSD Problem Report #39854

From darrenr@NetBSD.org  Sun Nov  2 15:41:41 2008
Return-Path: <darrenr@NetBSD.org>
Received: by narn.NetBSD.org (Postfix, from userid 1110)
	id 9D27863B88A; Sun,  2 Nov 2008 15:41:41 +0000 (UTC)
Message-Id: <20081102154141.9D27863B88A@narn.NetBSD.org>
Date: Sun,  2 Nov 2008 15:41:41 +0000 (UTC)
From: darrenr@NetBSD.org
Reply-To: darrenr@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: tcp_new_iss1 is used for both ipv4 and ipv6
X-Send-Pr-Version: 3.95

>Number:         39854
>Category:       kern
>Synopsis:       IPF: tcp_new_iss1 is used for both ipv4 and ipv6
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 02 15:45:00 +0000 2008
>Last-Modified:  Sun Feb 25 17:29:56 +0000 2018
>Originator:     Darren Reed
>Release:        NetBSD 4.0_STABLE
>Organization:
NetBSD
>Environment:


System: NetBSD narn.netbsd.org 4.0_STABLE NetBSD 4.0_STABLE (NBMAIL) #1: Fri Sep 5 16:31:35 UTC 2008 root@ADMIN:/usr/obj/sys/arch/i386/compile.i386/NBMAIL i386
Architecture: i386
Machine: i386
>Description:

In /sys/dist/ipf/netinet/ip_fil_netbsd.c, we find this code:
#ifdef INET
        return tcp_new_iss1((void *)&fin->fin_src, (void *)&fin->fin_dst,
                            fin->fin_sport, fin->fin_dport, asz, 0);
#else
        return ENOSYS;
#endif


...which is clearly wrong if we are to use sys/netinet/tcp_subr.c as
a guide - it calls tcp_new_iss1() for both ipv4 and ipv6. So clearly
the #ifdef's here need to vaporise... or change to be
#if defined(INET) || defined(INET6)
... but then it isn't clear why ipfilter would be in the kernel if
this was the case.

>How-To-Repeat:

>Fix:


>Release-Note:

>Audit-Trail:

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.43 2018/01/16 07:36:43 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.