NetBSD Problem Report #41784

From www@NetBSD.org  Sun Jul 26 13:30:01 2009
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 3CC0D63B8E9
	for <gnats-bugs@gnats.netbsd.org>; Sun, 26 Jul 2009 13:30:01 +0000 (UTC)
Message-Id: <20090726133000.A410E63B8DB@www.NetBSD.org>
Date: Sun, 26 Jul 2009 13:30:00 +0000 (UTC)
From: msporleder@gmail.com
Reply-To: msporleder@gmail.com
To: gnats-bugs@NetBSD.org
Subject: pkgsrc guide 15.2 should mention INSTALL_MAKE_FLAGS
X-Send-Pr-Version: www-1.0

>Number:         41784
>Category:       pkg
>Synopsis:       pkgsrc guide 15.2 should mention INSTALL_MAKE_FLAGS
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    mspo
>State:          closed
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 26 13:35:00 +0000 2009
>Closed-Date:    Fri May 12 07:17:45 +0000 2023
>Last-Modified:  Fri May 12 07:17:45 +0000 2023
>Originator:     Matthew Sporleder
>Release:        current
>Organization:
mspo.com
>Environment:
NetBSD 5.99.11
>Description:
Section 15.2 of the pkgsrc guide gives a good intro to handling config files when making a pkg, but fails to mention the following clearly:
the conf file needs to end up in +FILES of the installed pkg so that it's checked before deleting but the default config file should go into the examples/ hierarchy.

And also fails to mention the easiest way to make that happen:
INSTALL_MAKE_FLAGS+= ${MAKE_FLAGS} sysconfdir=${EGDIR:Q} can be added to the Makefile if EGDIR is defined as EGDIR= ${PREFIX}/share/examples/${PKGBASE}

And a good thing to add would be:
CONFIGURE_ARGS+=        --sysconfdir=${PKG_SYSCONFDIR:Q}/${PKGBASE}
MAKE_DIRS+=             ${PKG_SYSCONFDIR:Q}/${PKGBASE}

The directory must be made since INSTALL was overridden and will not make it automatically.  (but that's somewhat optional because you could just use PKG_SYSCONFDIR without the PKGBASE)
>How-To-Repeat:
visit http://www.netbsd.org/docs/pkgsrc/pkginstall.html
>Fix:
see description

>Release-Note:

>Audit-Trail:
[20110327 shattered] edited Environment: field

From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/41784: pkgsrc guide 15.2 should mention INSTALL_MAKE_FLAGS
Date: Mon, 27 Jul 2009 08:59:36 +0900

 On Sun, 26 Jul 2009 22:35:00 +0900, <msporleder@gmail.com> wrote:

 > And a good thing to add would be:
 > CONFIGURE_ARGS+=        --sysconfdir=${PKG_SYSCONFDIR:Q}/${PKGBASE}
 > MAKE_DIRS+=             ${PKG_SYSCONFDIR:Q}/${PKGBASE}

 For this, followings should be used instead:
 PKG_SYSCONFSUBDIR=	${PKGBASE}
 CONFIGURE_ARGS+=	--sysconfdir=${PKG_SYSCONFDIR}

 -- 
 "Of course I love NetBSD":-)
 OBATA Akio / obache@NetBSD.org

Responsible-Changed-From-To: pkg-manager->mspo
Responsible-Changed-By: dholland@NetBSD.org
Responsible-Changed-When: Thu, 18 Jun 2015 07:16:16 +0000
Responsible-Changed-Why:
submitter can commit his own patches now :-)


From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/41784 CVS commit: pkgsrc/doc/guide/files
Date: Fri, 12 May 2023 07:13:58 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Fri May 12 07:13:58 UTC 2023

 Modified Files:
 	pkgsrc/doc/guide/files: pkginstall.xml

 Log Message:
 guide: rework sections 20.1-2 about the config files framework

 Prompted by PR 41784 (from mspo) and includes the suggestion there,
 but broader because the prior structure was inadequate to the task.


 To generate a diff of this commit:
 cvs rdiff -u -r1.22 -r1.23 pkgsrc/doc/guide/files/pkginstall.xml

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Fri, 12 May 2023 07:17:45 +0000
State-Changed-Why:
I added this (and some other stuff) -- please review at your leisure :-)

(it's now section 20.2)


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: gnats-precook-prs,v 1.4 2018/12/21 14:20:20 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.