NetBSD Problem Report #41875

From Manuel.Bouyer@lip6.fr  Wed Aug 12 10:45:14 2009
Return-Path: <Manuel.Bouyer@lip6.fr>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 9513663C270
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 12 Aug 2009 10:45:14 +0000 (UTC)
Message-Id: <20090812104504.D7FB34F6C@disco.asim.lip6.fr>
Date: Wed, 12 Aug 2009 12:45:04 +0200 (MEST)
From: Manuel.Bouyer@lip6.fr
Reply-To: Manuel.Bouyer@lip6.fr
To: gnats-bugs@gnats.NetBSD.org
Subject: pax_aslr_elf() use wrong lsb number
X-Send-Pr-Version: 3.95

>Number:         41875
>Category:       kern
>Synopsis:       pax_aslr_elf() use wrong lsb number
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 12 10:50:00 +0000 2009
>Originator:     Manuel Bouyer
>Release:        NetBSD 5.0_STABLE
>Organization:
>Environment:
System: NetBSD disco 5.0_STABLE NetBSD 5.0_STABLE (DISCO) #3: Fri Aug 7 08:59:42 MEST 2009 bouyer@disco:/home/bouyer/src-5/src/sys/arch/i386/compile/obj/DISCO i386
Architecture: i386
Machine: i386
>Description:
	In pax_aslr_elf() we read:

        if (pax_align == 0)
                pax_align = PGSHIFT;
#ifdef DEBUG_ASLR
        uprintf("r=0x%x a=0x%x p=0x%x Delta=0x%lx\n", r,
            ilog2(pax_align), PGSHIFT, PAX_ASLR_DELTA(r,
                ilog2(pax_align), PAX_ASLR_DELTA_EXEC_LEN));
#endif  
        pax_offset = ELF_TRUNC(PAX_ASLR_DELTA(r,
            ilog2(pax_align), PAX_ASLR_DELTA_EXEC_LEN), pax_align);

	PAX_ASLR_DELTA() expects a number of bits so should get
	pax_align, not ilog2(pax_align).
	ELF_TRUNC() expects a size in bytes, so should get (1 << pax_align)
	not pax_align.

>How-To-Repeat:
	code inspection
>Fix:
	change
		pax_align = PGSHIFT;
	to
		pax_align = NBPG;
	maybe ?

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.