NetBSD Problem Report #42266

From Ephaeton@gmx.net  Wed Nov  4 16:46:13 2009
Return-Path: <Ephaeton@gmx.net>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 26EAB63B844
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  4 Nov 2009 16:46:13 +0000 (UTC)
Message-Id: <20091104164605.CF19D13645@agamemnon.entropie.local>
Date: Wed,  4 Nov 2009 11:46:05 -0500 (EST)
From: Ephaeton@gmx.net
Reply-To: Ephaeton@gmx.net
To: gnats-bugs@gnats.NetBSD.org
Subject: (make update) if uninstalling fails, update continues
X-Send-Pr-Version: 3.95

>Number:         42266
>Category:       pkg
>Synopsis:       (make update) if uninstalling fails, update continues
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Nov 04 16:50:00 +0000 2009
>Last-Modified:  Thu Nov 05 08:45:01 +0000 2009
>Originator:     Martin S. Weber
>Release:        NetBSD 5.0_STABLE
>Organization:

>Environment:


System: NetBSD agamemnon.entropie.local 5.0_STABLE NetBSD 5.0_STABLE (AGAMEMNON5) #0: Sat Jun 27 14:44:07 EDT 2009 root@agamemnon.entropie.local:/home/netbsd/obj/sys/arch/i386/compile/AGAMEMNON5 i386
Architecture: i386
Machine: i386
>Description:

I think the following log says it all. I would've expected an "exit 1" after
the error message of pkg_delete (see exclamation marks). 
Instead the modified file got overwritten.

<pkg_comp> # make update
if /usr/pkg/sbin/pkg_info -K /var/db/pkg -qe "pkg_comp-[0-9]*"; then  /usr/pkg/sbin/pkg_info -K /var/db/pkg -qr "pkg_comp-[0-9]*" > /home/netbsd/pkgsrc/pkgtools/pkg_comp/work/.DLIST;  else  /usr/bin/touch /home/netbsd/pkgsrc/pkgtools/pkg_comp/work/.DLIST;  fi
===> Deinstalling for pkg_comp-1.31
!! Running /usr/pkg/sbin/pkg_delete -K /var/db/pkg -r pkg_comp-1.31
!!! original MD5 checksum failed, not deleting: /usr/pkg/sbin/pkg_comp
!!! pkg_delete: couldn't entirely delete package `pkg_comp-1.31'
===> Checking for vulnerabilities in pkg_comp-1.31
===> Installing dependencies for pkg_comp-1.31
===> Overriding tools for pkg_comp-1.31
===> Extracting for pkg_comp-1.31
===> Patching for pkg_comp-1.31
===> Creating toolchain wrappers for pkg_comp-1.31
===> Installing for pkg_comp-1.31
=> Creating installation directories
/usr/bin/install -c -o root -g wheel -m 555 /home/netbsd/pkgsrc/pkgtools/pkg_comp/files/pkg_comp.sh /usr/pkg/sbin/pkg_comp
/usr/bin/install -c -o root -g wheel -m 444 /home/netbsd/pkgsrc/pkgtools/pkg_comp/files/pkg_comp.8 /usr/pkg/man/man8/pkg_comp.8
=> Automatic manual page handling
=> Registering installation for pkg_comp-1.31
if /usr/pkg/sbin/pkg_info -K /var/db/pkg -qe "pkg_comp-[0-9]*"; then  /usr/pkg/sbin/pkg_info -K /var/db/pkg -qr "pkg_comp-[0-9]*" > /home/netbsd/pkgsrc/pkgtools/pkg_comp/work/.DLIST;  else  /usr/bin/touch /home/netbsd/pkgsrc/pkgtools/pkg_comp/work/.DLIST;  fi
===> Cleaning for pkg_comp-1.31

>How-To-Repeat:
	install some shell-script package.
	change the shell script.
	make update the shell-script package.

>Fix:

line 46 of mk/flavor/pkg/deinstall.mk [rev 1.10] reads:
 ${PKG_DELETE} ${_PKG_ARGS_DEINSTALL} "$$found" || ${TRUE} ; \
The "|| ${TRUE}" might be removed, but I'm not sure about the impact
it would have on pkgsrc as a whole.

>Release-Note:

>Audit-Trail:
From: "Martin S. Weber" <Ephaeton@gmx.net>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/42266: (make update) if uninstalling fails, update continues
Date: Wed, 4 Nov 2009 12:00:45 -0500

 On Wed, Nov 04, 2009 at 04:50:00PM +0000, gnats-admin@netbsd.org wrote:
 > 	Note: There was a bad value `' for the field `Confidential'.
 > 	It was set to the default value of `yes'.
 > 

 Argh. This is NOT confidential! Sorry!

 -Martin

From: Alan Barrett <apb@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: "Martin S. Weber" <Ephaeton@gmx.net>
Subject: Re: pkg/42266: (make update) if uninstalling fails, update
 continues
Date: Thu, 5 Nov 2009 10:40:04 +0200

 On Wed, 04 Nov 2009, Martin S. Weber wrote:
 >  On Wed, Nov 04, 2009 at 04:50:00PM +0000, gnats-admin@netbsd.org wrote:
 >  > 	Note: There was a bad value `' for the field `Confidential'.
 >  > 	It was set to the default value of `yes'.
 >  > 
 >  
 >  Argh. This is NOT confidential! Sorry!

 I have changed it to "Confidential: no".

 --apb (Alan Barrett)

>Unformatted:


 	pkgsrc-2009Q3

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.