NetBSD Problem Report #42524
From www@NetBSD.org Sun Dec 27 08:18:09 2009
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
by www.NetBSD.org (Postfix) with ESMTP id 58CF863C37E
for <gnats-bugs@gnats.NetBSD.org>; Sun, 27 Dec 2009 08:18:09 +0000 (UTC)
Message-Id: <20091227081809.1E4DF63B844@www.NetBSD.org>
Date: Sun, 27 Dec 2009 08:18:09 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Missing parenthesis in sys/arch/sun2/dev/consinit.c .
X-Send-Pr-Version: www-1.0
>Number: 42524
>Category: port-sun2
>Synopsis: Missing parenthesis in sys/arch/sun2/dev/consinit.c .
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: port-sun2-maintainer
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sun Dec 27 08:20:00 +0000 2009
>Closed-Date: Sun Dec 27 08:42:50 +0000 2009
>Last-Modified: Sun Dec 27 08:45:01 +0000 2009
>Originator: Henning Petersen
>Release:
>Organization:
>Environment:
>Description:
Missing parenthesis found with cppcheck.
>How-To-Repeat:
>Fix:
diff -u -r1.6 consinit.c
--- sys/arch/sun2/dev/consinit.c 11 Dec 2005 12:19:16 -0000 1.6
+++ sys/arch/sun2/dev/consinit.c 1 Dec 2009 09:15:02 -0000
@@ -271,7 +271,7 @@
DBPRINT(("stdout package = %x\r\n", prom_stdout_node));
DBPRINT(("buffer @ %p\r\n", buffer));
- if (prom_stdin_node && prom_node_has_property(prom_stdin_node, "keyboard") {
+ if (prom_stdin_node && prom_node_has_property(prom_stdin_node, "keyboard")) {
#if NKBD == 0
printf("cninit: kdb/display not configured\n");
#endif
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Sun, 27 Dec 2009 17:42:50 +0900
State-Changed-Why:
Fixed, thanks.
From: Izumi Tsutsui <tsutsui@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/42524 CVS commit: src/sys/arch/sun2/dev
Date: Sun, 27 Dec 2009 08:41:51 +0000
Module Name: src
Committed By: tsutsui
Date: Sun Dec 27 08:41:50 UTC 2009
Modified Files:
src/sys/arch/sun2/dev: consinit.c
Log Message:
Fix missing parenthesis in #ifdef notyet block. PR port-sun2/42524
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/arch/sun2/dev/consinit.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.