NetBSD Problem Report #42529

From www@NetBSD.org  Sun Dec 27 08:44:39 2009
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 1665063C428
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 27 Dec 2009 08:44:39 +0000 (UTC)
Message-Id: <20091227084438.DEDDC63C3A9@www.NetBSD.org>
Date: Sun, 27 Dec 2009 08:44:38 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Delete  parenthesies in sys/arch/next68k/dev/nextdma.c .
X-Send-Pr-Version: www-1.0

>Number:         42529
>Category:       port-next68k
>Synopsis:       Delete  parenthesies in sys/arch/next68k/dev/nextdma.c .
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-next68k-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Dec 27 08:45:03 +0000 2009
>Closed-Date:    Sun Jun 06 02:52:02 +0000 2010
>Last-Modified:  Sun Jun 06 02:55:01 +0000 2010
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Too many parentheses found with cppcheck.
>How-To-Repeat:

>Fix:
diff -u -r1.45 nextdma.c
--- sys/arch/next68k/dev/nextdma.c	5 Nov 2009 18:11:09 -0000	1.45
+++ sys/arch/next68k/dev/nextdma.c	1 Dec 2009 11:46:13 -0000
@@ -209,7 +209,7 @@
 		char sbuf[256];

 		snprintb(sbuf, sizeof(sbuf), NEXT_INTR_BITS,
-		    (NEXT_I_BIT(nsc->sc_chan->nd_intr));
+		    NEXT_I_BIT(nsc->sc_chan->nd_intr));
 		printf("DMA init ipl (%ld) intr(0x%s)\n",
 			NEXT_I_IPL(nsc->sc_chan->nd_intr), sbuf);
 	}
@@ -493,7 +493,7 @@
 		char sbuf[256];

 		snprintb(sbuf, sizeof(sbuf), NEXT_INTR_BITS,
-		    (NEXT_I_BIT(nsc->sc_chan->nd_intr));
+		    NEXT_I_BIT(nsc->sc_chan->nd_intr));
 		printf("DMA interrupt ipl (%ld) intr(0x%s)\n",
 		       NEXT_I_IPL(nsc->sc_chan->nd_intr), sbuf);
 	}
@@ -906,7 +906,7 @@
 	printf("NDMAP: dd->dd_stop         = 0x%08lx\n", dd_stop);

 	snprintb(sbuf, sizeof(sbuf), NEXT_INTR_BITS,
-	    (NEXT_I_BIT(nsc->sc_chan->nd_intr)));
+	    NEXT_I_BIT(nsc->sc_chan->nd_intr));
 	printf("NDMAP: interrupt ipl (%ld) intr(0x%s)\n",
 			NEXT_I_IPL(nsc->sc_chan->nd_intr), sbuf);
 }

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: mrg@NetBSD.org
State-Changed-When: Sun, 06 Jun 2010 02:52:02 +0000
State-Changed-Why:
i commited the patch; it was sane.


From: matthew green <mrg@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/42529 CVS commit: src/sys/arch/next68k/dev
Date: Sun, 6 Jun 2010 02:51:46 +0000

 Module Name:	src
 Committed By:	mrg
 Date:		Sun Jun  6 02:51:46 UTC 2010

 Modified Files:
 	src/sys/arch/next68k/dev: nextdma.c

 Log Message:
 fix some errors in debug code, found by henning petersen in PR#42529.


 To generate a diff of this commit:
 cvs rdiff -u -r1.46 -r1.47 src/sys/arch/next68k/dev/nextdma.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.