NetBSD Problem Report #42633
From www@NetBSD.org Sun Jan 17 15:15:23 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
by www.NetBSD.org (Postfix) with ESMTP id 9684663B886
for <gnats-bugs@gnats.NetBSD.org>; Sun, 17 Jan 2010 15:15:23 +0000 (UTC)
Message-Id: <20100117151523.24AC263B86D@www.NetBSD.org>
Date: Sun, 17 Jan 2010 15:15:23 +0000 (UTC)
From: uwe_debbug@arcor.de
Reply-To: uwe_debbug@arcor.de
To: gnats-bugs@NetBSD.org
Subject: uhmodem: suspend/resume impossible with built-in modem
X-Send-Pr-Version: www-1.0
>Number: 42633
>Category: kern
>Synopsis: uhmodem: suspend/resume impossible with built-in modem
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: kern-bug-people
>State: closed
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Sun Jan 17 15:20:00 +0000 2010
>Closed-Date: Mon May 27 03:08:29 +0000 2019
>Last-Modified: Mon May 27 03:10:01 +0000 2019
>Originator: Uwe Krüger
>Release: netbsd-5 (snapshot from Jan 14th 2010)
>Organization:
>Environment:
NetBSD eeepc 5.0_STABLE NetBSD 5.0_STABLE (UWE) #1: Sun Jan 17 14:50:10 UTC 2010 root@eeepc:/usr/src/sys/arch/i386/compile/UWE i386
>Description:
On an eeepc-901go (with built-in HUAWEI HSDPA modem) suspend/resume doesn't work. The following error messages are printed:
Jan 17 14:00:31 eeepc /netbsd: acpi0: entering state 3
Jan 17 14:00:31 eeepc /netbsd: Devices without power management support: uhmodem0
Jan 17 14:00:31 eeepc /netbsd: acpi0: aborting suspend
>How-To-Repeat:
Try to enter suspend mode on an eeepc 901go. (You should deactivate the wired network in the BIOS since the built-in ale-Device causes various proplems - but that's another story...)
>Fix:
Addind a dummy power management registration to the uhmodem driver fixes the problem:
--- sys/dev/usb/uhmodem.c.orig 2010-01-17 14:45:15.000000000 +0000
+++ sys/dev/usb/uhmodem.c 2010-01-17 14:48:52.000000000 +0000
@@ -369,6 +369,9 @@
usbd_add_drv_event(USB_EVENT_DRIVER_ATTACH, sc->sc_ubsa.sc_udev,
USBDEV(sc->sc_ubsa.sc_dev));
+ if (!pmf_device_register(self, NULL, NULL))
+ aprint_error_dev(self, "couldn't establish power handler\n");
+
USB_ATTACH_SUCCESS_RETURN;
error:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Mon, 27 May 2019 03:08:29 +0000
State-Changed-Why:
Applied, thanks!
From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/42633 CVS commit: src/sys/dev/usb
Date: Mon, 27 May 2019 03:08:13 +0000
Module Name: src
Committed By: maya
Date: Mon May 27 03:08:13 UTC 2019
Modified Files:
src/sys/dev/usb: uhmodem.c
Log Message:
Claim suspend support.
From Uwe Krüger in PR kern/42633
To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/sys/dev/usb/uhmodem.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.43 2018/01/16 07:36:43 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.