NetBSD Problem Report #42717

From www@NetBSD.org  Tue Feb  2 09:41:49 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id A7DF163C463
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  2 Feb 2010 09:41:49 +0000 (UTC)
Message-Id: <20100202094149.782C463B9FC@www.NetBSD.org>
Date: Tue,  2 Feb 2010 09:41:49 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Buffer overrun  in clock.c
X-Send-Pr-Version: www-1.0

>Number:         42717
>Category:       port-atari
>Synopsis:       Buffer overrun  in clock.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-atari-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Feb 02 09:45:00 +0000 2010
>Closed-Date:    Sat Jun 30 12:44:21 +0000 2012
>Last-Modified:  Sat Jun 30 12:45:01 +0000 2012
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Buffer overrun found by cppcheck.
>How-To-Repeat:

>Fix:
diff -u -r1.50 clock.c
--- sys/arch/atari/dev/clock.c	23 Aug 2009 13:46:48 -0000	1.50
+++ sys/arch/atari/dev/clock.c	2 Feb 2010 09:01:15 -0000
@@ -549,7 +549,7 @@
 	MC146818_GETTOD(RTC, &clkregs);
 	splx(s);

-	sprintf(buffer, "%4d%02d%02d%02d%02d.%02d\n",
+	sprintf(buffer, "%4d%02d%02d%02d%02d.%02d",
 	    clkregs[MC_YEAR] + GEMSTARTOFTIME,
 	    clkregs[MC_MONTH], clkregs[MC_DOM],
 	    clkregs[MC_HOUR], clkregs[MC_MIN], clkregs[MC_SEC]);

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Sat, 30 Jun 2012 21:44:21 +0900
State-Changed-Why:
Fixed, thanks.


From: "Izumi Tsutsui" <tsutsui@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/42717 CVS commit: src/sys/arch/atari/dev
Date: Sat, 30 Jun 2012 12:42:38 +0000

 Module Name:	src
 Committed By:	tsutsui
 Date:		Sat Jun 30 12:42:37 UTC 2012

 Modified Files:
 	src/sys/arch/atari/dev: clock.c

 Log Message:
 Fix buffer overrun (off by one). PR port-atari/42717


 To generate a diff of this commit:
 cvs rdiff -u -r1.53 -r1.54 src/sys/arch/atari/dev/clock.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search