NetBSD Problem Report #42728

From www@NetBSD.org  Wed Feb  3 13:28:13 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 6918A63B9FC
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  3 Feb 2010 13:28:13 +0000 (UTC)
Message-Id: <20100203132812.D3ECA63B886@www.NetBSD.org>
Date: Wed,  3 Feb 2010 13:28:12 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Missing parenthesis in sys/arch/arm/arm32/fault.c
X-Send-Pr-Version: www-1.0

>Number:         42728
>Category:       port-arm32
>Synopsis:       Missing parenthesis in sys/arch/arm/arm32/fault.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-arm32-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Feb 03 13:30:00 +0000 2010
>Closed-Date:    Wed Feb 03 13:51:23 +0000 2010
>Last-Modified:  Wed Feb 03 13:55:00 +0000 2010
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Missing parenthesis in sys/arch/arm/arm32/fault.c found by cppcheck.
>How-To-Repeat:

>Fix:
diff -u -r1.74 fault.c
--- sys/arch/arm/arm32/fault.c	5 Jan 2010 13:14:55 -0000	1.74
+++ sys/arch/arm/arm32/fault.c	3 Feb 2010 12:57:26 -0000
@@ -740,8 +740,8 @@
 #ifdef THUMB_CODE
 	if (tf->tf_spsr & PSR_T_bit) {
 		printf("pc = 0x%08x, opcode 0x%04x, 0x%04x, insn = ",
-		    tf->tf_pc, *((u_int16 *)(tf->tf_pc & ~1),
-		    *((u_int16 *)((tf->tf_pc + 2) & ~1));
+		    tf->tf_pc, *((u_int16 *)(tf->tf_pc & ~1)),
+		    *((u_int16 *)((tf->tf_pc + 2) & ~1)));
 	}
 	else
 #endif

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Wed, 03 Feb 2010 13:51:23 +0000
State-Changed-Why:
Fixed, thanks.


From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/42728 CVS commit: src/sys/arch/arm/arm32
Date: Wed, 3 Feb 2010 13:51:00 +0000

 Module Name:	src
 Committed By:	wiz
 Date:		Wed Feb  3 13:51:00 UTC 2010

 Modified Files:
 	src/sys/arch/arm/arm32: fault.c

 Log Message:
 Add missing parentheses. Found by cppcheck, reported by
 Henning Petersen in PR 42728.


 To generate a diff of this commit:
 cvs rdiff -u -r1.74 -r1.75 src/sys/arch/arm/arm32/fault.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search