NetBSD Problem Report #42732

From www@NetBSD.org  Wed Feb  3 13:42:04 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id CFFAD63B9FC
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  3 Feb 2010 13:42:04 +0000 (UTC)
Message-Id: <20100203134204.9AD4163B886@www.NetBSD.org>
Date: Wed,  3 Feb 2010 13:42:04 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Delete  parenthesies in sys/compat/linux/arch/i386/linux_machdep.c
X-Send-Pr-Version: www-1.0

>Number:         42732
>Category:       port-i386
>Synopsis:       Delete  parenthesies in sys/compat/linux/arch/i386/linux_machdep.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-i386-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Feb 03 13:45:00 +0000 2010
>Closed-Date:    Wed Feb 03 13:52:07 +0000 2010
>Last-Modified:  Wed Feb 03 13:52:07 +0000 2010
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Delete  parenthesies in sys/compat/linux/arch/i386/linux_machdep.c found by cppcheck.
>How-To-Repeat:

>Fix:
diff -u -r1.146 linux_machdep.c
--- sys/compat/linux/arch/i386/linux_machdep.c	23 Nov 2009 00:46:06 -0000	1.146
+++ sys/compat/linux/arch/i386/linux_machdep.c	1 Dec 2009 09:41:26 -0000
@@ -673,7 +673,7 @@
 		return linux_write_ldt(l, (const void *)uap, 1);
 	case 2:
 #ifdef notyet
-		return (linux_read_default_ldt(l, (const void *)uap, retval);
+		return linux_read_default_ldt(l, (const void *)uap, retval);
 #else
 		return (ENOSYS);
 #endif

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/42732 CVS commit: src/sys/compat/linux/arch/i386
Date: Wed, 3 Feb 2010 13:48:53 +0000

 Module Name:	src
 Committed By:	wiz
 Date:		Wed Feb  3 13:48:53 UTC 2010

 Modified Files:
 	src/sys/compat/linux/arch/i386: linux_machdep.c

 Log Message:
 Remove extra parenthesis. Found by cppcheck, reported by
 Henning Petersen in PR 42732.


 To generate a diff of this commit:
 cvs rdiff -u -r1.147 -r1.148 src/sys/compat/linux/arch/i386/linux_machdep.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Wed, 03 Feb 2010 13:52:07 +0000
State-Changed-Why:
Fixed, thanks.


>Unformatted:

Home	PR Database Search