NetBSD Problem Report #42855

From www@NetBSD.org  Sat Feb 20 20:53:23 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 2EA1C63C47B
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 20 Feb 2010 20:53:23 +0000 (UTC)
Message-Id: <20100220205322.D7BC763C47A@www.NetBSD.org>
Date: Sat, 20 Feb 2010 20:53:22 +0000 (UTC)
From: demelier.david@gmail.com
Reply-To: demelier.david@gmail.com
To: gnats-bugs@NetBSD.org
Subject: devel/libgsf without gnome
X-Send-Pr-Version: www-1.0

>Number:         42855
>Category:       pkg
>Synopsis:       devel/libgsf without gnome
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    tonio
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Feb 20 20:55:00 +0000 2010
>Closed-Date:    Mon Dec 29 04:39:33 +0000 2014
>Last-Modified:  Mon Dec 29 20:55:00 +0000 2014
>Originator:     Demelier David
>Release:        NetBSD-5
>Organization:
>Environment:
NetBSD Abricot.malikania.org 5.0_STABLE NetBSD 5.0_STABLE (Abricot 0.2) #1: Fri Feb 12 13:38:30 CET 2010  root@Abricot.malikania.org:/usr/obj/sys/arch/i386/compile/Abricot i386

>Description:
Because libgsf can also works without some gnome dependencies I made this little patch to remove some gnome dependencies.

As you can see, the ./configure script handles automatically if gconftool is not found, so the optional gconf dependency can be safely removed.

checking for gconftool-2... no
configure: WARNING: thumbnailer will not be built, unable to find gconftool-2



>How-To-Repeat:

>Fix:
--- Makefile.orig	2010-02-20 21:35:53.000000000 +0100
+++ Makefile	2010-02-20 21:42:20.000000000 +0100
@@ -25,14 +25,10 @@

 CONFIGURE_ARGS+=	--without-python

-# XXX workaround for missing substitution in configure
-MAKE_ENV+=	GCONF2_SCHEMAS_DIR=${GCONF_SCHEMAS_DIR}
-
-GCONF_SCHEMAS=	gsf-office-thumbnailer.schemas
+.include "options.mk"

 .include "../../archivers/bzip2/buildlink3.mk"
 .include "../../devel/glib2/buildlink3.mk"
 .include "../../devel/zlib/buildlink3.mk"
 .include "../../textproc/libxml2/buildlink3.mk"
-.include "../../devel/GConf/schemas.mk"
 .include "../../mk/bsd.pkg.mk"
--- PLIST.orig	2010-02-20 21:47:01.000000000 +0100
+++ PLIST	2010-02-20 21:46:55.000000000 +0100
@@ -1,6 +1,6 @@
 @comment $NetBSD: PLIST,v 1.28 2010/02/16 13:29:26 wiz Exp $
 bin/gsf
-bin/gsf-office-thumbnailer
+${PLIST.gnome}bin/gsf-office-thumbnailer
 bin/gsf-vba-dump
 include/libgsf-1/gsf/gsf-blob.h
 include/libgsf-1/gsf/gsf-clip-data.h
@@ -55,7 +55,7 @@
 man/man1/gsf-office-thumbnailer.1
 man/man1/gsf-vba-dump.1
 man/man1/gsf.1
-share/gconf/schemas/gsf-office-thumbnailer.schemas
+${PLIST.gnome}share/gconf/schemas/gsf-office-thumbnailer.schemas
 share/gtk-doc/html/gsf/GsfClipData.html
 share/gtk-doc/html/gsf/api.html
 share/gtk-doc/html/gsf/dependencies.html
--- /dev/null	2010-02-20 21:48:45.000000000 +0100
+++ options.mk	2010-02-20 21:42:03.000000000 +0100
@@ -0,0 +1,14 @@
+PKG_OPTIONS_VAR=	PKG_OPTIONS.libgsf
+PKG_SUPPORTED_OPTIONS=	gnome
+PKG_SUGGESTED_OPTIONS=	gnome
+
+.include "../../mk/bsd.options.mk"
+
+PLIST_VARS+= gnome
+
+.if !empty(PKG_OPTIONS:Mgnome)
+.include "../../devel/GConf/schemas.mk"
+GCONF_SCHEMAS=  gsf-office-thumbnailer.schemas
+MAKE_ENV+=  GCONF2_SCHEMAS_DIR=${GCONF_SCHEMAS_DIR}
+PLIST.gnome=	yes
+.endif

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->tonio
Responsible-Changed-By: tonio@NetBSD.org
Responsible-Changed-When: Sat, 20 Feb 2010 21:23:22 +0000
Responsible-Changed-Why:
I will handle it.


From: Patrick Welche <prlw1@cam.ac.uk>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/42855
Date: Sun, 28 Dec 2014 22:50:22 +0000

 Since

 commit bc2b3e081a9cb2f019a18c7896194d62eb5258ce
 Author: Morten Welinder <terra@gnome.org>
 Date:   Wed Dec 7 16:46:36 2011 -0500

     thumbnailer: new installation method

     From: Vincent Untz <vuntz@gnome.org>
     Date: Thu, 26 May 2011 22:19:09 +0200
     Subject: [PATCH] Register thumbnailer the new way

     We now need a .thumbnailer file in $(datadir)/thumbnailers. This also
     means we don't need the gconf dependency anymore.

     https://bugzilla.gnome.org/show_bug.cgi?id=651187

 libgsf no longer depends on GConf, so I think this PR has expired.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 29 Dec 2014 04:39:33 +0000
State-Changed-Why:
Obsoleted by linux churn.


From: David Demelier <demelier.david@gmail.com>
To: gnats-bugs@netbsd.org
Cc: dholland@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org, 
	tonio@netbsd.org
Subject: Re: pkg/42855 (devel/libgsf without gnome)
Date: Mon, 29 Dec 2014 12:36:10 +0100

 --f46d0443066ef2ec74050b594781
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable

 Le 29 d=C3=A9c. 2014 05:39, <dholland@netbsd.org> a =C3=A9crit :
 >
 > Synopsis: devel/libgsf without gnome
 >
 > State-Changed-From-To: open->closed
 > State-Changed-By: dholland@NetBSD.org
 > State-Changed-When: Mon, 29 Dec 2014 04:39:33 +0000
 > State-Changed-Why:
 > Obsoleted by linux churn.
 >

 This is what I love with BSD communities, you send a patch/PR and you get a
 response three or four years later :-).

 --f46d0443066ef2ec74050b594781
 Content-Type: text/html; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable

 <p dir=3D"ltr">Le 29 d=C3=A9c. 2014 05:39, &lt;<a href=3D"mailto:dholland@n=
 etbsd.org">dholland@netbsd.org</a>&gt; a =C3=A9crit :<br>
 &gt;<br>
 &gt; Synopsis: devel/libgsf without gnome<br>
 &gt;<br>
 &gt; State-Changed-From-To: open-&gt;closed<br>
 &gt; State-Changed-By: dholland@NetBSD.org<br>
 &gt; State-Changed-When: Mon, 29 Dec 2014 04:39:33 +0000<br>
 &gt; State-Changed-Why:<br>
 &gt; Obsoleted by linux churn.<br>
 &gt;</p>
 <p dir=3D"ltr">This is what I love with BSD communities, you send a patch/P=
 R and you get a response three or four years later :-).</p>

 --f46d0443066ef2ec74050b594781--

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/42855 (devel/libgsf without gnome)
Date: Mon, 29 Dec 2014 20:53:23 +0000

 On Mon, Dec 29, 2014 at 12:36:10PM +0100, David Demelier wrote:
  > This is what I love with BSD communities, you send a patch/PR and you get a
  > response three or four years later :-).

 Well... I've been trying to do a bit better than that, but haven't
 really been succeeding lately.

 Better than losing the report, though.

 -- 
 David A. Holland
 dholland@netbsd.org

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.