NetBSD Problem Report #42953

From greywolf@starwolf.com  Wed Mar 10 23:54:53 2010
Return-Path: <greywolf@starwolf.com>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 1F40B63B873
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 10 Mar 2010 23:54:53 +0000 (UTC)
Message-Id: <201003102354.o2ANsqM2025972@lothlorien.starwolf.com>
Date: Wed, 10 Mar 2010 15:54:52 -0800 (PST)
From: greywolf@starwolf.com
Reply-To: greywolf@starwolf.com
To: gnats-bugs@gnats.NetBSD.org
Subject: restore reports "too low or too high" incorrectly
X-Send-Pr-Version: 3.95

>Number:         42953
>Category:       bin
>Synopsis:       restore reports "too low or too high" incorrectly
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 10 23:55:00 +0000 2010
>Originator:     The Grey Wolf
>Release:        NetBSD 5.0_RC1 [sources from -current as of this report]
>Organization:
Random Spherical Collisions
>Environment:


System: NetBSD lothlorien.starwolf.com 5.0_RC1 NetBSD 5.0_RC1 (GENERIC) #0: Wed Jan 28 10:59:04 PST 2009 builds@wb25:/home/builds/ab/netbsd-5/i386/200901280002Z-obj/home/builds/ab/netbsd-5/src/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
	When restoring from a dump whose header date precedes the last
	restore-from date in the restoresymtable, it incorrectly prints
	out "Incremental dump too high".  The reverse case, obviously, is
	also true.
>How-To-Repeat:
	[ back up /etc/dumpdates before proceeding ]
	[ do not do this in the root directory. ]
	# dump 0auf /path-with-space/root-0.fsd /
	# dump 4auf /path-with-space/root-4.fsd /
	# dump 8auf /path-with-space/root-8.fsd /
	# dump 9auf /path-with-space/root-9.fsd /
	# cd /path-with-space
	# mkdir test
	# cd test
	# restore rf ../root-0.fsd
	# restore rf ../root-8.fsd
	Incremental dump too low
	# restore rf ../root-4.fsd
	# restore rf ../root-4.fsd
	Incremental dump too high
	# : it seems to me that if you are restoring from a postdate,
	# : it should say too high, not too low.
	# : The thought logic used in the decision of which message to print
	# : confuses me.
>Fix:
--- symtab.c.orig	2010-03-10 15:51:10.000000000 -0800
+++ symtab.c	2010-03-10 15:14:16.000000000 -0800
@@ -579,7 +579,7 @@
 		 * the next incremental tape
 		 */
 		if (hdr.dumpdate != dumptime) {
-			if (hdr.dumpdate < dumptime)
+			if (hdr.dumpdate >= dumptime)
 				fprintf(stderr, "Incremental tape too low\n");
 			else
 				fprintf(stderr, "Incremental tape too high\n");

>Unformatted:

Home	PR Database Search