NetBSD Problem Report #44890

From www@NetBSD.org  Thu Apr 21 06:39:17 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 10A2F63C37B
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 21 Apr 2011 06:39:17 +0000 (UTC)
Message-Id: <20110421063916.78CDD63C226@www.NetBSD.org>
Date: Thu, 21 Apr 2011 06:39:16 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: mtod is assigned twice.
X-Send-Pr-Version: www-1.0

>Number:         44890
>Category:       kern
>Synopsis:       mtod is assigned twice.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Apr 21 06:40:05 +0000 2011
>Closed-Date:    Thu Apr 21 07:17:06 +0000 2011
>Last-Modified:  Thu Apr 21 07:17:06 +0000 2011
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
mtod is assigned twice in mld_input.
>How-To-Repeat:

>Fix:
diff -u -r1.51 mld6.c
--- sys/netinet6/mld6.c	4 Aug 2009 22:04:23 -0000	1.51
+++ sys/netinet6/mld6.c	21 Apr 2011 05:00:34 -0000
@@ -324,7 +324,7 @@
 void
 mld_input(struct mbuf *m, int off)
 {
-	struct ip6_hdr *ip6 = mtod(m, struct ip6_hdr *);
+	struct ip6_hdr *ip6;
 	struct mld_hdr *mldh;
 	struct ifnet *ifp = m->m_pkthdr.rcvif;
 	struct in6_multi *in6m = NULL;

>Release-Note:

>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44890 CVS commit: src/sys/netinet6
Date: Thu, 21 Apr 2011 06:58:32 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Thu Apr 21 06:58:32 UTC 2011

 Modified Files:
 	src/sys/netinet6: mld6.c

 Log Message:
 Prune dead assignment, from Henning Petersen in PR 44890.


 To generate a diff of this commit:
 cvs rdiff -u -r1.51 -r1.52 src/sys/netinet6/mld6.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Thu, 21 Apr 2011 07:17:06 +0000
State-Changed-Why:
fixed, thanks.


>Unformatted:

Home	PR Database Search