NetBSD Problem Report #44942

From dholland@netbsd.org  Sat May  7 00:12:16 2011
Return-Path: <dholland@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 1D68663BBEC
	for <gnats-bugs@gnats.NetBSD.org>; Sat,  7 May 2011 00:12:16 +0000 (UTC)
Message-Id: <20110507001216.0A56C14A268@mail.netbsd.org>
Date: Sat,  7 May 2011 00:12:16 +0000 (UTC)
From: dholland@NetBSD.org
Reply-To: dholland@NetBSD.org
To: gnats-bugs@gnats.NetBSD.org
Subject: certain generated xsrc files don't rebuild
X-Send-Pr-Version: 3.95

>Number:         44942
>Category:       xsrc
>Synopsis:       certain generated xsrc files don't rebuild
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    xsrc-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 07 00:15:00 +0000 2011
>Originator:     David A. Holland
>Release:        (current)
>Organization:
>Environment:
n/a
>Description:

There's an ugly mess in bsd.x11.mk that generates .pc files. There are
other less prominent rules in there that also contribute content to
build products. None of these build products depend on bsd.x11.mk, so
build.sh -u won't regenerate them when bsd.x11.mk changes. This causes
update builds to diverge from fresh builds and sometimes break, or
break X apps. See PR 43942 for an example.

However, depending on bsd.x11.mk is undesirable and messy because we
rely on make's include path to find it.

>How-To-Repeat:

>Fix:

Change all the nontrivial build rules into standalone shell scripts
and make the build products depend on the shell scripts that generate
them. This is not entirely trivial.

Home	PR Database Search