NetBSD Problem Report #46421
From www@NetBSD.org Mon May 7 08:21:32 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
by www.NetBSD.org (Postfix) with ESMTP id C1CB063BD33
for <gnats-bugs@gnats.NetBSD.org>; Mon, 7 May 2012 08:21:32 +0000 (UTC)
Message-Id: <20120507082132.278C663B91F@www.NetBSD.org>
Date: Mon, 7 May 2012 08:21:32 +0000 (UTC)
From: joern.clausen@uni-bielefeld.de
Reply-To: joern.clausen@uni-bielefeld.de
To: gnats-bugs@NetBSD.org
Subject: pkgtools/pkg_filecheck
X-Send-Pr-Version: www-1.0
>Number: 46421
>Category: pkg
>Synopsis: pkgtools/pkg_filecheck
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: pkg-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon May 07 08:25:00 +0000 2012
>Closed-Date: Sat Jun 11 21:35:37 +0000 2016
>Last-Modified: Sat Jun 11 21:35:37 +0000 2016
>Originator: Jörn Clausen
>Release:
>Organization:
University of Bielefeld
>Environment:
>Description:
pkgtools/pkg_filecheck does not work on Solaris 10 (though it compiles out of the box, see/close pkg/42145):
$ pkg_filecheck
__db_meta_setup: /usr/pkgsrc/20120411/var/db/pkg/pkgdb.byfile.db: unexpected file type or format
Although "file" does not recognize it as a DB file, is has the same initial bytes as the corresponding file on a NetBSD machine. pkg_filecheck is linked against databases/db4 (4.8.30).
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: pkg-manager->solaris-pkg-people
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Mon, 07 May 2012 09:20:48 +0000
Responsible-Changed-Why:
Solaris pkgsrc PR
From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/46421 (pkgtools/pkg_filecheck)
Date: Mon, 07 May 2012 18:33:24 +0900
On Mon, 07 May 2012 18:20:50 +0900, <wiz@netbsd.org> wrote:
> Solaris pkgsrc PR
I feel this is not a Solaris related issue.
pkgtools/pkg_install will be built with bdb from pkgtools/libnbcompat,
but pkgtools/pkg_filecheck is using mk/bdb.buildlink3.mk.
So this issue affect any platforms missing builtin db1.
--
OBATA Akio / obache@NetBSD.org
From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/46421 (pkgtools/pkg_filecheck)
Date: Tue, 8 May 2012 02:59:57 +0000
On Mon, May 07, 2012 at 09:35:03AM +0000, OBATA Akio wrote:
> > Solaris pkgsrc PR
>
> I feel this is not a Solaris related issue.
>
> pkgtools/pkg_install will be built with bdb from pkgtools/libnbcompat,
> but pkgtools/pkg_filecheck is using mk/bdb.buildlink3.mk.
> So this issue affect any platforms missing builtin db1.
concur
--
David A. Holland
dholland@netbsd.org
Responsible-Changed-From-To: solaris-pkg-people->pkg-manager
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Tue, 08 May 2012 06:08:00 +0000
Responsible-Changed-Why:
Popular sentiment is that it's not Solaris specific.
From: Tim Zingelman <tez@netbsd.org>
To: NetBSD bugtracking <gnats-bugs@netbsd.org>
Cc: pkg-manager@netbsd.org, solaris-pkg-people@netbsd.org,
pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org,
Thomas Klausner <wiz@netbsd.org>, =?UTF-8?B?SsO2cm4gQy4=?= <joern.clausen@uni-bielefeld.de>
Subject: Re: pkg/46421 (pkgtools/pkg_filecheck)
Date: Thu, 17 Dec 2015 15:41:55 -0600
This fixed it for me on Solaris, but all my other OS test machines are
broken right now.
Index: Makefile
===================================================================
RCS file: /usr/cvs/pkgsrc/pkgtools/pkg_filecheck/Makefile,v
retrieving revision 1.40
diff -w -u -b -r1.40 Makefile
--- Makefile 4 Jul 2015 16:18:39 -0000 1.40
+++ Makefile 17 Dec 2015 21:26:04 -0000
@@ -14,6 +14,9 @@
USE_TOOLS+= perl:run
USE_FEATURES= fts_open
+USE_FEATURES+= nbcompat
+NBCOMPAT_CONFIGURE_ARGS+= --enable-db
+
FILES_SUBST+= PKG_DBDIR=${PKG_DBDIR:Q}
CONF_FILES= ${PREFIX}/share/examples/pkg_filecheck/pkg_filecheck.conf \
${PKG_SYSCONFDIR}/pkg_filecheck.conf
@@ -51,5 +54,5 @@
${DESTDIR}${PREFIX}/share/examples/pkg_filecheck/pkg_filecheck.conf
-.include "../../mk/bdb.buildlink3.mk"
+#.include "../../mk/bdb.buildlink3.mk"
.include "../../mk/bsd.pkg.mk"
Index: files/pkg_filecheck.c
===================================================================
RCS file: /usr/cvs/pkgsrc/pkgtools/pkg_filecheck/files/pkg_filecheck.c,v
retrieving revision 1.6
diff -w -u -b -r1.6 pkg_filecheck.c
--- files/pkg_filecheck.c 8 Sep 2007 21:57:59 -0000 1.6
+++ files/pkg_filecheck.c 17 Dec 2015 21:31:15 -0000
@@ -32,7 +32,7 @@
#include <sys/types.h>
#include <sys/stat.h>
-#include <db_185.h>
+#include <nbcompat/db.h>
#include <errno.h>
#include <fcntl.h>
#include <fts.h>
On Tue, May 8, 2012 at 1:08 AM, <wiz@netbsd.org> wrote:
> Synopsis: pkgtools/pkg_filecheck
>
> Responsible-Changed-From-To: solaris-pkg-people->pkg-manager
> Responsible-Changed-By: wiz@NetBSD.org
> Responsible-Changed-When: Tue, 08 May 2012 06:08:00 +0000
> Responsible-Changed-Why:
> Popular sentiment is that it's not Solaris specific.
>
>
>
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/46421 CVS commit: pkgsrc/pkgtools/pkg_filecheck
Date: Sat, 11 Jun 2016 21:26:19 +0000
Module Name: pkgsrc
Committed By: dholland
Date: Sat Jun 11 21:26:19 UTC 2016
Modified Files:
pkgsrc/pkgtools/pkg_filecheck: Makefile
pkgsrc/pkgtools/pkg_filecheck/files: pkg_filecheck.c
Log Message:
Add patch from Tim Zingelman in PR 46421 to make it work on machines
whose libdb is not the db-1.85 that's in the libc of 4.4 derivates.
Since this program reads the package database it must use the same
libdb as pkg_install, and that's the one in libnbcompat rather than
the one you get from bdb.buildlink3.mk.
Bump PKGREVISION to 5.
To generate a diff of this commit:
cvs rdiff -u -r1.40 -r1.41 pkgsrc/pkgtools/pkg_filecheck/Makefile
cvs rdiff -u -r1.6 -r1.7 pkgsrc/pkgtools/pkg_filecheck/files/pkg_filecheck.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 11 Jun 2016 21:35:37 +0000
State-Changed-Why:
Fix committed, thanks.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.