NetBSD Problem Report #46709

From Wolfgang.Stukenbrock@nagler-company.com  Mon Jul 16 16:04:03 2012
Return-Path: <Wolfgang.Stukenbrock@nagler-company.com>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 3D97B63B85F
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 16 Jul 2012 16:04:03 +0000 (UTC)
Message-Id: <20120716160348.38D261E80A9@test-s0.nagler-company.com>
Date: Mon, 16 Jul 2012 18:03:48 +0200 (CEST)
From: Wolfgang.Stukenbrock@nagler-company.com
Reply-To: Wolfgang.Stukenbrock@nagler-company.com
To: gnats-bugs@gnats.NetBSD.org
Subject: pkgsrc-2012Q2 www/ap-php uses wrong PKG_OPTIONS variable
X-Send-Pr-Version: 3.95

>Number:         46709
>Category:       pkg
>Synopsis:       pkgsrc-2012Q2 www/ap-php uses wrong PKG_OPTIONS variable
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jul 16 16:05:00 +0000 2012
>Closed-Date:    Fri Jun 13 12:39:50 +0000 2014
>Last-Modified:  Fri Jun 13 12:39:50 +0000 2014
>Originator:     Wolfgang Stukenbrock
>Release:        NetBSD 5.1.2
>Organization:
Dr. Nagler & Company GmbH
>Environment:


System: NetBSD test-s0 4.0 NetBSD 4.0 (NSW-WS) #0: Tue Aug 17 17:28:09 CEST 2010 wgstuken@test-s0:/usr/src/sys/arch/amd64/compile/NSW-WS amd64
Architecture: x86_64
Machine: amd64
>Description:
	The make of www/ap-php reports that the correct opitons variable is PKG_OPTIONS.ap22-php53.
	But when setting that one, it ignores the value and reports that it has not been set.
	PKG_DEFAULT_OPTIONS works as expected.
	I've tried to debug thsi with "make -dA" but haven't found the reason for this behaviour.
	I'v only found that a ':C' substitution results in '-php53' near the printing that
	the options has not been set and setting PKG_OPTIONS.-php53 will add the options to the
	compilation.
	So somewhere in the *.mk files there seems to be a bad substition so that not the correct
	variable name is look for the settings.
	There are other packages that are affected by this too. (at least www/php-fpm).

	remark: for the php setup it would be nice if all php relevant settings would come from
		the same variable. for php53 it is PKG_OPTIONS.php and for ap-php, that needs the
		same setup as php53, PKG_OPTIONS.ap22-php53 is used.
		But this is not the main topic of this report.
>How-To-Repeat:
	Try to compile www/ap-php with PKG_OPTIONS.ap22-php53 set, it will report that it is
	not set. When useing PKG_OPTIONS.-php53 instead, the make prints that PKG_OPTIONS.ap22-php53
	has been set and uses the defintions.
>Fix:
	not know - I thing there is a bug in the *.mk files of pkgsrc
	workaround: use PKG_OPTIONS.-php53

>Release-Note:

>Audit-Trail:
From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/46709: pkgsrc-2012Q2 www/ap-php uses wrong PKG_OPTIONS
 variable
Date: Thu, 19 Jul 2012 21:01:34 +0900

 On Tue, 17 Jul 2012 01:05:01 +0900, <Wolfgang.Stukenbrock@nagler-company.com> wrote:

 >> How-To-Repeat:
 > 	Try to compile www/ap-php with PKG_OPTIONS.ap22-php53 set, it will report that it is
 > 	not set. When useing PKG_OPTIONS.-php53 instead, the make prints that PKG_OPTIONS.ap22-php53
 > 	has been set and uses the defintions.

 It is because at the time PKG_OPTIONS is processed, ${APACHE_PKG_PREFIX} is not set yet.


 >> Fix:
 > 	not know - I thing there is a bug in the *.mk files of pkgsrc
 > 	workaround: use PKG_OPTIONS.-php53

 Please try to move

 .include "../../mk/apache.mk"

 before

 .include "${PHPPKGSRCDIR}/Makefile.php"


 But I don't believe that any PHP and Apache variant combinations require
 individual PKG_OPTIONS_VAR.

 -- 
 OBATA Akio / obache@NetBSD.org

From: Hauke Fath <hf@spg.tu-darmstadt.de>
To: gnats-bugs@NetBSD.org
Cc: Hauke Fath <hf@spg.tu-darmstadt.de>
Subject: Re: pkg/46709: www/ap-php uses wrong PKG_OPTIONS variable
Date: Thu, 28 Feb 2013 12:28:23 +0100

 >Please try to move
 >
 > .include "../../mk/apache.mk"
 >
 > before
 >
 > .include "${PHPPKGSRCDIR}/Makefile.php"

 This change to ap-php/Makefile fixes the problem for me. Would it be ok to
 commit?

 hauke

 -- 
      The ASCII Ribbon Campaign                    Hauke Fath
 ()     No HTML/RTF in email            Institut für Nachrichtentechnik
 /\     No Word docs in email                     TU Darmstadt
      Respect for open standards              Ruf +49-6151-16-3281

From: Hauke Fath <hf@spg.tu-darmstadt.de>
To: gnats-bugs@NetBSD.org
Cc: Hauke Fath <hf@spg.tu-darmstadt.de>
Subject: Re: pkg/46709: www/ap-php uses wrong PKG_OPTIONS variable
Date: Thu, 28 Feb 2013 13:39:13 +0100

 At 12:28 Uhr +0100 28.02.2013, Hauke Fath wrote:
 >This change to ap-php/Makefile fixes the problem for me. Would it be ok to
 >commit?

 Answering my own question: No. The resulting build completes without an
 error, but no php*.so is produced. Ah well.

 hauke

 -- 
      The ASCII Ribbon Campaign                    Hauke Fath
 ()     No HTML/RTF in email            Institut für Nachrichtentechnik
 /\     No Word docs in email                     TU Darmstadt
      Respect for open standards              Ruf +49-6151-16-3281

State-Changed-From-To: open->closed
State-Changed-By: obache@NetBSD.org
State-Changed-When: Fri, 13 Jun 2014 12:39:50 +0000
State-Changed-Why:
After 31 May 2014, lang/php53 and and www/ap-php use same PKG_OPTIONS_VAR,
PKG_OPTIONS.php53


>Unformatted:

Home	PR Database Search