NetBSD Problem Report #46777

From www@NetBSD.org  Tue Aug  7 09:17:42 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 0F43363B882
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  7 Aug 2012 09:17:42 +0000 (UTC)
Message-Id: <20120807091740.B360363B85F@www.NetBSD.org>
Date: Tue,  7 Aug 2012 09:17:40 +0000 (UTC)
From: joern.clausen@uni-bielefeld.de
Reply-To: joern.clausen@uni-bielefeld.de
To: gnats-bugs@NetBSD.org
Subject: sysutils/dbus does not compile on Solaris 10 with GCC 4
X-Send-Pr-Version: www-1.0

>Number:         46777
>Category:       pkg
>Synopsis:       sysutils/dbus does not compile on Solaris 10 with GCC 4
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    solaris-pkg-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 07 09:20:01 +0000 2012
>Closed-Date:    Fri Sep 30 08:36:52 +0000 2016
>Last-Modified:  Fri Sep 30 08:36:52 +0000 2016
>Originator:     Jörn Clausen
>Release:        
>Organization:
University of Bielefeld
>Environment:
>Description:
Compilation of sysutils/dbus 1.6.4 on Solaris 10 with GCC 4.7.0 and native assembler and linker fails at various stages.
>How-To-Repeat:

>Fix:
The following changes are necessary to successfully build the package:

pkgsrc's Makefile:

--- Makefile    2012/08/07 08:51:02     1.1
+++ Makefile    2012/08/07 08:51:25
@@ -32,6 +32,7 @@
 #CONFIGURE_ARGS+=      --enable-embedded-tests

 #CFLAGS.NetBSD+=               -D_NETBSD_SOURCE
+CFLAGS.SunOS+= -std=c99 -D_XPG6

 CONFIGURE_ARGS_GROUPS= enable disable with without


new patches:

--- dbus/dbus-sysdeps-util-unix.c.orig  2012-06-28 14:49:23.000000000 +0000
+++ dbus/dbus-sysdeps-util-unix.c
@@ -424,7 +424,7 @@ _dbus_request_file_descriptor_limit (uns
 void
 _dbus_init_system_log (void)
 {
-#ifdef HAVE_DECL_LOG_PERROR
+#if HAVE_DECL_LOG_PERROR
   openlog ("dbus", LOG_PID | LOG_PERROR, LOG_DAEMON);
 #else
   openlog ("dbus", LOG_PID, LOG_DAEMON);

--- dbus/sd-daemon.h.orig       2012-06-06 10:45:55.000000000 +0000
+++ dbus/sd-daemon.h
@@ -67,7 +67,7 @@ extern "C" {
   See sd-daemon(7) for more information.
 */

-#if __GNUC__ >= 4
+#if __GNUC__ >= 4 && !(__sun__)
 #define _sd_printf_attr_(a,b) __attribute__ ((format (printf, a, b)))
 #define _sd_hidden_ __attribute__ ((visibility("hidden")))
 #else


Finally, patch-ab needs to include

#include <alloca.h>

guarded by a suitable #if.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->solaris-pkg-people
Responsible-Changed-By: obache@NetBSD.org
Responsible-Changed-When: Tue, 07 Aug 2012 11:39:02 +0000
Responsible-Changed-Why:
PR for solaris.


From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/46777: sysutils/dbus does not compile on Solaris 10 with GCC
 4
Date: Tue, 7 Aug 2012 20:42:48 +0200

 On Tue, Aug 07, 2012 at 09:20:01AM +0000, joern.clausen@uni-bielefeld.de wrote:
 > Finally, patch-ab needs to include
 > 
 > #include <alloca.h>
 > 
 > guarded by a suitable #if.

 Does including stdlib.h instead work as well?
  Thomas

From: =?ISO-8859-1?Q?J=F6rn_Clausen?= <joern.clausen@uni-bielefeld.de>
To: gnats-bugs@NetBSD.org
Cc: Thomas Klausner <wiz@NetBSD.org>, solaris-pkg-people@NetBSD.org,
 gnats-admin@NetBSD.org, pkgsrc-bugs@NetBSD.org
Subject: Re: pkg/46777: sysutils/dbus does not compile on Solaris 10 with GCC 4
Date: Wed, 08 Aug 2012 08:39:55 +0200

 >   Does including stdlib.h instead work as well?

 No. stdlib.h is already included. On Solaris, alloca.h is required.

 -- 
   Jörn Clausen                             joern.clausen@uni-bielefeld.de
   Hochschulrechenzentrum                 http://www.uni-bielefeld.de/hrz/
   Universität Bielefeld

State-Changed-From-To: open->feedback
State-Changed-By: jperkin@NetBSD.org
State-Changed-When: Thu, 09 Aug 2012 11:10:42 +0000
State-Changed-Why:
I fixed this a different way which works on illumos, are any of your patches
still required after that?


From: =?ISO-8859-1?Q?J=F6rn_Clausen?= <joern.clausen@uni-bielefeld.de>
To: gnats-bugs@NetBSD.org
Cc: jperkin@NetBSD.org, solaris-pkg-people@NetBSD.org, pkgsrc-bugs@NetBSD.org,
 gnats-admin@NetBSD.org
Subject: Re: pkg/46777 (sysutils/dbus does not compile on Solaris 10 with GCC 4)
Date: Thu, 09 Aug 2012 15:10:03 +0200

 > I fixed this a different way which works on illumos, are any of your patches
 > still required after that?

 I haven't actually tried your changes, but I think you missed the one 
 regarding alloca.h. Maybe that one is not necessary any more on Illumos?

 -- 
   Jörn Clausen                             joern.clausen@uni-bielefeld.de
   Hochschulrechenzentrum                 http://www.uni-bielefeld.de/hrz/
   Universität Bielefeld

From: Jonathan Perkin <jperkin@pkgsrc.org>
To: =?iso-8859-1?Q?J=F6rn?= Clausen <joern.clausen@uni-bielefeld.de>
Cc: gnats-bugs@NetBSD.org, solaris-pkg-people@NetBSD.org,
	pkgsrc-bugs@NetBSD.org, gnats-admin@NetBSD.org
Subject: Re: pkg/46777 (sysutils/dbus does not compile on Solaris 10 with GCC
 4)
Date: Thu, 9 Aug 2012 14:18:10 +0100

 * On 2012-08-09 at 14:10 BST, Jörn Clausen wrote:

 > > I fixed this a different way which works on illumos, are any of your
 > > patches still required after that?
 >
 > I haven't actually tried your changes, but I think you missed the
 > one regarding alloca.h. Maybe that one is not necessary any more on
 > Illumos?

 Perhaps, I didn't need that on SmartOS, and I don't have Solaris 10 to
 test.

 -- 
 Jonathan Perkin       www.perkin.org.uk
 github.com/jperkin  twitter.com/jperkin

State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Fri, 30 Sep 2016 08:36:52 +0000
State-Changed-Why:
assume the commits in 2012 fixed the problem.


>Unformatted:

Home	PR Database Search