NetBSD Problem Report #46812

From www@NetBSD.org  Sat Aug 18 03:36:43 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 3B0B563CD67
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 18 Aug 2012 03:36:43 +0000 (UTC)
Message-Id: <20120818033642.AD12363B882@www.NetBSD.org>
Date: Sat, 18 Aug 2012 03:36:42 +0000 (UTC)
From: isaki@pastel-flower.jp
Reply-To: isaki@pastel-flower.jp
To: gnats-bugs@NetBSD.org
Subject: sysinst stops with "openpty() failed" on netbsd-6/sparc
X-Send-Pr-Version: www-1.0

>Number:         46812
>Category:       install
>Synopsis:       sysinst stops with "openpty() failed" on netbsd-6/sparc
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    install-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Aug 18 03:40:00 +0000 2012
>Closed-Date:    Sun Aug 19 06:01:33 +0000 2012
>Last-Modified:  Mon Apr 29 03:31:06 +0000 2013
>Originator:     Tetsuya Isaki
>Release:        NetBSD 6.0_BETA2/sparc
>Organization:
NetBSD
>Environment:
N/A
>Description:
On NetBSD-6.0_BETA2/sparc (cvs up about 2012/08/16),
sysinst stops with the following error message.

--------------------------------------------------------------------------------
     Status: openpty() failed
    Command: disklabel -w -r -f /tmp/disktab sd0 'QEMU HARDDISK  '
     Hit enter to continue
--------------------------------------------------------------------------------

I tried it on QEMU 0.13,
% qemu-system-sparc -nographic -boot d \
 -hda sparc.img -cdrom NetBSD-6.0_BETA2-sparc.iso

>How-To-Repeat:
As above.
>Fix:
N/A

>Release-Note:

>Audit-Trail:
From: matthew green <mrg@eterna.com.au>
To: gnats-bugs@NetBSD.org
Cc: install-manager@netbsd.org, gnats-admin@netbsd.org,
    netbsd-bugs@netbsd.org
Subject: re: install/46812: sysinst stops with "openpty() failed" on netbsd-6/sparc
Date: Sat, 18 Aug 2012 18:52:42 +1000

 > --------------------------------------------------------------------------------
 >      Status: openpty() failed
 >     Command: disklabel -w -r -f /tmp/disktab sd0 'QEMU HARDDISK  '
 >      Hit enter to continue
 > --------------------------------------------------------------------------------
 > 
 > I tried it on QEMU 0.13,
 > % qemu-system-sparc -nographic -boot d \
 >  -hda sparc.img -cdrom NetBSD-6.0_BETA2-sparc.iso

 i think this is due to sparc/instfs/Makefile not setting MAKEDEVTARGETS.
 the /instfs/dev/* is missing pty entries.

 looking at a fix.


 .mrg.

State-Changed-From-To: open->pending-pullups
State-Changed-By: mrg@NetBSD.org
State-Changed-When: Sat, 18 Aug 2012 09:34:20 +0000
State-Changed-Why:
fixed in -current, needs to be in netbsd-6.


From: "matthew green" <mrg@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46812 CVS commit: src/distrib/sparc/miniroot
Date: Sat, 18 Aug 2012 09:33:38 +0000

 Module Name:	src
 Committed By:	mrg
 Date:		Sat Aug 18 09:33:31 UTC 2012

 Modified Files:
 	src/distrib/sparc/miniroot: Makefile.inc

 Log Message:
 add ipty to the list of MAKEDEVTARGETS.  should fix PR#46812.
 certainly makes the qemu/sparc install work for me with netbsd-6.

 XXX: pullup.


 To generate a diff of this commit:
 cvs rdiff -u -r1.18 -r1.19 src/distrib/sparc/miniroot/Makefile.inc

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
To: gnats-bugs@NetBSD.org
Cc: install-manager@NetBSD.org, isaki@pastel-flower.jp,
        tsutsui@ceres.dti.ne.jp
Subject: Re: PR/46812 CVS commit: src/distrib/sparc/miniroot
Date: Sat, 18 Aug 2012 19:23:01 +0900

 mrg@ wrote:

 >  Module Name:	src
 >  Committed By:	mrg
 >  Date:		Sat Aug 18 09:33:31 UTC 2012
 >  
 >  Modified Files:
 >  	src/distrib/sparc/miniroot: Makefile.inc
 >  
 >  Log Message:
 >  add ipty to the list of MAKEDEVTARGETS.  should fix PR#46812.
 >  certainly makes the qemu/sparc install work for me with netbsd-6.

 Have you tried install iso?
 Doesn't "all" target for miniroot create all pty devices?

 I think the problem is
 >> MAKEDEVTARGETS= floppy
 line in src/distrib/sparc/ramdisk/Makefile for bootfs/instfs,
 so the correct fix is to change opty to ipty in "floppy" entry
 in etc/etc.sparc/MAKEDEV, even for install ISO.

 I'm afraid we also have to check and add "ipty" to
 "floppy" or "ramdisk" targets in all MD etc/etc.${MACHINE}/MAKEDEV.conf
 (and distrib/sun[23]/miniroot/Makefile etc.)

 ---
 Izumi Tsutsui

From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
To: gnats-bugs@NetBSD.org
Cc: install-manager@NetBSD.org, isaki@pastel-flower.jp,
        tsutsui@ceres.dti.ne.jp
Subject: Re: PR/46812 CVS commit: src/distrib/sparc/miniroot
Date: Sun, 19 Aug 2012 02:29:57 +0900

 I wrote:
 >  
 >  Have you tried install iso?
 >  Doesn't "all" target for miniroot create all pty devices?
 >  
 >  I think the problem is
 >  >> MAKEDEVTARGETS= floppy
 >  line in src/distrib/sparc/ramdisk/Makefile for bootfs/instfs,
 >  so the correct fix is to change opty to ipty in "floppy" entry
 >  in etc/etc.sparc/MAKEDEV, even for install ISO.
 >  
 >  I'm afraid we also have to check and add "ipty" to
 >  "floppy" or "ramdisk" targets in all MD etc/etc.${MACHINE}/MAKEDEV.conf
 >  (and distrib/sun[23]/miniroot/Makefile etc.)

 Sorry, I was completely wrong.

 I missed following description in etc/MAKEDEV.tmpl:
 >> #	pty*    set of 16 master and slave pseudo terminals
 >> #	opty    first 16 ptys, to save inodes on install media
 >> #	ipty    first 2 ptys, for install media use only

 The essencial changes were pty[0123] removal from "all" target
 in etc/MAKEDEV.tmpl, and actually sparc install iso uses miniroot,
 so ipty is required in distrib/sparc/miniroot/Makefile.inc.

 (BTW amd64 and i386 (and some other ports) have "ipty" in "all_md"
  target in etc/etc.${MACHINE}/MAKEDEV.conf so I wonder if "all_md"
  should include "ipty" or not)

 For sun2 and sun3 miniroot, it doesn't have sysinst so if openpty(3)
 is required by only sysinst they don't pty devices either.

 ---
 Izumi Tsutsui

From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: PR/46812 CVS commit: src/distrib/sparc/miniroot
Date: Sat, 18 Aug 2012 19:48:57 +0200

 On Sat, Aug 18, 2012 at 05:35:02PM +0000, Izumi Tsutsui wrote:
 >  For sun2 and sun3 miniroot, it doesn't have sysinst so if openpty(3)
 >  is required by only sysinst they don't pty devices either.

 But they don't do any harm as long as we have COMPAT_BSDPTY in the coresponding
 kernels and don't mount ptyfs during install. (Not that they could do any
 harm in an install environment anyway.)

 Martin

From: matthew green <mrg@eterna.com.au>
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Cc: install-manager@NetBSD.org, isaki@pastel-flower.jp,
    gnats-bugs@NetBSD.org
Subject: re: PR/46812 CVS commit: src/distrib/sparc/miniroot
Date: Sun, 19 Aug 2012 06:00:14 +1000

 > >  Module Name:	src
 > >  Committed By:	mrg
 > >  Date:		Sat Aug 18 09:33:31 UTC 2012
 > >  
 > >  Modified Files:
 > >  	src/distrib/sparc/miniroot: Makefile.inc
 > >  
 > >  Log Message:
 > >  add ipty to the list of MAKEDEVTARGETS.  should fix PR#46812.
 > >  certainly makes the qemu/sparc install work for me with netbsd-6.
 > 
 > Have you tried install iso?
 > Doesn't "all" target for miniroot create all pty devices?
 > 
 > I think the problem is
 > >> MAKEDEVTARGETS= floppy
 > line in src/distrib/sparc/ramdisk/Makefile for bootfs/instfs,
 > so the correct fix is to change opty to ipty in "floppy" entry
 > in etc/etc.sparc/MAKEDEV, even for install ISO.
 > 
 > I'm afraid we also have to check and add "ipty" to
 > "floppy" or "ramdisk" targets in all MD etc/etc.${MACHINE}/MAKEDEV.conf
 > (and distrib/sun[23]/miniroot/Makefile etc.)

 i tested the installer in qemu after making this change.  i tried
 changing "floppy" and it didn't work.  that affects the *external*
 install in the sparc installer.  these are the device nodes in the
 *internal* chroot aka "instfs" that are missing.

 (it doesn't help that changing these items requires you to blow
 away parts of the obj/release dirs to get rebuilds to occur.)


 .mrg.

From: matthew green <mrg@eterna.com.au>
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Cc: install-manager@NetBSD.org, isaki@pastel-flower.jp,
    gnats-bugs@NetBSD.org
Subject: re: PR/46812 CVS commit: src/distrib/sparc/miniroot
Date: Sun, 19 Aug 2012 06:14:50 +1000

 > (BTW amd64 and i386 (and some other ports) have "ipty" in "all_md"
 >  target in etc/etc.${MACHINE}/MAKEDEV.conf so I wonder if "all_md"
 >  should include "ipty" or not)

 we only want old-style ptys to exist in special places (like install
 media without ptyfs) *or* if someone chooses not to mount ptyfs.

 ie, explicitly asking for ipty/opty seems valid, instead of putting
 it in some "all*" section.



 .mrg.

From: "Jeff Rizzo" <riz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46812 CVS commit: [netbsd-6] src
Date: Sat, 18 Aug 2012 22:11:45 +0000

 Module Name:	src
 Committed By:	riz
 Date:		Sat Aug 18 22:11:45 UTC 2012

 Modified Files:
 	src/distrib/sparc/miniroot [netbsd-6]: Makefile.inc
 	src/etc/etc.vax [netbsd-6]: MAKEDEV.conf

 Log Message:
 Pull up following revision(s) (requested by martin in ticket #512):
 	distrib/sparc/miniroot/Makefile.inc: revision 1.19
 	etc/etc.vax/MAKEDEV.conf: revision 1.17
 Seems like all the trendy ramdisks are using "makedev ipty" rather than
 "makedev pty0" now. Update vax to match so install media doesn't fail
 with
 .../MAKEDEV: pty0: creating BSD style tty nodes with ptyfs is a security issue
 add ipty to the list of MAKEDEVTARGETS.  should fix PR#46812.
 certainly makes the qemu/sparc install work for me with netbsd-6.
 XXX: pullup.


 To generate a diff of this commit:
 cvs rdiff -u -r1.18 -r1.18.8.1 src/distrib/sparc/miniroot/Makefile.inc
 cvs rdiff -u -r1.13.4.2 -r1.13.4.3 src/etc/etc.vax/MAKEDEV.conf

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: mrg@NetBSD.org
State-Changed-When: Sun, 19 Aug 2012 06:01:33 +0000
State-Changed-Why:
this is fixed now.  thanks!


From: "Izumi Tsutsui" <tsutsui@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46812 CVS commit: src
Date: Sun, 28 Apr 2013 08:08:04 +0000

 Module Name:	src
 Committed By:	tsutsui
 Date:		Sun Apr 28 08:08:04 UTC 2013

 Modified Files:
 	src/distrib/hp300/ramdisk: Makefile
 	src/etc/etc.hp300: MAKEDEV.conf

 Log Message:
 Fix yet another "openpty() failed" error during sysinst.

 Prepare a new entry for ramdisk that includes ipty target in
 etc.hp300/MAKEDEV.conf and use it in distrib/hp300/ramdisk/Makefile.
 See also PR/46812, PR/47123, and PR/47774.

 We could simply add "ipty" to MAKEDEVTARGETS as miniroot/Makefile does,
 but it's better to shrink ramdisk size as much as possible.

 Should be pulled up to both netbsd-6 and netbsd-6-0.


 To generate a diff of this commit:
 cvs rdiff -u -r1.31 -r1.32 src/distrib/hp300/ramdisk/Makefile
 cvs rdiff -u -r1.13 -r1.14 src/etc/etc.hp300/MAKEDEV.conf

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Jeff Rizzo" <riz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46812 CVS commit: [netbsd-6-0] src
Date: Mon, 29 Apr 2013 03:26:35 +0000

 Module Name:	src
 Committed By:	riz
 Date:		Mon Apr 29 03:26:35 UTC 2013

 Modified Files:
 	src/distrib/hp300/ramdisk [netbsd-6-0]: Makefile
 	src/etc/etc.hp300 [netbsd-6-0]: MAKEDEV.conf

 Log Message:
 Pull up following revision(s) (requested by tsutsui in ticket #880):
 	etc/etc.hp300/MAKEDEV.conf: revision 1.14
 	distrib/hp300/ramdisk/Makefile: revision 1.32
 Fix yet another "openpty() failed" error during sysinst.
 Prepare a new entry for ramdisk that includes ipty target in
 etc.hp300/MAKEDEV.conf and use it in distrib/hp300/ramdisk/Makefile.
 See also PR/46812, PR/47123, and PR/47774.
 We could simply add "ipty" to MAKEDEVTARGETS as miniroot/Makefile does,
 but it's better to shrink ramdisk size as much as possible.
 Should be pulled up to both netbsd-6 and netbsd-6-0.


 To generate a diff of this commit:
 cvs rdiff -u -r1.30 -r1.30.14.1 src/distrib/hp300/ramdisk/Makefile
 cvs rdiff -u -r1.13 -r1.13.10.1 src/etc/etc.hp300/MAKEDEV.conf

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Jeff Rizzo" <riz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46812 CVS commit: [netbsd-6] src
Date: Mon, 29 Apr 2013 03:26:52 +0000

 Module Name:	src
 Committed By:	riz
 Date:		Mon Apr 29 03:26:52 UTC 2013

 Modified Files:
 	src/distrib/hp300/ramdisk [netbsd-6]: Makefile
 	src/etc/etc.hp300 [netbsd-6]: MAKEDEV.conf

 Log Message:
 Pull up following revision(s) (requested by tsutsui in ticket #880):
 	etc/etc.hp300/MAKEDEV.conf: revision 1.14
 	distrib/hp300/ramdisk/Makefile: revision 1.32
 Fix yet another "openpty() failed" error during sysinst.
 Prepare a new entry for ramdisk that includes ipty target in
 etc.hp300/MAKEDEV.conf and use it in distrib/hp300/ramdisk/Makefile.
 See also PR/46812, PR/47123, and PR/47774.
 We could simply add "ipty" to MAKEDEVTARGETS as miniroot/Makefile does,
 but it's better to shrink ramdisk size as much as possible.
 Should be pulled up to both netbsd-6 and netbsd-6-0.


 To generate a diff of this commit:
 cvs rdiff -u -r1.30 -r1.30.8.1 src/distrib/hp300/ramdisk/Makefile
 cvs rdiff -u -r1.13 -r1.13.4.1 src/etc/etc.hp300/MAKEDEV.conf

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search