NetBSD Problem Report #47397
From www@NetBSD.org Thu Jan 3 21:30:33 2013
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
by www.NetBSD.org (Postfix) with ESMTP id 9631563E615
for <gnats-bugs@gnats.NetBSD.org>; Thu, 3 Jan 2013 21:30:33 +0000 (UTC)
Message-Id: <20130103213032.27AED63E615@www.NetBSD.org>
Date: Thu, 3 Jan 2013 21:30:32 +0000 (UTC)
From: gnrp@komkon2.de
Reply-To: gnrp@komkon2.de
To: gnats-bugs@NetBSD.org
Subject: set_field_back(3) does not set background
X-Send-Pr-Version: www-1.0
>Number: 47397
>Category: lib
>Synopsis: set_field_back(3) does not set background
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: blymn
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Thu Jan 03 21:35:00 +0000 2013
>Closed-Date: Thu Oct 28 02:46:02 +0000 2021
>Last-Modified: Thu Oct 28 02:46:02 +0000 2021
>Originator: Julian Fagir
>Release: NetBSD 6.0-RELEASE
>Organization:
>Environment:
>Description:
When you try to set the background of a form field to an attribute, it will not do so.
On ncurses, this call:
set_field_back(fields[0], A_UNDERLINE);
has the effect to underline the field. In nbcurses, it doesn't do anything. On nbcurses, if you set the second option to a character, this is shown, but A_UNDERLINE does not work.
Is this missing documentation or a general bug?
>How-To-Repeat:
Compile this piece of code with -lform, run it on a ncurses and a nbcurses machine:
#include <form.h>
#include <form.h>
#include <string.h>
#include <stdlib.h>
#include <unistd.h>
#include <stdio.h>
int
main(int arg, char *argv[])
{
int ch, j, i = 0;
WINDOW *mainwin;
FIELD *fields[2];
FORM *form;
char buf[512];
initscr();
keypad(stdscr, TRUE);
noecho();
cbreak();
mainwin = newwin(20, 70, 2, 2);
box(mainwin, 0, 0);
mvwprintw(mainwin, 1, 1, "Creating window...");
wrefresh(mainwin);
fields[0] = new_field(1, 20, 2, 1, 0, 0);
fields[1] = NULL;
form = new_form(fields);
set_form_win(form, mainwin);
set_form_sub(form, derwin(mainwin, 15, 60, 2, 2));
set_field_back(fields[0], A_UNDERLINE);
refresh();
post_form(form);
wrefresh(mainwin);
buf[0] = '\0';
while ((ch = getch()) != '\n') {
switch (ch) {
case KEY_LEFT:
form_driver(form, REQ_LEFT_CHAR);
i--;
break;
case KEY_RIGHT:
if (buf[i] != '\0') {
form_driver(form, REQ_RIGHT_CHAR);
i++;
}
break;
case KEY_END:
form_driver(form, REQ_END_LINE);
i = strlen(buf);
break;
case KEY_HOME:
form_driver(form, REQ_BEG_LINE);
i = 0;
break;
case '\b':
case KEY_BACKSPACE:
form_driver(form, REQ_DEL_PREV);
buf[i] = '\0';
i--;
break;
default:
if (i < sizeof(buf) - 2) {
form_driver(form, ch);
for (j = strlen(buf); j >= i; j--)
buf[j+1] = buf[j];
buf[i] = ch;
i++;
}
break;
}
refresh();
wrefresh(mainwin);
}
free_field(fields[1]);
unpost_form(form);
free_form(form);
endwin();
return 0;
}
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback
State-Changed-By: blymn@NetBSD.org
State-Changed-When: Tue, 19 Oct 2021 21:23:14 +0000
State-Changed-Why:
Fix committed, feedback is required.
From: "Brett Lymn" <blymn@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/47397 CVS commit: src/lib/libform
Date: Tue, 19 Oct 2021 21:22:20 +0000
Module Name: src
Committed By: blymn
Date: Tue Oct 19 21:22:20 UTC 2021
Modified Files:
src/lib/libform: internals.c
Log Message:
Fix for PR lib/47397
Fix a misinterpretation of the role of field fore and back. Now field
pad is rendered in the back attribute always instead of only being used
for the non-current field.
To generate a diff of this commit:
cvs rdiff -u -r1.40 -r1.41 src/lib/libform/internals.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Responsible-Changed-From-To: lib-bug-people->blymn
Responsible-Changed-By: blymn@NetBSD.org
Responsible-Changed-When: Thu, 28 Oct 2021 02:46:02 +0000
Responsible-Changed-Why:
Claiming the PR since I did the fix.
State-Changed-From-To: feedback->closed
State-Changed-By: blymn@NetBSD.org
State-Changed-When: Thu, 28 Oct 2021 02:46:02 +0000
State-Changed-Why:
Closing PR, reporter can no longer test fix but sample code works
so I am confident the bug is fixed.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.