NetBSD Problem Report #47474

From campbell@mumble.net  Sun Jan 20 00:42:04 2013
Return-Path: <campbell@mumble.net>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 7F51563EDED
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 20 Jan 2013 00:42:04 +0000 (UTC)
Message-Id: <20130120004142.28F3660508@jupiter.mumble.net>
Date: Sun, 20 Jan 2013 00:41:41 +0000 (UTC)
From: Taylor R Campbell <campbell+pkgsrc@mumble.net>
Reply-To: Taylor R Campbell <campbell+pkgsrc@mumble.net>
To: gnats-bugs@gnats.NetBSD.org
Subject: gst-plugins0.10-good pulls in gconf and gnome stuff
X-Send-Pr-Version: 3.95

>Number:         47474
>Category:       pkg
>Synopsis:       gst-plugins0.10-good pulls in gconf and gnome stuff
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    riastradh
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 20 00:45:00 +0000 2013
>Closed-Date:    Sat Feb 20 15:42:34 +0000 2016
>Last-Modified:  Sat Feb 20 15:42:34 +0000 2016
>Originator:     Taylor R Campbell <campbell+pkgsrc@mumble.net>
>Release:        NetBSD 6.0
>Organization:
>Environment:
NetBSD ... 6.0 NetBSD 6.0 (LIBKVER) #0: Tue Jan 19 00:00:00 UTC 2038 root@localhost:/sys/arch/amd64/compile/LIBKVER amd64
Architecture: amd64
Machine: amd64
>Description:

	multimeida/gst-plugins0.10-good depends unconditionally on
	gconf and gnome stuff.

>How-To-Repeat:

	Install multimedia/gst-plugins0.10-good and grumble at all the
	gconf and gnome (and probably dbus, I forget) stuff that it
	pulls in.

>Fix:

	Apply the following patch to make gconf an option:

Index: multimedia/gst-plugins0.10-good/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/multimedia/gst-plugins0.10-good/Makefile,v
retrieving revision 1.29
diff -p -u -r1.29 Makefile
--- multimedia/gst-plugins0.10-good/Makefile	8 Oct 2012 09:21:03 -0000	1.29
+++ multimedia/gst-plugins0.10-good/Makefile	19 Jan 2013 20:10:07 -0000
@@ -2,21 +2,17 @@
 #

 .include "Makefile.common"
-PKGREVISION=		3
+PKGREVISION=		4

 COMMENT+=		good plugins

 # some plugins were moved from bad to good
 CONFLICTS+=		gst-plugins0.10-bad<0.10.18

-CONFIGURE_ARGS+=	--enable-gconf
-CONFIGURE_ARGS+=	--enable-gconftool
-CONFIGURE_ARGS+=	--enable-zlib
+.include "options.mk"

-# We depend on libxml anyway (indirectly through GConf), so this
-# doesn't hurt. Just make it explicite.
+CONFIGURE_ARGS+=	--enable-zlib
 CONFIGURE_ARGS+=	--enable-annodex
-.include "../../textproc/libxml2/buildlink3.mk"

 GCONF_SCHEMAS=		gstreamer-0.10.schemas

@@ -24,10 +20,12 @@ GCONF_SCHEMAS=		gstreamer-0.10.schemas
 TEST_TARGET=		check-torture

 post-install:
+.if !empty(PKG_OPTIONS:Mgconf)
 	${INSTALL_DATA} ${WRKSRC}/gconf/gstreamer-0.10.schemas \
 		${DESTDIR}${GCONF_SCHEMAS_DIR}
+.endif

 .include "../../archivers/bzip2/buildlink3.mk"
-.include "../../devel/GConf/schemas.mk"
 .include "../../devel/zlib/buildlink3.mk"
+.include "../../textproc/libxml2/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
Index: multimedia/gst-plugins0.10-good/PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/multimedia/gst-plugins0.10-good/PLIST,v
retrieving revision 1.25
diff -p -u -r1.25 PLIST
--- multimedia/gst-plugins0.10-good/PLIST	28 Feb 2012 18:31:00 -0000	1.25
+++ multimedia/gst-plugins0.10-good/PLIST	19 Jan 2013 20:10:07 -0000
@@ -17,7 +17,7 @@ lib/gstreamer-0.10/libgsteffectv.la
 lib/gstreamer-0.10/libgstequalizer.la
 lib/gstreamer-0.10/libgstflv.la
 lib/gstreamer-0.10/libgstflxdec.la
-lib/gstreamer-0.10/libgstgconfelements.la
+${PLIST.gconf}lib/gstreamer-0.10/libgstgconfelements.la
 lib/gstreamer-0.10/libgstgoom.la
 lib/gstreamer-0.10/libgstgoom2k1.la
 lib/gstreamer-0.10/libgsticydemux.la
@@ -46,7 +46,7 @@ lib/gstreamer-0.10/libgstvideomixer.la
 lib/gstreamer-0.10/libgstwavenc.la
 lib/gstreamer-0.10/libgstwavparse.la
 lib/gstreamer-0.10/libgsty4menc.la
-share/gconf/schemas/gstreamer-0.10.schemas
+${PLIST.gconf}share/gconf/schemas/gstreamer-0.10.schemas
 share/gstreamer-0.10/presets/GstIirEqualizer10Bands.prs
 share/gstreamer-0.10/presets/GstIirEqualizer3Bands.prs
 share/locale/af/LC_MESSAGES/gst-plugins-good-0.10.mo
Index: multimedia/gst-plugins0.10-good/options.mk
===================================================================
RCS file: multimedia/gst-plugins0.10-good/options.mk
diff -N multimedia/gst-plugins0.10-good/options.mk
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ multimedia/gst-plugins0.10-good/options.mk	19 Jan 2013 20:10:07 -0000
@@ -0,0 +1,15 @@
+# $NetBSD$
+
+PKG_OPTIONS_VAR=	PKG_OPTIONS.gst-plugins0.10-good
+PKG_SUPPORTED_OPTIONS=	gconf
+
+.include "../../mk/bsd.options.mk"
+
+PLIST_VARS+=		gconf
+
+.if !empty(PKG_OPTIONS:Mgconf)
+PLIST.gconf=		yes
+CONFIGURE_ARGS+=	--enable-gconf
+CONFIGURE_ARGS+=	--enable-gconftool
+.include "../../devel/GConf/schemas.mk"
+.endif

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/47474: gst-plugins0.10-good pulls in gconf and gnome stuff
Date: Sun, 20 Jan 2013 09:47:06 +0100

 Looks good. Have you tried building the plugins and checked if any
 depend on the gconf option?
  Thomas

From: Taylor R Campbell <campbell+pkgsrc@mumble.net>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org,
	pkgsrc-bugs@netbsd.org
Subject: Re: pkg/47474: gst-plugins0.10-good pulls in gconf and gnome stuff
Date: Sun, 20 Jan 2013 08:55:36 +0000

    Date: Sun, 20 Jan 2013 08:50:05 +0000 (UTC)
    From: Thomas Klausner <wiz@NetBSD.org>

    Looks good. Have you tried building the plugins and checked if any
    depend on the gconf option?

 Last week I did a pbulk build and the only gst plugins that failed to
 build were those whose distfiles I couldn't get because of a transient
 network failure (and those for hal, gnome-vfs, and pulseaudio, which I
 intentionally disabled by rejecting dbus in my mk.conf).  I've been
 sitting on this patch for a year or two, I think, and successfully
 using a few gst plugins.

Responsible-Changed-From-To: pkg-manager->bsiegert
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Sat, 08 Aug 2015 21:00:49 +0000
Responsible-Changed-Why:
[x] has patch
[x] patch looks ok


State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 09 Aug 2015 21:57:02 +0000
State-Changed-Why:
alternatively, riastradh can commit his own patch :-)


Responsible-Changed-From-To: bsiegert->riastradh
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Sat, 03 Oct 2015 13:46:05 +0000
Responsible-Changed-Why:
Submitter is now a dev.


State-Changed-From-To: feedback->closed
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Sat, 20 Feb 2016 15:42:34 +0000
State-Changed-Why:
committed the fix years ago


>Unformatted:

Home	PR Database Search